From: "\"zhilizhao(赵志立)\"" <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] movenc: add write_btrt option
Date: Thu, 7 Apr 2022 18:34:07 +0800
Message-ID: <tencent_B9525A2834F780B634613EF156739C92E009@qq.com> (raw)
In-Reply-To: <AS8PR04MB8913BF826F8BC93E26ABD5E8F5E69@AS8PR04MB8913.eurprd04.prod.outlook.com>
> On Apr 7, 2022, at 4:42 PM, Eran Kornblau <eran.kornblau@kaltura.com> wrote:
>
>>
>>
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of "zhilizhao(???)"
>> Sent: Wednesday, 6 April 2022 11:46
>> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
>> Subject: Re: [FFmpeg-devel] movenc: add write_btrt option
>>>
>>> supports forcing or disabling the writing of the btrt atom.
>>> the default behavior is to write the atom only for mp4 mode.
>>> ---
>>> libavformat/movenc.c | 30 +++++++++++++++++++-----------
>>> libavformat/movenc.h | 1 +
>>> 2 files changed, 20 insertions(+), 11 deletions(-)
>>>
>>
>> I prefer to handle the auto mode (mov->write_btrt == -1) in a single place, so we don’t need to change multiple lines if the condition changed, e.g., enable btrt for MODE_MOV. Please correct me if I’m wrong, mov_init() has all of the contexts to overwrite mov->write_btrt.
>>
> Makes sense, thanks for the feedback!
> Updated patch attached
LGTM.
>
> Eran
> <0001-movenc-add-write_btrt-option.patch>_______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-04-07 10:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-03 5:07 Eran Kornblau
2022-04-06 8:46 ` "zhilizhao(赵志立)"
2022-04-07 8:42 ` Eran Kornblau
2022-04-07 10:34 ` "zhilizhao(赵志立)" [this message]
2022-04-07 20:36 ` Jan Ekström
2022-04-08 2:47 ` "zhilizhao(赵志立)"
2022-04-08 10:48 ` Jan Ekström
2022-04-10 6:03 ` Eran Kornblau
2022-04-17 6:47 ` Eran Kornblau
2022-04-25 11:25 ` Eran Kornblau
2022-05-02 9:33 ` Eran Kornblau
2022-05-02 9:41 ` Gyan Doshi
2022-05-02 13:05 ` "zhilizhao(赵志立)"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_B9525A2834F780B634613EF156739C92E009@qq.com \
--to=quinkblack@foxmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git