From: Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] Replace FFMIN/FFMAX by type specific macros
Date: Sun, 1 Jun 2025 01:54:42 +0800
Message-ID: <tencent_B5C54EE670FE2D1E9ACB40E99A459F13AB08@qq.com> (raw)
In-Reply-To: <4259f84c-c6f3-3f94-917d-d32a0c0a79b3@passwd.hu>
> On Jun 1, 2025, at 01:40, Marton Balint <cus@passwd.hu> wrote:
>
>
> On Sat, 31 May 2025, Michael Niedermayer wrote:
>
>> This allows adjusting them to exactly match whatever is fastest on
>> a given CPU for each type.
>
> Did you use some tool to make this patch, or it was just manual work?
>
> Can't you use C11 generics to make this somewhat automatic?
doc/developer says "for the public headers which must stay C99 compatible."
>
> And if we are introducing something new, do we really want to stick to MIN/MAX macros which possibly evaluate their argument multiple times? It was always an issue, so I would love to see us moving away from it.
>
> Thanks,
> Marton
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-05-31 17:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-31 13:32 Michael Niedermayer
2025-05-31 13:32 ` [FFmpeg-devel] [PATCH 2/2] avutil/opt: round min/max in integer context Michael Niedermayer
2025-05-31 17:40 ` [FFmpeg-devel] [PATCH 1/2] Replace FFMIN/FFMAX by type specific macros Marton Balint
2025-05-31 17:54 ` Zhao Zhili [this message]
2025-06-01 22:07 ` Michael Niedermayer
2025-06-02 15:06 ` Rémi Denis-Courmont
2025-06-02 15:47 ` Andreas Rheinhardt
2025-06-02 18:28 ` Rémi Denis-Courmont
2025-06-04 1:05 ` Michael Niedermayer
2025-06-07 23:29 ` Michael Niedermayer
2025-06-07 23:37 ` Andreas Rheinhardt
2025-06-08 20:16 ` Michael Niedermayer
2025-06-08 20:47 ` Andreas Rheinhardt
2025-06-08 6:51 ` Marton Balint
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_B5C54EE670FE2D1E9ACB40E99A459F13AB08@qq.com \
--to=quinkblack-at-foxmail.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git