Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Zhao Zhili <quinkblack@foxmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Zhao Zhili <zhilizhao@tencent.com>
Subject: [FFmpeg-devel] [PATCH v4 11/11] avfilter/vf_dnn_detect: Fix null pointer dereference
Date: Wed,  8 May 2024 00:08:18 +0800
Message-ID: <tencent_B4AB144EA270112D779A4B403D9ADD9F7A08@qq.com> (raw)
In-Reply-To: <20240507160818.71113-1-quinkblack@foxmail.com>

From: Zhao Zhili <zhilizhao@tencent.com>

Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
---
 libavfilter/vf_dnn_detect.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/libavfilter/vf_dnn_detect.c b/libavfilter/vf_dnn_detect.c
index b4eee06fe7..2a277d4169 100644
--- a/libavfilter/vf_dnn_detect.c
+++ b/libavfilter/vf_dnn_detect.c
@@ -807,11 +807,13 @@ static av_cold void dnn_detect_uninit(AVFilterContext *context)
     DnnDetectContext *ctx = context->priv;
     AVDetectionBBox *bbox;
     ff_dnn_uninit(&ctx->dnnctx);
-    while(av_fifo_can_read(ctx->bboxes_fifo)) {
-        av_fifo_read(ctx->bboxes_fifo, &bbox, 1);
-        av_freep(&bbox);
+    if (ctx->bboxes_fifo) {
+        while (av_fifo_can_read(ctx->bboxes_fifo)) {
+            av_fifo_read(ctx->bboxes_fifo, &bbox, 1);
+            av_freep(&bbox);
+        }
+        av_fifo_freep2(&ctx->bboxes_fifo);
     }
-    av_fifo_freep2(&ctx->bboxes_fifo);
     av_freep(&ctx->anchors);
     free_detect_labels(ctx);
 }
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2024-05-07 16:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240507160818.71113-1-quinkblack@foxmail.com>
2024-05-07 16:08 ` [FFmpeg-devel] [PATCH v4 01/11] avfilter/dnn: Refactor DNN parameter configuration system Zhao Zhili
2024-05-18 12:18   ` Guo, Yejun
2024-05-07 16:08 ` [FFmpeg-devel] [PATCH v4 02/11] avfilter/dnn: Use dnn_backend_info_list to search for dnn module Zhao Zhili
2024-05-07 16:08 ` [FFmpeg-devel] [PATCH v4 03/11] avfilter/dnn: Don't show backends which are not supported by a filter Zhao Zhili
2024-05-07 16:08 ` [FFmpeg-devel] [PATCH v4 04/11] avfilter/dnn_backend_openvino: Fix free context at random place Zhao Zhili
2024-05-07 16:08 ` [FFmpeg-devel] [PATCH v4 05/11] avfilter/dnn_backend_openvino: simplify memory allocation Zhao Zhili
2024-05-07 16:08 ` [FFmpeg-devel] [PATCH v4 06/11] avfilter/dnn_backend_tf: Remove one level of indentation Zhao Zhili
2024-05-07 16:08 ` [FFmpeg-devel] [PATCH v4 07/11] avfilter/dnn_backend_tf: Fix free context at random place Zhao Zhili
2024-05-07 16:08 ` [FFmpeg-devel] [PATCH v4 08/11] avfilter/dnn_backend_tf: Simplify memory allocation Zhao Zhili
2024-05-07 16:08 ` [FFmpeg-devel] [PATCH v4 09/11] avfilter/dnn_backend_torch: " Zhao Zhili
2024-05-07 16:08 ` [FFmpeg-devel] [PATCH v4 10/11] avfilter/dnn: Remove a level of dereference Zhao Zhili
2024-05-30 13:15   ` Guo, Yejun
2024-05-07 16:08 ` Zhao Zhili [this message]
2024-05-21  7:11   ` [FFmpeg-devel] [PATCH v4 11/11] avfilter/vf_dnn_detect: Fix null pointer dereference Andreas Rheinhardt
2024-05-21 11:01     ` Guo, Yejun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_B4AB144EA270112D779A4B403D9ADD9F7A08@qq.com \
    --to=quinkblack@foxmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=zhilizhao@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git