* [FFmpeg-devel] [PATCH v3] avformat/whip: mark as experimental @ 2025-06-09 10:24 Jack Lau via ffmpeg-devel 2025-06-09 13:19 ` Tristan Matthews 0 siblings, 1 reply; 6+ messages in thread From: Jack Lau via ffmpeg-devel @ 2025-06-09 10:24 UTC (permalink / raw) To: ffmpeg-devel; +Cc: Jack Lau [-- Attachment #1: Type: message/rfc822, Size: 3260 bytes --] From: Jack Lau <jacklau1222@qq.com> To: ffmpeg-devel@ffmpeg.org Cc: Jack Lau <jacklau1222@qq.com> Subject: [PATCH v3] avformat/whip: mark as experimental Date: Mon, 9 Jun 2025 18:24:46 +0800 Message-ID: <tencent_925E644E70467267F1F8F2C6FCA03EB48609@qq.com> Signed-off-by: Jack Lau <jacklau1222@qq.com> --- libavformat/whip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/whip.c b/libavformat/whip.c index 710f24fc5a..bb7b8657dc 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -1907,7 +1907,7 @@ const FFOutputFormat ff_whip_muxer = { .p.long_name = NULL_IF_CONFIG_SMALL("WHIP(WebRTC-HTTP ingestion protocol) muxer"), .p.audio_codec = AV_CODEC_ID_OPUS, .p.video_codec = AV_CODEC_ID_H264, - .p.flags = AVFMT_GLOBALHEADER | AVFMT_NOFILE, + .p.flags = AVFMT_GLOBALHEADER | AVFMT_NOFILE | AVFMT_EXPERIMENTAL, .p.priv_class = &whip_muxer_class, .priv_data_size = sizeof(WHIPContext), .init = whip_init, -- 2.49.0 [-- Attachment #2: Type: text/plain, Size: 251 bytes --] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH v3] avformat/whip: mark as experimental 2025-06-09 10:24 [FFmpeg-devel] [PATCH v3] avformat/whip: mark as experimental Jack Lau via ffmpeg-devel @ 2025-06-09 13:19 ` Tristan Matthews 2025-06-09 13:47 ` Jack Lau 0 siblings, 1 reply; 6+ messages in thread From: Tristan Matthews @ 2025-06-09 13:19 UTC (permalink / raw) To: FFmpeg development discussions and patches; +Cc: Jack Lau Hi, On Mon, Jun 9, 2025 at 6:25 AM Jack Lau via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote: > > > > > ---------- Forwarded message ---------- > From: Jack Lau <jacklau1222@qq.com> > To: ffmpeg-devel@ffmpeg.org > Cc: Jack Lau <jacklau1222@qq.com> > Bcc: > Date: Mon, 9 Jun 2025 18:24:46 +0800 > Subject: [PATCH v3] avformat/whip: mark as experimental > Signed-off-by: Jack Lau <jacklau1222@qq.com> > --- > libavformat/whip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/whip.c b/libavformat/whip.c > index 710f24fc5a..bb7b8657dc 100644 > --- a/libavformat/whip.c > +++ b/libavformat/whip.c > @@ -1907,7 +1907,7 @@ const FFOutputFormat ff_whip_muxer = { > .p.long_name = NULL_IF_CONFIG_SMALL("WHIP(WebRTC-HTTP ingestion protocol) muxer"), > .p.audio_codec = AV_CODEC_ID_OPUS, > .p.video_codec = AV_CODEC_ID_H264, > - .p.flags = AVFMT_GLOBALHEADER | AVFMT_NOFILE, > + .p.flags = AVFMT_GLOBALHEADER | AVFMT_NOFILE | AVFMT_EXPERIMENTAL, > .p.priv_class = &whip_muxer_class, > .priv_data_size = sizeof(WHIPContext), > .init = whip_init, > -- > 2.49.0 > You may want to update the intended usage example in doc/muxers.texi to include the `experimental` flag (probably in a separate patch). Best, Tristan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH v3] avformat/whip: mark as experimental 2025-06-09 13:19 ` Tristan Matthews @ 2025-06-09 13:47 ` Jack Lau 2025-06-09 13:58 ` Zhao Zhili 2025-06-09 14:05 ` Tristan Matthews 0 siblings, 2 replies; 6+ messages in thread From: Jack Lau @ 2025-06-09 13:47 UTC (permalink / raw) To: FFmpeg development discussions and patches > On Jun 9, 2025, at 21:19, Tristan Matthews <tmatth@videolan.org> wrote: > > Hi, > > > On Mon, Jun 9, 2025 at 6:25 AM Jack Lau via ffmpeg-devel > <ffmpeg-devel@ffmpeg.org> wrote: >> >> >> >> >> ---------- Forwarded message ---------- >> From: Jack Lau <jacklau1222@qq.com> >> To: ffmpeg-devel@ffmpeg.org >> Cc: Jack Lau <jacklau1222@qq.com> >> Bcc: >> Date: Mon, 9 Jun 2025 18:24:46 +0800 >> Subject: [PATCH v3] avformat/whip: mark as experimental >> Signed-off-by: Jack Lau <jacklau1222@qq.com> >> --- >> libavformat/whip.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavformat/whip.c b/libavformat/whip.c >> index 710f24fc5a..bb7b8657dc 100644 >> --- a/libavformat/whip.c >> +++ b/libavformat/whip.c >> @@ -1907,7 +1907,7 @@ const FFOutputFormat ff_whip_muxer = { >> .p.long_name = NULL_IF_CONFIG_SMALL("WHIP(WebRTC-HTTP ingestion protocol) muxer"), >> .p.audio_codec = AV_CODEC_ID_OPUS, >> .p.video_codec = AV_CODEC_ID_H264, >> - .p.flags = AVFMT_GLOBALHEADER | AVFMT_NOFILE, >> + .p.flags = AVFMT_GLOBALHEADER | AVFMT_NOFILE | AVFMT_EXPERIMENTAL, >> .p.priv_class = &whip_muxer_class, >> .priv_data_size = sizeof(WHIPContext), >> .init = whip_init, >> -- >> 2.49.0 >> > > You may want to update the intended usage example in doc/muxers.texi > to include the `experimental` flag (probably in a separate patch). Thanks for the reminder! I’ve sent the separate patch in https://patchwork.ffmpeg.org/project/ffmpeg/patch/mailman.2674.1749476775.1384.ffmpeg-devel@ffmpeg.org/ > > Best, > Tristan Thanks Jack > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH v3] avformat/whip: mark as experimental 2025-06-09 13:47 ` Jack Lau @ 2025-06-09 13:58 ` Zhao Zhili 2025-06-09 14:05 ` Tristan Matthews 1 sibling, 0 replies; 6+ messages in thread From: Zhao Zhili @ 2025-06-09 13:58 UTC (permalink / raw) To: FFmpeg development discussions and patches > On Jun 9, 2025, at 21:47, Jack Lau <jacklau1222gm-at-gmail.com@ffmpeg.org> wrote: > > > >> On Jun 9, 2025, at 21:19, Tristan Matthews <tmatth@videolan.org> wrote: >> >> Hi, >> >> >> On Mon, Jun 9, 2025 at 6:25 AM Jack Lau via ffmpeg-devel >> <ffmpeg-devel@ffmpeg.org> wrote: >>> >>> >>> >>> >>> ---------- Forwarded message ---------- >>> From: Jack Lau <jacklau1222@qq.com> >>> To: ffmpeg-devel@ffmpeg.org >>> Cc: Jack Lau <jacklau1222@qq.com> >>> Bcc: >>> Date: Mon, 9 Jun 2025 18:24:46 +0800 >>> Subject: [PATCH v3] avformat/whip: mark as experimental >>> Signed-off-by: Jack Lau <jacklau1222@qq.com> >>> --- >>> libavformat/whip.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/libavformat/whip.c b/libavformat/whip.c >>> index 710f24fc5a..bb7b8657dc 100644 >>> --- a/libavformat/whip.c >>> +++ b/libavformat/whip.c >>> @@ -1907,7 +1907,7 @@ const FFOutputFormat ff_whip_muxer = { >>> .p.long_name = NULL_IF_CONFIG_SMALL("WHIP(WebRTC-HTTP ingestion protocol) muxer"), >>> .p.audio_codec = AV_CODEC_ID_OPUS, >>> .p.video_codec = AV_CODEC_ID_H264, >>> - .p.flags = AVFMT_GLOBALHEADER | AVFMT_NOFILE, >>> + .p.flags = AVFMT_GLOBALHEADER | AVFMT_NOFILE | AVFMT_EXPERIMENTAL, >>> .p.priv_class = &whip_muxer_class, >>> .priv_data_size = sizeof(WHIPContext), >>> .init = whip_init, >>> -- >>> 2.49.0 >>> >> >> You may want to update the intended usage example in doc/muxers.texi >> to include the `experimental` flag (probably in a separate patch). > Thanks for the reminder! > I’ve sent the separate patch in https://patchwork.ffmpeg.org/project/ffmpeg/patch/mailman.2674.1749476775.1384.ffmpeg-devel@ffmpeg.org/ The code changes and document updates should be done in a single patch. >> >> Best, >> Tristan > > Thanks > Jack >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH v3] avformat/whip: mark as experimental 2025-06-09 13:47 ` Jack Lau 2025-06-09 13:58 ` Zhao Zhili @ 2025-06-09 14:05 ` Tristan Matthews 2025-06-09 14:13 ` Zhao Zhili 1 sibling, 1 reply; 6+ messages in thread From: Tristan Matthews @ 2025-06-09 14:05 UTC (permalink / raw) To: FFmpeg development discussions and patches Hi, On Mon, Jun 9, 2025 at 9:47 AM Jack Lau <jacklau1222gm-at-gmail.com@ffmpeg.org> wrote: > > > > > On Jun 9, 2025, at 21:19, Tristan Matthews <tmatth@videolan.org> wrote: > > > > Hi, > > > > > > On Mon, Jun 9, 2025 at 6:25 AM Jack Lau via ffmpeg-devel > > <ffmpeg-devel@ffmpeg.org> wrote: > >> > >> > >> > >> > >> ---------- Forwarded message ---------- > >> From: Jack Lau <jacklau1222@qq.com> > >> To: ffmpeg-devel@ffmpeg.org > >> Cc: Jack Lau <jacklau1222@qq.com> > >> Bcc: > >> Date: Mon, 9 Jun 2025 18:24:46 +0800 > >> Subject: [PATCH v3] avformat/whip: mark as experimental > >> Signed-off-by: Jack Lau <jacklau1222@qq.com> > >> --- > >> libavformat/whip.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/libavformat/whip.c b/libavformat/whip.c > >> index 710f24fc5a..bb7b8657dc 100644 > >> --- a/libavformat/whip.c > >> +++ b/libavformat/whip.c > >> @@ -1907,7 +1907,7 @@ const FFOutputFormat ff_whip_muxer = { > >> .p.long_name = NULL_IF_CONFIG_SMALL("WHIP(WebRTC-HTTP ingestion protocol) muxer"), > >> .p.audio_codec = AV_CODEC_ID_OPUS, > >> .p.video_codec = AV_CODEC_ID_H264, > >> - .p.flags = AVFMT_GLOBALHEADER | AVFMT_NOFILE, > >> + .p.flags = AVFMT_GLOBALHEADER | AVFMT_NOFILE | AVFMT_EXPERIMENTAL, > >> .p.priv_class = &whip_muxer_class, > >> .priv_data_size = sizeof(WHIPContext), > >> .init = whip_init, > >> -- > >> 2.49.0 > >> > > > > You may want to update the intended usage example in doc/muxers.texi > > to include the `experimental` flag (probably in a separate patch). > Thanks for the reminder! > I’ve sent the separate patch in https://patchwork.ffmpeg.org/project/ffmpeg/patch/mailman.2674.1749476775.1384.ffmpeg-devel@ffmpeg.org/ > > I was talking about the ffmpeg one-liner usage example specifically, here: https://git.ffmpeg.org/gitweb/ffmpeg.git/blob/refs/heads/master:/doc/muxers.texi#l3896 Best, -t _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH v3] avformat/whip: mark as experimental 2025-06-09 14:05 ` Tristan Matthews @ 2025-06-09 14:13 ` Zhao Zhili 0 siblings, 0 replies; 6+ messages in thread From: Zhao Zhili @ 2025-06-09 14:13 UTC (permalink / raw) To: FFmpeg development discussions and patches > On Jun 9, 2025, at 22:05, Tristan Matthews <tmatth@videolan.org> wrote: > > Hi, > > On Mon, Jun 9, 2025 at 9:47 AM Jack Lau > <jacklau1222gm-at-gmail.com@ffmpeg.org> wrote: >> >> >> >>> On Jun 9, 2025, at 21:19, Tristan Matthews <tmatth@videolan.org> wrote: >>> >>> Hi, >>> >>> >>> On Mon, Jun 9, 2025 at 6:25 AM Jack Lau via ffmpeg-devel >>> <ffmpeg-devel@ffmpeg.org> wrote: >>>> >>>> >>>> >>>> >>>> ---------- Forwarded message ---------- >>>> From: Jack Lau <jacklau1222@qq.com> >>>> To: ffmpeg-devel@ffmpeg.org >>>> Cc: Jack Lau <jacklau1222@qq.com> >>>> Bcc: >>>> Date: Mon, 9 Jun 2025 18:24:46 +0800 >>>> Subject: [PATCH v3] avformat/whip: mark as experimental >>>> Signed-off-by: Jack Lau <jacklau1222@qq.com> >>>> --- >>>> libavformat/whip.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/libavformat/whip.c b/libavformat/whip.c >>>> index 710f24fc5a..bb7b8657dc 100644 >>>> --- a/libavformat/whip.c >>>> +++ b/libavformat/whip.c >>>> @@ -1907,7 +1907,7 @@ const FFOutputFormat ff_whip_muxer = { >>>> .p.long_name = NULL_IF_CONFIG_SMALL("WHIP(WebRTC-HTTP ingestion protocol) muxer"), >>>> .p.audio_codec = AV_CODEC_ID_OPUS, >>>> .p.video_codec = AV_CODEC_ID_H264, >>>> - .p.flags = AVFMT_GLOBALHEADER | AVFMT_NOFILE, >>>> + .p.flags = AVFMT_GLOBALHEADER | AVFMT_NOFILE | AVFMT_EXPERIMENTAL, >>>> .p.priv_class = &whip_muxer_class, >>>> .priv_data_size = sizeof(WHIPContext), >>>> .init = whip_init, >>>> -- >>>> 2.49.0 >>>> >>> >>> You may want to update the intended usage example in doc/muxers.texi >>> to include the `experimental` flag (probably in a separate patch). >> Thanks for the reminder! >> I’ve sent the separate patch in https://patchwork.ffmpeg.org/project/ffmpeg/patch/mailman.2674.1749476775.1384.ffmpeg-devel@ffmpeg.org/ >>> > > I was talking about the ffmpeg one-liner usage example specifically, here: > https://git.ffmpeg.org/gitweb/ffmpeg.git/blob/refs/heads/master:/doc/muxers.texi#l3896 It doesn’t need to be updated since AVFMT_EXPERIMENTAL has no effect if user specify the muxer explicitly, that is “-f whip”. Copy-paste from another thread: The AVFMT_EXPERIMENTAL flag is different from AV_CODEC_CAP_EXPERIMENTAL, that AVFMT_EXPERIMENTALl flag doesn’t check against strict_std_compliance. It’s kind of overlap for these two flags. There are practical reasons, like the AVFMT_EXPERIMENTAL need to check early. And when user specify the demuxer/muxer explicitly, it make sense to skip the check. So, when WHIP add AVFMT_EXPERIMENTAL flag, it has no real effect since WHIP is always specified explicitly, except user can check and see the flag. https://ffmpeg.org/pipermail/ffmpeg-devel/2025-June/344705.html > > Best, > -t > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-06-09 14:14 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2025-06-09 10:24 [FFmpeg-devel] [PATCH v3] avformat/whip: mark as experimental Jack Lau via ffmpeg-devel 2025-06-09 13:19 ` Tristan Matthews 2025-06-09 13:47 ` Jack Lau 2025-06-09 13:58 ` Zhao Zhili 2025-06-09 14:05 ` Tristan Matthews 2025-06-09 14:13 ` Zhao Zhili
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git