From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id 5BD5F4BFCD
	for <ffmpegdev@gitmailbox.com>; Tue,  1 Apr 2025 10:12:23 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2AD43687CBE;
	Tue,  1 Apr 2025 13:12:19 +0300 (EEST)
Received: from out203-205-221-239.mail.qq.com (out203-205-221-239.mail.qq.com
 [203.205.221.239])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 90074687BC8
 for <ffmpeg-devel@ffmpeg.org>; Tue,  1 Apr 2025 13:12:11 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com;
 s=s201512; t=1743502320;
 bh=Qn1VTccOoVrWDY6KDcBxj+UjEB2nlFKyULXOsHxPCsc=;
 h=From:To:Cc:Subject:Date;
 b=nhGnGwa/kQPBT3UHTRPLhPoBzCMcMnK6vhGtEwzUsKTPb93aOAyTysczs4ICkzVuT
 QOtuIyhOfobQcB5sX5MXLy0ABFRyOuxCeJ73g2N3xCJ/AMxENPTlGLiUBQ6d7G2PIG
 jwmHwrBHJ00y7oICt3kFTrYbjrK/C9f45I4DLupE=
Received: from localhost.localdomain ([119.147.10.242])
 by newxmesmtplogicsvrszgpua8-1.qq.com (NewEsmtp) with SMTP
 id 2FB31C5A; Tue, 01 Apr 2025 18:11:59 +0800
X-QQ-mid: xmsmtpt1743502319t539u9vos
Message-ID: <tencent_B376AB234EFA70AA2D159A3B40469A319F08@qq.com>
X-QQ-XMAILINFO: M0PjjqbLT90wRRD769sLBQcM/dBDFjPHO35p5kRg7P97ZbQHvLUX9d3yM982nE
 SIzTaHwbuqmQSV9Is02Ak0rqSz5L7aeNRVdbWMEfBMGYH//Cw57jzpti5A2xhdYis3T+sWoSmpI7
 uvqbxfoTa0aw3adfssUF/X/6F7OI56WGy/aWOhSDfpQA6BekVkppzCn/zEHuRt9oTPNta2NYOQfv
 CyNa2hwPivQ/jCLJQ/M/7B1m9+rh7mZaGsVxdjzn4TGG+taArSKVeAM1259WZoSlIMKR2X0LYZxZ
 hehbAZ18Yt+KEsm8b23KaUUCd/R9OZY7HbM8jha0beD2UEYuEW8VLUTkwwxf9hNVUSKzMeeg8ZpT
 nQ4lNkmo8hAPZFfwLwvl9clqWshMlV1ws5MhUZoLEsacVj+cJo921jmkr8eEjchUtx/08hXJ/TSj
 OoYaFXYcnbvMLRKsClnPIyWbmm7GryNF7imYOILOtjuOPe2SNnwt209NfCqbqYGV5UuDvPYzotDC
 fdkvK6PKESMA/Khre9ZBZ/w1OSYRA3EgtzKyxU16zXWGq58GJZH3owOMnt9/29gXAcuydf1tARat
 LQzturrFk6ofsCaiyKqKLVcHEOjcRNKYbCIX/YT/u6ryEnR5uWnNFLDIPO54S7rmwQpPtMcpSC46
 1uYmB912HwPxBpm7qyAJ/afDvHfg0NedoXXcY3XLTWxNFA8UXJ4e9lKEkpZR9Hpqmy94GPbRM4cz
 5GXlJ+Ur7rzFeUPeqeAo2ONdHKvnGY8ovmkqYopiQ7IGhQBLYYhWheM+U3Ew27gdhxQmde1MZgP7
 i81/4xv2izQg1oWBYr8H7dZ6LzzaCMgNmYarQXF8W4DR8Fb/HzHsLX4BFieR8UX9pQVembsriPmn
 5oruMVlkW8hBA1lN/Ievsgomi2rsjg/dCjpN9N2/ux9NYJoHicRmsppyLuUESNKSALzA/zg0cwxN
 fijUTVJ71h46YNkud/Z/lBeY1C/i2V
X-QQ-XMRINFO: Mp0Kj//9VHAxr69bL5MkOOs=
From: Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Date: Tue,  1 Apr 2025 18:11:58 +0800
X-OQ-MSGID: <20250401101158.84648-1-quinkblack@foxmail.com>
X-Mailer: git-send-email 2.46.0
MIME-Version: 1.0
Subject: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: Reset optional fields
 when parse format
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Zhao Zhili <zhilizhao@tencent.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/tencent_B376AB234EFA70AA2D159A3B40469A319F08@qq.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

From: Zhao Zhili <zhilizhao@tencent.com>

Parse format can be called multiple times, e.g., when resolution
changed. If getInt32 fails, optional member variables will retain
their previously set values without modification. This can be a
big problem for new resolution with old crop info.

This patch reset optional fields to zero when getInt32 failed.
---
 libavcodec/mediacodecdec_common.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavcodec/mediacodecdec_common.c b/libavcodec/mediacodecdec_common.c
index 8a270f2f29..ae336ab835 100644
--- a/libavcodec/mediacodecdec_common.c
+++ b/libavcodec/mediacodecdec_common.c
@@ -537,6 +537,8 @@ static int mediacodec_wrap_sw_buffer(AVCodecContext *avctx,
         av_log(avctx, AV_LOG_ERROR, "Could not get %s from format %s\n", key, format); \
         ret = AVERROR_EXTERNAL;                                                        \
         goto fail;                                                                     \
+    } else {                                                                           \
+        (name) = 0;                                                                    \
     }                                                                                  \
 } while (0)                                                                            \
 
-- 
2.46.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".