From: Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Shiqi Zhu <hiccupzhu@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/volume: optimize redundant code for af_volume
Date: Mon, 21 Apr 2025 15:03:27 +0800
Message-ID: <tencent_B2336B55C62905CEB8654B731BE84F73F705@qq.com> (raw)
In-Reply-To: <20250421060452.4014124-1-hiccupzhu@gmail.com>
> On Apr 21, 2025, at 14:04, Shiqi Zhu <hiccupzhu@gmail.com> wrote:
>
> Signed-off-by: Shiqi Zhu <hiccupzhu@gmail.com>
> ---
> libavfilter/af_volume.c | 18 ++++++------------
> 1 file changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/libavfilter/af_volume.c b/libavfilter/af_volume.c
> index 471bffeceb..c16188524d 100644
> --- a/libavfilter/af_volume.c
> +++ b/libavfilter/af_volume.c
> @@ -178,34 +178,28 @@ static inline void scale_samples_u8_small(uint8_t *dst, const uint8_t *src,
> dst[i] = av_clip_uint8((((src[i] - 128) * volume + 128) >> 8) + 128);
> }
>
> -static inline void scale_samples_s16(uint8_t *dst, const uint8_t *src,
> +static inline void scale_samples_s16(int16_t *dst, const int16_t *src,
> int nb_samples, int volume)
> {
> int i;
> - int16_t *smp_dst = (int16_t *)dst;
> - const int16_t *smp_src = (const int16_t *)src;
> for (i = 0; i < nb_samples; i++)
> - smp_dst[i] = av_clip_int16(((int64_t)smp_src[i] * volume + 128) >> 8);
> + dst[i] = av_clip_int16(((int64_t)src[i] * volume + 128) >> 8);
> }
>
> -static inline void scale_samples_s16_small(uint8_t *dst, const uint8_t *src,
> +static inline void scale_samples_s16_small(int16_t *dst, const int16_t *src,
> int nb_samples, int volume)
> {
> int i;
> - int16_t *smp_dst = (int16_t *)dst;
> - const int16_t *smp_src = (const int16_t *)src;
> for (i = 0; i < nb_samples; i++)
> - smp_dst[i] = av_clip_int16((smp_src[i] * volume + 128) >> 8);
> + dst[i] = av_clip_int16((src[i] * volume + 128) >> 8);
> }
>
> -static inline void scale_samples_s32(uint8_t *dst, const uint8_t *src,
> +static inline void scale_samples_s32(int32_t *dst, const int32_t *src,
> int nb_samples, int volume)
> {
> int i;
> - int32_t *smp_dst = (int32_t *)dst;
> - const int32_t *smp_src = (const int32_t *)src;
> for (i = 0; i < nb_samples; i++)
> - smp_dst[i] = av_clipl_int32((((int64_t)smp_src[i] * volume + 128) >> 8));
> + dst[i] = av_clipl_int32((((int64_t)src[i] * volume + 128) >> 8));
> }
>
> static av_cold void volume_init(VolumeContext *vol)
NAK. They are incompatible function pointer types.
> --
> 2.34.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-04-21 7:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 6:04 Shiqi Zhu
2025-04-21 7:03 ` Zhao Zhili [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_B2336B55C62905CEB8654B731BE84F73F705@qq.com \
--to=quinkblack-at-foxmail.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=hiccupzhu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git