From: "\"zhilizhao(赵志立)\"" <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3 4/5] avformat/movenc: add PCM in mp4 support
Date: Tue, 7 Mar 2023 10:30:54 +0800
Message-ID: <tencent_B0EA536915CCC9128EBAA54E730D28535305@qq.com> (raw)
In-Reply-To: <31b7d6225000dc9e081cb8de36720d842963d684.camel@haerdin.se>
> On Mar 6, 2023, at 20:28, Tomas Härdin <git@haerdin.se> wrote:
>
>> +static int mov_write_chnl_tag(AVFormatContext *s, AVIOContext *pb,
>> MOVTrack *track)
>> +{
>> + int64_t pos = avio_tell(pb);
>> + int config = 0;
>> + int ret;
>> + uint8_t *speaker_pos = NULL;
>> + const AVChannelLayout *layout = &track->par->ch_layout;
>> +
>> + ret = ff_mov_get_channel_config_from_layout(layout, &config);
>> + if (ret || !config) {
>
> ret is always 0..
That implementation details. It’s robust for caller to not depending
on that.
>
>
> /Tomas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-03-07 2:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230306120211.1249250-1-quinkblack@foxmail.com>
2023-03-06 12:02 ` [FFmpeg-devel] [PATCH v3 1/5] avformat/mov: fix ISO/IEC 23003-5 support Zhao Zhili
2023-03-06 12:02 ` [FFmpeg-devel] [PATCH v3 2/5] avformat/isom_tags: remove ipcm from movaudio_tags Zhao Zhili
2023-03-06 12:02 ` [FFmpeg-devel] [PATCH v3 3/5] avformat/mov: parse ISO-14496-12 ChannelLayout Zhao Zhili
2023-03-06 12:26 ` Tomas Härdin
2023-03-07 2:27 ` "zhilizhao(赵志立)"
2023-03-06 12:02 ` [FFmpeg-devel] [PATCH v3 4/5] avformat/movenc: add PCM in mp4 support Zhao Zhili
2023-03-06 12:28 ` Tomas Härdin
2023-03-07 2:30 ` "zhilizhao(赵志立)" [this message]
2023-03-07 13:55 ` Tomas Härdin
2023-03-06 12:02 ` [FFmpeg-devel] [PATCH v3 5/5] fate/mov: add PCM in mp4 test Zhao Zhili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_B0EA536915CCC9128EBAA54E730D28535305@qq.com \
--to=quinkblack@foxmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git