From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AC5164B2F3 for ; Mon, 3 Jun 2024 13:02:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E8B7468D690; Mon, 3 Jun 2024 16:02:55 +0300 (EEST) Received: from out203-205-251-84.mail.qq.com (unknown [203.205.251.84]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2BFC668D441 for ; Mon, 3 Jun 2024 16:02:47 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1717419758; bh=k1B6Lb7JwrEwdY6ZbPC1RET3QUx6NiH49hv/WbpVNVY=; h=From:To:Cc:Subject:Date; b=rTvH8W8dxQVAX136/ywk1HBp+gDFSbNj/MWWRqZT28m9LE8HPRT2Z8IX7nat+1aJ8 Q7T3/a856/uWrbSeMNWavL3oO9qmiATbpArjH9CW9DPJ58MnG5G3plvOOFxHrVd28/ Gr2wgZ4Lu6SGuAkcHjubMFr80NL52tMJl7P3d9n0= Received: from ZHILIZHAO-MB1.tencent.com ([119.147.10.191]) by newxmesmtplogicsvrszc5-2.qq.com (NewEsmtp) with SMTP id A506025; Mon, 03 Jun 2024 21:02:37 +0800 X-QQ-mid: xmsmtpt1717419757thhm8vgjy Message-ID: X-QQ-XMAILINFO: Mm/8i8/T4ynexzOOgDPIg5dAonCQKDmwOzqxUBr+8P/t4mEKb8qMfMAnq4I0AO p1N+eWAN2cpgPrJdzdvzznyVhYMzYbJP2rOUVuVrNrST+q39jWi1dUeODuxs+2DiQ4uyJYcBtJm/ lPc7BQhXDDYFnwICsA2bQd1EYeNkdeaTGA+s+FOsONhITasszXHnf2/X/n8Ur2svmK51JzmDVQUH yGF+Z/FO/fpOw4dosZcdnIRtiVbUFk/oDmJUuXpc9oXWyGiksm6EKqGmUF2GRuHGCrAeHVQbtMEQ /qxjkHnsKvD6b39ngycXzjcS8crLqVdIFR+tzARVeAr/hla+L1Ir4jFa9k0EpcQ/jZvcBxZaciMl 3N6ikLY302hLZateotup/O4ldTzwcF8BEg5LTP1h4OiTUsm9gJ7t6XjZLTJpjv4FlRvHimGbCptd HfkKdUd7V1vngX/iCN+0Nnpte4uaBlYLuhonX1kddwPZgY6gj3rX4LOLCg2rux8uQMPmSdOzcVv2 rbYaoJIQ9/IJjbllRm5u5DlKD0ce2sF95CQq0ZFstBhx8N9XSsvwgH4rLnkaUXB2BxfLOKEFvDCk Yl4Pz2zpKjJNkLwa0cFiiTPOEt9kJHIgikQQA7H9UuDFGnCDADEO0QHqHexXIm+G2oqVV3k25bdP KsBBlS2R6c/rwYH91EwuOn66rHhIdhucIC9co/IUebwYWcAJzaDxPRmxiSqgR+fel+6d4O5HNZ3O HLH64Ksh4bUB7NgD5ActCrRFfw08H73B3AZPk/zCZr0fZ0AerGzLWC/UGNcTxXVX+pL+0RKC8M3Y RMB6dLoiu6Syp4qpWe3woGXJ9xGppD/wfJByZKGfoQxJhCYbwbtY4pAHecLDnqzP69aTlhmh6xNY OSHJ8YQBHGpamUF4KFL5OzoR+24As1SvMztF5TB1Ax/RE7u0w/FwAgP479Zi99wOIaud0ci/SVv9 XMp00D2QZqQPmF1h66udacL8YxZ6xYUVzMThxCqZtUx38VLEvTdi/9FZQvS1nXjshDI1d6LIivVe u4tR2YLw== X-QQ-XMRINFO: OWPUhxQsoeAVDbp3OJHYyFg= From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Mon, 3 Jun 2024 21:02:32 +0800 X-OQ-MSGID: <20240603130233.77057-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [WIP PATCH 1/2] checkasm/sw_rgb: test rgb24 to yuv X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Zhao Zhili --- The test still failed on x86, but success on arm64 and longarch. I have tried to call rgb24ToY_c and ff_rgb24ToY_avx directly and compare the results, they don't match. https://github.com/quink-black/FFmpeg/actions/runs/9347753270 https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_90E6136AF5D6E919AEA9254393048855B305@qq.com/ tests/checkasm/sw_rgb.c | 123 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 123 insertions(+) diff --git a/tests/checkasm/sw_rgb.c b/tests/checkasm/sw_rgb.c index 7cd815e5be..18fd4255a6 100644 --- a/tests/checkasm/sw_rgb.c +++ b/tests/checkasm/sw_rgb.c @@ -24,6 +24,8 @@ #include "libavutil/mem_internal.h" #include "libswscale/rgb2rgb.h" +#include "libswscale/swscale.h" +#include "libswscale/swscale_internal.h" #include "checkasm.h" @@ -41,6 +43,7 @@ static const struct {uint8_t w, h, s;} planes[] = { #define MAX_STRIDE 128 #define MAX_HEIGHT 128 +#define LARGEST_INPUT_SIZE 4096 static void check_shuffle_bytes(void * func, const char * report) { @@ -111,6 +114,120 @@ static void check_uyvy_to_422p(void) } } +static void check_rgb_to_y(void) +{ + struct SwsContext *ctx; + static const int input_sizes[] = {8, 128, 1280, 1080, LARGEST_INPUT_SIZE}; + int32_t rgb2yuv[9] = {0}; + + declare_func(void, uint8_t *dst, const uint8_t *src, + const uint8_t *unused1, const uint8_t *unused2, int width, + uint32_t *rgb2yuv, void *opq); + + LOCAL_ALIGNED_32(uint8_t, src, [LARGEST_INPUT_SIZE * 3]); + LOCAL_ALIGNED_32(uint8_t, dst0_y, [LARGEST_INPUT_SIZE * 2]); + LOCAL_ALIGNED_32(uint8_t, dst1_y, [LARGEST_INPUT_SIZE * 2]); + + randomize_buffers(src, LARGEST_INPUT_SIZE * 3); + rgb2yuv[BY_IDX] = ((int)(0.114 * 219 / 255 * (1 << RGB2YUV_SHIFT) + 0.5)); + rgb2yuv[BV_IDX] = (-(int)(0.081 * 224 / 255 * (1 << RGB2YUV_SHIFT) + 0.5)); + rgb2yuv[BU_IDX] = ((int)(0.500 * 224 / 255 * (1 << RGB2YUV_SHIFT) + 0.5)); + rgb2yuv[GY_IDX] = ((int)(0.587 * 219 / 255 * (1 << RGB2YUV_SHIFT) + 0.5)); + rgb2yuv[GV_IDX] = (-(int)(0.419 * 224 / 255 * (1 << RGB2YUV_SHIFT) + 0.5)); + rgb2yuv[GU_IDX] = (-(int)(0.331 * 224 / 255 * (1 << RGB2YUV_SHIFT) + 0.5)); + rgb2yuv[RY_IDX] = ((int)(0.299 * 219 / 255 * (1 << RGB2YUV_SHIFT) + 0.5)); + rgb2yuv[RV_IDX] = ((int)(0.500 * 224 / 255 * (1 << RGB2YUV_SHIFT) + 0.5)); + rgb2yuv[RU_IDX] = (-(int)(0.169 * 224 / 255 * (1 << RGB2YUV_SHIFT) + 0.5)); + + ctx = sws_alloc_context(); + if (sws_init_context(ctx, NULL, NULL) < 0) + fail(); + + for (int i = 0; i < FF_ARRAY_ELEMS(input_sizes); i++) { + int w = input_sizes[i]; + + ctx->srcFormat = AV_PIX_FMT_RGB24; + ctx->dstFormat = AV_PIX_FMT_YUV420P; + + ff_sws_init_scale(ctx); + if (check_func(ctx->lumToYV12, "rgb24_to_y_%d", w)) { + memset(dst0_y, 0xFF, LARGEST_INPUT_SIZE * 2); + memset(dst1_y, 0xFF, LARGEST_INPUT_SIZE * 2); + + call_ref(dst0_y, src, NULL, NULL, w, rgb2yuv, NULL); + call_new(dst1_y, src, NULL, NULL, w, rgb2yuv, NULL); + + if (memcmp(dst0_y, dst1_y, w * 2)) + fail(); + + bench_new(dst1_y, src, NULL, NULL, w, rgb2yuv, NULL); + } + } + + sws_freeContext(ctx); +} + +static void check_rgb_to_uv(void) +{ + struct SwsContext *ctx; + static const int input_sizes[] = {8, 128, 1280, 1080, LARGEST_INPUT_SIZE}; + int32_t rgb2yuv[9] = {0}; + + declare_func(void, uint8_t *dstU, uint8_t *dstV, + const uint8_t *src1, const uint8_t *src2, const uint8_t *src3, + int width, uint32_t *pal, void *opq); + + LOCAL_ALIGNED_32(uint8_t, src, [LARGEST_INPUT_SIZE * 3]); + LOCAL_ALIGNED_32(uint8_t, dst0_u, [LARGEST_INPUT_SIZE * 2]); + LOCAL_ALIGNED_32(uint8_t, dst0_v, [LARGEST_INPUT_SIZE * 2]); + LOCAL_ALIGNED_32(uint8_t, dst1_u, [LARGEST_INPUT_SIZE * 2]); + LOCAL_ALIGNED_32(uint8_t, dst1_v, [LARGEST_INPUT_SIZE * 2]); + + randomize_buffers(src, LARGEST_INPUT_SIZE * 3); + rgb2yuv[BY_IDX] = ((int)(0.114 * 219 / 255 * (1 << RGB2YUV_SHIFT) + 0.5)); + rgb2yuv[BV_IDX] = (-(int)(0.081 * 224 / 255 * (1 << RGB2YUV_SHIFT) + 0.5)); + rgb2yuv[BU_IDX] = ((int)(0.500 * 224 / 255 * (1 << RGB2YUV_SHIFT) + 0.5)); + rgb2yuv[GY_IDX] = ((int)(0.587 * 219 / 255 * (1 << RGB2YUV_SHIFT) + 0.5)); + rgb2yuv[GV_IDX] = (-(int)(0.419 * 224 / 255 * (1 << RGB2YUV_SHIFT) + 0.5)); + rgb2yuv[GU_IDX] = (-(int)(0.331 * 224 / 255 * (1 << RGB2YUV_SHIFT) + 0.5)); + rgb2yuv[RY_IDX] = ((int)(0.299 * 219 / 255 * (1 << RGB2YUV_SHIFT) + 0.5)); + rgb2yuv[RV_IDX] = ((int)(0.500 * 224 / 255 * (1 << RGB2YUV_SHIFT) + 0.5)); + rgb2yuv[RU_IDX] = (-(int)(0.169 * 224 / 255 * (1 << RGB2YUV_SHIFT) + 0.5)); + + ctx = sws_alloc_context(); + if (sws_init_context(ctx, NULL, NULL) < 0) + fail(); + + for (int i = 0; i < 2; i++) { + for (int j = 0; j < FF_ARRAY_ELEMS(input_sizes); j++) { + int w = input_sizes[j] >> i; + + ctx->chrSrcHSubSample = i ? 1 : 0; + ctx->srcFormat = AV_PIX_FMT_RGB24; + ctx->dstFormat = i ? AV_PIX_FMT_YUV420P : AV_PIX_FMT_YUV444P; + + ff_sws_init_scale(ctx); + + if (check_func(ctx->chrToYV12, "rgb24_to_uv%s_%d", i ? "_half" : "", w)) { + memset(dst0_u, 0xFF, LARGEST_INPUT_SIZE * 2); + memset(dst0_v, 0xFF, LARGEST_INPUT_SIZE * 2); + memset(dst1_u, 0xFF, LARGEST_INPUT_SIZE * 2); + memset(dst1_v, 0xFF, LARGEST_INPUT_SIZE * 2); + + call_ref(dst0_u, dst0_v, NULL, src, src, w, rgb2yuv, NULL); + call_new(dst1_u, dst1_v, NULL, src, src, w, rgb2yuv, NULL); + + if (memcmp(dst0_u, dst1_u, w * 2) || memcmp(dst0_v, dst1_v, w * 2)) + fail(); + + bench_new(dst1_u, dst1_v, NULL, src, src, w, rgb2yuv, NULL); + } + } + } + + sws_freeContext(ctx); +} + static void check_interleave_bytes(void) { LOCAL_ALIGNED_16(uint8_t, src0_buf, [MAX_STRIDE*MAX_HEIGHT+1]); @@ -201,6 +318,12 @@ void checkasm_check_sw_rgb(void) check_uyvy_to_422p(); report("uyvytoyuv422"); + check_rgb_to_y(); + report("rgb_to_y"); + + check_rgb_to_uv(); + report("rgb_to_uv"); + check_interleave_bytes(); report("interleave_bytes"); } -- 2.42.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".