From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 37B1E42181 for ; Tue, 29 Mar 2022 05:02:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8FF8968B178; Tue, 29 Mar 2022 08:02:49 +0300 (EEST) Received: from out162-62-57-64.mail.qq.com (out162-62-57-64.mail.qq.com [162.62.57.64]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 02F4768B008 for ; Tue, 29 Mar 2022 08:02:42 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1648530160; bh=Dsv90Yj3gZyTPt1NmM6cxeWuRa25DLFuY3DzlGeai0Q=; h=From:Subject:Date:References:To:In-Reply-To; b=T+JrBl8TP0LOqUK5nUzLJzFVhxKXcvNAZ/stAinZAVvzNUeaakFY7oMSHv8DTLPj7 FR9uto9nqp9w8t1yPJwBCWiCXLiQAfcjpe4ihUb45R8pyqe0vt/t7CHH66JlnX9cH3 y/l0b4PsLPwWV4DOskNsMFJhsCsgWWIrSSG1qJwA= Received: from [192.168.255.10] ([113.108.77.72]) by newxmesmtplogicsvrszc8.qq.com (NewEsmtp) with SMTP id A736A3B; Tue, 29 Mar 2022 13:02:39 +0800 X-QQ-mid: xmsmtpt1648530159t63fhfhkp Message-ID: X-QQ-XMAILINFO: NiDupExshEc7dEB0o1mN2P7hM5wp01FRD7Bpf8MNNcuT8h8rcsfZxZl0+/c+Ka PdiGJky72HA0uY4wymmAcRD01tctfEjnwOQfwl2+fMnZsSPW0qJGGA3mNpOEJTU03xj/8kkwcZh5 CzwVOiY8qQSjNmZf2a9tV2QtS79SPqj3yv5ZwTidF76dbydKpXgdCuX0JJsFu8D+C4F4yUx+6hUQ KJKFcAT+B/iW1npOvuxURjke93AiAMseC3UefX09900l1er/wbh2R+1i90RhNJ9h1cvIQ/gn3Dwu wAXkAvywW2KA8i2KxBX+C9PI1hLcXHiGnyZdXa4uVREE5XrxK/aN+oHecNPWm2uOShHSMKJnJmTQ CnFnooBD+Ki0Z2L34mXYRVPDbvqePDo5M0Tca0SMyv+jjNJbYp3AhkR8S6QmQOP3/O+Kl4yv1ZMA 56PNM9EN4WQI+QS8yX3tp5POg2tWkw+BKzr3J0XQXUtd64Wdhk3BtJGNw/3Jr5MHYgHUx/7R+nBs gHAbJwVBLHq/E3jAZbuZ7f/fHliQzSNK63aE3eqkG2IWaYFY7lcqfYUaXyHsIy/y3mmYtMtbh32L Xa93UDLQxIDwZjvrHL1VW1Fwd/Y+zO7TFWagkGrgQ3kA6viEQojDxYOH0LKWlmbl6pzVUJBACKOc cr0WqRTdKBRKxRyjPoY9/epCRgxrgPNRBwJbpNjchbUR8k2RTO8q2BvAZeslPUqvYK7/fouPeyC+ RE4BX8VtuT6WhIr/3+QOga7RzPpwFJG7vVLXbr3QN5c0ccHOppHr3Wo6VogBF1P3gZUyp+r9MfsT abNtSwRZwJ5ie8gt5Su57dSKpanbpTvsEZZs2vOf+SizFOICBJQMsHZBrMYPaVY9C8wHX88FyUzG lOaehuA8u4SX1Vlk3LwVvUMrY8QtycBQ3qyDhWORNUGH3D+MoTsW5TaicXR0RkdUzqW6cPuG5rky VyJ/S9AwbuoXoZ3skTnA== From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Tue, 29 Mar 2022 13:02:42 +0800 References: To: FFmpeg development discussions and patches In-Reply-To: X-OQ-MSGID: <6E5F2760-6D27-4B57-8C0B-5C3B9F3A73AA@foxmail.com> X-Mailer: Apple Mail (2.3654.60.0.2.21) Subject: Re: [FFmpeg-devel] [PATCH 1/5] avformat/movenc: remove unused argument from get_sample_flags() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Ping for patch 1-3. > On Dec 3, 2021, at 1:06 PM, Zhao Zhili wrote: > > --- > libavformat/movenc.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index 38ff90833a..634a829f28 100644 > --- a/libavformat/movenc.c > +++ b/libavformat/movenc.c > @@ -4427,7 +4427,7 @@ static int mov_write_mfhd_tag(AVIOContext *pb, MOVMuxContext *mov) > return 0; > } > > -static uint32_t get_sample_flags(MOVTrack *track, MOVIentry *entry) > +static uint32_t get_sample_flags(MOVIentry *entry) > { > return entry->flags & MOV_SYNC_SAMPLE ? MOV_FRAG_SAMPLE_FLAG_DEPENDS_NO : > (MOV_FRAG_SAMPLE_FLAG_DEPENDS_YES | MOV_FRAG_SAMPLE_FLAG_IS_NON_SYNC); > @@ -4487,7 +4487,7 @@ static int mov_write_tfhd_tag(AVIOContext *pb, MOVMuxContext *mov, > /* Set the default flags based on the second sample, if available. > * If the first sample is different, that can be signaled via a separate field. */ > if (track->entry > 1) > - track->default_sample_flags = get_sample_flags(track, &track->cluster[1]); > + track->default_sample_flags = get_sample_flags(&track->cluster[1]); > else > track->default_sample_flags = > track->par->codec_type == AVMEDIA_TYPE_VIDEO ? > @@ -4512,11 +4512,11 @@ static int mov_write_trun_tag(AVIOContext *pb, MOVMuxContext *mov, > flags |= MOV_TRUN_SAMPLE_DURATION; > if (track->cluster[i].size != track->default_size) > flags |= MOV_TRUN_SAMPLE_SIZE; > - if (i > first && get_sample_flags(track, &track->cluster[i]) != track->default_sample_flags) > + if (i > first && get_sample_flags(&track->cluster[i]) != track->default_sample_flags) > flags |= MOV_TRUN_SAMPLE_FLAGS; > } > if (!(flags & MOV_TRUN_SAMPLE_FLAGS) && track->entry > 0 && > - get_sample_flags(track, &track->cluster[0]) != track->default_sample_flags) > + get_sample_flags(&track->cluster[0]) != track->default_sample_flags) > flags |= MOV_TRUN_FIRST_SAMPLE_FLAGS; > if (track->flags & MOV_TRACK_CTTS) > flags |= MOV_TRUN_SAMPLE_CTS; > @@ -4538,7 +4538,7 @@ static int mov_write_trun_tag(AVIOContext *pb, MOVMuxContext *mov, > avio_wb32(pb, moof_size + 8 + track->data_offset + > track->cluster[first].pos); /* data offset */ > if (flags & MOV_TRUN_FIRST_SAMPLE_FLAGS) > - avio_wb32(pb, get_sample_flags(track, &track->cluster[first])); > + avio_wb32(pb, get_sample_flags(&track->cluster[first])); > > for (i = first; i < end; i++) { > if (flags & MOV_TRUN_SAMPLE_DURATION) > @@ -4546,7 +4546,7 @@ static int mov_write_trun_tag(AVIOContext *pb, MOVMuxContext *mov, > if (flags & MOV_TRUN_SAMPLE_SIZE) > avio_wb32(pb, track->cluster[i].size); > if (flags & MOV_TRUN_SAMPLE_FLAGS) > - avio_wb32(pb, get_sample_flags(track, &track->cluster[i])); > + avio_wb32(pb, get_sample_flags(&track->cluster[i])); > if (flags & MOV_TRUN_SAMPLE_CTS) > avio_wb32(pb, track->cluster[i].cts); > } > -- > 2.31.1 > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".