From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id B69674C3F8 for ; Sun, 9 Mar 2025 03:41:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DEA3168E6FE; Sun, 9 Mar 2025 05:41:47 +0200 (EET) Received: from out203-205-221-192.mail.qq.com (out203-205-221-192.mail.qq.com [203.205.221.192]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3841F68022E for ; Sun, 9 Mar 2025 05:41:39 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1741491695; bh=7ITeR6Y/M7vzImZTrN66W3y3lpPh0Ox0H707ZI8QYLs=; h=From:Subject:Date:References:To:In-Reply-To; b=tBJewtlLuvqDrO1J3ketSJbttVEzbOtVfadHBc3JUveP+EW38aAmRZJ1maQTnxdGL huMFXJdyRx2LAdIsklf6DSnD6pAIS58sJwxiQ+MDg9SkAM9MrY/qu+2L8O1pIjyU+X CiVG9AABIsYlrb0TKRnXYvQZX0ILcZQ0WQvOhhgc= Received: from smtpclient.apple ([240e:3b7:3277:36f0:916b:565e:b042:a395]) by newxmesmtplogicsvrszc16-0.qq.com (NewEsmtp) with SMTP id A62A22C8; Sun, 09 Mar 2025 11:41:34 +0800 X-QQ-mid: xmsmtpt1741491694tgne8ew5c Message-ID: X-QQ-XMAILINFO: OSiyqyQsnID8CIlQbwPVIdXE4jKLf5LkAB1yXBHPPlBfiDab5BKfaEQ9Z5gxlb QoYWu6/eijdWL7UdG8FODn5cnwYxZwUlZFLzzKGLNVmu1zew3+A0WjzxAv0U6gfpj5fQD6fw7ArV jhyJM5AP/jqn4Nzb7IKn8U5vZUplcSgZMMoWtmaP5x/drNwuJs8/FQ16VIzqgc4M49TYwevMsYJh yKONhzPpMyQMytJoFPYhSj3SddtTdBX2BbxJnzLK1OKFeMeBg0ABBLNkeVzT/4mCMBCfDyjv+nxD aM5SQKFKiUmLiKJVHCO0F6/uWcElY7szTYH0GImZ56X0ED6dkbKBTfPRJTkEEiGM/Jo60OYeacBn 4pGoCfzjf1PurT/HIIyoAnhCdtVStZTfGEzF7SlkkRMgMas1eA0wTD1ONfwfBvYx/jijYPgls/eJ NOzZg6XQkSNF1VZxI+7fLtklDL9rxZm+0GSJCQzFowj6XPrzo3KjqG+3kocDIAOePLrCWzkEbTee 3tBR76YmvysU5mMEoCCYrxxphi8LQDX20LsQJBXoea+GoKDeEKubkKBzI62XF8UjMs2KwFS/xrju k8akUbG+D24j7zc03rjJasibyXICTaPZFzHOPqG+BvMdVjgIa0DB9ypZLJZRiWntlYe+JbpP08oh cD8RiLLv1SAKz7BwPbOpIYkdzzXGthDVKeyt8Qmn06uP1e63OWEtMtc8AJO5qMLJbMl22Js7w6Bp iYZ81D0ogcM5qmCrhAB+m8EFUP1zFCyFLgPB6l8KIR6j8OhJl8EgXcSDRS+nOpjOhwUEQSk8oyTD ibQIYg4+D/d4+/Knyh+OlS9ySdr1906noYi7mHsiLnCp8aCcxY/BgdaJNsNt7XxYwNQG9HDZx9nL DnkC66NPps+1NGWI2zufg6fZYTXQWnDw6xBfzd14zZVwiu0qlA/QXU7ixBSgLvow/Y6KywD/7JXt zd2y/rzEM8ZdMpnsbjqZ0BpPbWaWxpl60TB5LtmFUgzOM6DNHoCQ5hk2P6CjCpe+G17sKLt86nsw sIZK2N6JV/CbJZT/fV X-QQ-XMRINFO: MSVp+SPm3vtS1Vd6Y4Mggwc= From: Zhao Zhili Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\)) Date: Sun, 9 Mar 2025 11:41:21 +0800 References: To: FFmpeg development discussions and patches In-Reply-To: X-OQ-MSGID: <5A794C61-2CC9-4438-8086-0A74F3CA8CDF@foxmail.com> X-Mailer: Apple Mail (2.3818.100.11.1.3) X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/decode: Fix avcodec parameters when bsfs are enable by decoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Mar 9, 2025, at 11:06, Andreas Rheinhardt wrote: > > Zhao Zhili: >> From: Zhao Zhili >> >> BSF can update extradata, e.g., vvc_mp4toannexb. If we don't copy >> bsf->par_out back to avcodec context, decoder can get extradata in >> mp4 format, while packets are in annexb format. >> --- >> libavcodec/decode.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/libavcodec/decode.c b/libavcodec/decode.c >> index c5a577f4f1..95b8c32502 100644 >> --- a/libavcodec/decode.c >> +++ b/libavcodec/decode.c >> @@ -206,6 +206,9 @@ static int decode_bsfs_init(AVCodecContext *avctx) >> goto fail; >> >> ret = av_bsf_init(avci->bsf); >> + if (ret < 0) >> + goto fail; >> + ret = avcodec_parameters_to_context(avctx, avci->bsf->par_out); >> if (ret < 0) >> goto fail; >> > > FYI: The same change has been done in f631c328e680 (and 662558f985f508 > in libav) and later reverted in 87588caf8cff (and cacb62f9cbf3). The > reason was that extradata was owned by the user for decoders. This has > only been changed very recently in 183c59b4738c last December, but this > was an API change (without any entry in APIchanges) and I would not be > surprised if your change would break some users. Does not mean I block > your patch, though. Thanks for the information. avcodec_close() will be removed soon, that will break those users too. This patch can be applied after avcodec_close be removed. > > An alternative approach is that we add a getter for extradata that the > decoders that use a bsf known for changing extradata use to access > extradata. > > - Andreas > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".