[FFmpeg-devel] [PATCH] fftools/ffplay_renderer: declare function argument as const

[FFmpeg-devel] [PATCH] fftools/ffplay_renderer: declare function argument as const

[Leo Izen]

Declaring the function argument as const fixes a warning down the line
that the const parameter is stripped. We don't modify this argument.

Signed-off-by: Leo Izen <leo.izen@gmail.com>
---
 fftools/ffplay_renderer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fftools/ffplay_renderer.c b/fftools/ffplay_renderer.c
index a57e4980eb..45ca84fa95 100644
--- a/fftools/ffplay_renderer.c
+++ b/fftools/ffplay_renderer.c
@@ -133,7 +133,7 @@ static const char *optional_device_exts[] = {
     "VK_MESA_video_decode_av1",
 };
 
-static inline int enable_debug(AVDictionary *opt)
+static inline int enable_debug(const AVDictionary *opt)
 {
     AVDictionaryEntry *entry = av_dict_get(opt, "debug", NULL, 0);
     int debug = entry && strtol(entry->value, NULL, 10);
-- 
2.42.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] fftools/ffplay_renderer: declare function argument as const

[Zhao Zhili]

> 在 2023年11月23日，下午10:38，Leo Izen <leo.izen@gmail.com> 写道：
> 
> Declaring the function argument as const fixes a warning down the line
> that the const parameter is stripped. We don't modify this argument.
> 
> Signed-off-by: Leo Izen <leo.izen@gmail.com>
> ---
> fftools/ffplay_renderer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fftools/ffplay_renderer.c b/fftools/ffplay_renderer.c
> index a57e4980eb..45ca84fa95 100644
> --- a/fftools/ffplay_renderer.c
> +++ b/fftools/ffplay_renderer.c
> @@ -133,7 +133,7 @@ static const char *optional_device_exts[] = {
>     "VK_MESA_video_decode_av1",
> };
> 
> -static inline int enable_debug(AVDictionary *opt)
> +static inline int enable_debug(const AVDictionary *opt)
> {
>     AVDictionaryEntry *entry = av_dict_get(opt, "debug", NULL, 0);
>     int debug = entry && strtol(entry->value, NULL, 10);
> --
> 2.42.1

Applied, thanks!

> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".