From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F107243E34 for ; Wed, 17 Aug 2022 02:29:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5BFA368B913; Wed, 17 Aug 2022 05:29:43 +0300 (EEST) Received: from out203-205-221-221.mail.qq.com (out203-205-221-221.mail.qq.com [203.205.221.221]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DD78468B6F2 for ; Wed, 17 Aug 2022 05:29:35 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1660703371; bh=uONEjaXienD2URMTYP4vHCWsleL+eqCCxQ3kMvfpJT0=; h=Subject:From:To:Date:In-Reply-To:References; b=HoU7ZSaymeRojjb3UV4Z40t8bufdonHK5oUqPG9+DcsUq91ARNqpRkr3Rv5L4SVY7 SgfLZQlKBU+5kp6blLfnYf+t6DSF4khmbY3vvpp6jBqsCFDcU9l0/kjeN0mxpewC9K LHi/g7O/6vhJBdOjEd+KnTwjM6WjYsrrdnlYN0gQ= Received: from zhilizhao-LC3 ([59.37.125.102]) by newxmesmtplogicsvrsza31.qq.com (NewEsmtp) with SMTP id 75E848A9; Wed, 17 Aug 2022 10:29:30 +0800 X-QQ-mid: xmsmtpt1660703370tbpdyv7ac Message-ID: X-QQ-XMAILINFO: Mm/8i8/T4yneBRvj9ZrLQTzZ3I1rKi7C0L+yRfgL6QGucaFDa+QDE3LSZudU2Y TijSg8iohVZnnhJLmr5u73WT/GKT34eZX6ZekL8kGaU4t8y/0BhJfJOnCeqAHzsfWyvVjtID4kxY T0CoCpahg/2S+xRMAObzD95yzcPgF1vcQBlTK1QfyzcM+Ia3EgScIBidJRgya8kzQNL9D4tMkLpa UjX+TQ6f7l+la7Pwpu3OX38y+j1/0EiF9rOkdyaryeFAo/V9SAN6W22iDuhqgBw3OOTNr8i/YSJB UdsqLtTQrN1Qd0Wrz7ORabZn6abyMxuuwmbX3/imwow6TDXFo+k9osDkPMzfNQ79qMysZT9RhODR Ve8LyOJx6GdO0b91eK+YDXCy6c8/8z+w8d/DwsEKoTdjtsXgRjal3a9ajOBcHnXcEu4bHtdvuzB3 vS7wBvf1cCeOIWYfFwmLLqOYxItTlK6Tu8DRoinyCHeNIORgnKC+1FW7Txt8ktbjuoto2xlKHPNp hC8kSkodOXoiTYLASkq1vVhlm1Cotk2kEjP4I4YgcbI/W+f7JDePnIYBIcioYfOMFrc3ekbt3iQ8 4ITKTbC+EzZbUwFFwcR0Z/RkjfKgtEb4RLvSncVkvSDn9824GUbvy8mUtgDsfKiCNFenWuk2PdSp gT976aRUZM37BP81iDt8DEKG8BbVdwKLDhLXyyrpPhjwhatA9KPArdLTTOSL2v4pkqy0f+IrQZfA 8Z3K+oNqE+PpMAJdSG19CeFCqMnH/uN/QcMRDwdC6sngaOcDtAiFiDbqFmEc4LlYIwIovaQrHiGz xOqlfqBNJTZQcgcvJR5oxXL9Yl3JwTsxGZOtJRV1i6LdXpkCoHfUk0WLyMokGSZ0lQgZVSPTGrZC P+xK4z/x0k4cmRcrLdTUjFx3ZczjRjbOl0qXI4rE0MdiGyUZDaGptBoGEJ3CErlChYSIwf6SeTIa jWiFj7RkU= X-OQ-MSGID: From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Wed, 17 Aug 2022 18:29:30 +0800 In-Reply-To: References: <20220816144850.196109-1-derek.buitenhuis@gmail.com> User-Agent: Evolution 3.36.5-0ubuntu1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v3] mov: Compare frag times in correct time base when seeking a stream without a corresponding sidx X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 2022-08-16 at 17:32 +0100, Derek Buitenhuis wrote: > On 8/16/2022 5:21 PM, Zhao Zhili wrote: > > get_frag_time() can be called with an mp4 file which has no sidx at > > all. In that case, > > dst_st should have a higher priority than other streams, even if > > sc->has_sidx is false. > > And first_tfra_pts might be used here, which makes the check of sc- > > >has_sidx unnatural. > > So in my opinion, the check on sc->has_sidx should be removed. > > This seems like it should be in a separate patch, though - it is > changing a different > behavior than what this patch does. OK. > > > + frag_stream_info = get_frag_stream_info(frag_index, index, > > dst_st->id); > > + timestamp = get_stream_info_time(frag_stream_info); > > + if (timestamp != AV_NOPTS_VALUE) > > + return timestamp; > > I did look at that, but I do not think it can be. > > get_stream_info_time is not equivalent to what is here. > get_stream_info_time will > eventually fall back to frag_stream_info->tfdt_dts, where as this > code falls back > to frag_stream_info->sidx_pts even if it is AV_NOPTS_VALUE. It would > be a behavior > change do use get_stream_info_time here. OK, it make sense together with `if (sc->has_sidx)`. No more comments from me. > > - Derek > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".