* [FFmpeg-devel] [PATCH v2] avformat/tls_openssl: fix warnings when openssl is lower version
@ 2025-06-08 0:25 Jack Lau via ffmpeg-devel
2025-06-13 5:06 ` Jack Lau
2025-06-15 3:38 ` Andreas Rheinhardt
0 siblings, 2 replies; 5+ messages in thread
From: Jack Lau via ffmpeg-devel @ 2025-06-08 0:25 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Jack Lau
api doc: https://docs.openssl.org/1.0.2/man3/BIO_s_mem
In higher versions (openssl 1.0.2 and higher),
the function signature is BIO *BIO_new_mem_buf(const void *buf, int len),
so passing a const string doesn't cause an warnings.
However, in lower versions of OpenSSL,
the function signature becomes BIO *BIO_new_mem_buf(void *buf, int len),
which leads to warnings.
OpenSSL guarantees that it will not modify the string,
so it's safe to cast the pem_str to (void *) to avoid this warning.
Signed-off-by: Jack Lau <jacklau1222@qq.com>
---
libavformat/tls_openssl.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 86e8935fee..0a6e5680f4 100644
--- a/libavformat/tls_openssl.c
+++ b/libavformat/tls_openssl.c
@@ -415,7 +415,12 @@ error:
*/
static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
{
- BIO *mem = BIO_new_mem_buf(pem_str, -1);
+ BIO *mem = NULL;
+#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
+ mem = BIO_new_mem_buf((void *)pem_str, -1);
+#else
+ mem = BIO_new_mem_buf(pem_str, -1);
+#endif
if (!mem) {
av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
return NULL;
@@ -445,7 +450,12 @@ static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
*/
static X509 *cert_from_pem_string(const char *pem_str)
{
- BIO *mem = BIO_new_mem_buf(pem_str, -1);
+ BIO *mem = NULL;
+#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
+ mem = BIO_new_mem_buf((void *)pem_str, -1);
+#else
+ mem = BIO_new_mem_buf(pem_str, -1);
+#endif
if (!mem) {
av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
return NULL;
--
2.49.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2] avformat/tls_openssl: fix warnings when openssl is lower version
2025-06-08 0:25 [FFmpeg-devel] [PATCH v2] avformat/tls_openssl: fix warnings when openssl is lower version Jack Lau via ffmpeg-devel
@ 2025-06-13 5:06 ` Jack Lau
2025-06-13 8:23 ` Steven Liu
2025-06-15 3:38 ` Andreas Rheinhardt
1 sibling, 1 reply; 5+ messages in thread
From: Jack Lau @ 2025-06-13 5:06 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On Jun 8, 2025, at 08:25, Jack Lau via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
>
> api doc: https://docs.openssl.org/1.0.2/man3/BIO_s_mem
>
> In higher versions (openssl 1.0.2 and higher),
> the function signature is BIO *BIO_new_mem_buf(const void *buf, int len),
> so passing a const string doesn't cause an warnings.
> However, in lower versions of OpenSSL,
> the function signature becomes BIO *BIO_new_mem_buf(void *buf, int len),
> which leads to warnings.
>
> OpenSSL guarantees that it will not modify the string,
> so it's safe to cast the pem_str to (void *) to avoid this warning.
>
> Signed-off-by: Jack Lau <jacklau1222@qq.com>
> ---
> libavformat/tls_openssl.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
> index 86e8935fee..0a6e5680f4 100644
> --- a/libavformat/tls_openssl.c
> +++ b/libavformat/tls_openssl.c
> @@ -415,7 +415,12 @@ error:
> */
> static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
> {
> - BIO *mem = BIO_new_mem_buf(pem_str, -1);
> + BIO *mem = NULL;
> +#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
> + mem = BIO_new_mem_buf((void *)pem_str, -1);
> +#else
> + mem = BIO_new_mem_buf(pem_str, -1);
> +#endif
> if (!mem) {
> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
> return NULL;
> @@ -445,7 +450,12 @@ static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
> */
> static X509 *cert_from_pem_string(const char *pem_str)
> {
> - BIO *mem = BIO_new_mem_buf(pem_str, -1);
> + BIO *mem = NULL;
> +#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
> + mem = BIO_new_mem_buf((void *)pem_str, -1);
> +#else
> + mem = BIO_new_mem_buf(pem_str, -1);
> +#endif
> if (!mem) {
> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
> return NULL;
> --
> 2.49.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe”.
PING.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2] avformat/tls_openssl: fix warnings when openssl is lower version
2025-06-13 5:06 ` Jack Lau
@ 2025-06-13 8:23 ` Steven Liu
0 siblings, 0 replies; 5+ messages in thread
From: Steven Liu @ 2025-06-13 8:23 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Jack Lau <jacklau1222gm-at-gmail.com@ffmpeg.org> 于2025年6月13日周五 13:07写道：
>
>
>
> > On Jun 8, 2025, at 08:25, Jack Lau via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
> >
> > api doc: https://docs.openssl.org/1.0.2/man3/BIO_s_mem
> >
> > In higher versions (openssl 1.0.2 and higher),
> > the function signature is BIO *BIO_new_mem_buf(const void *buf, int len),
> > so passing a const string doesn't cause an warnings.
> > However, in lower versions of OpenSSL,
> > the function signature becomes BIO *BIO_new_mem_buf(void *buf, int len),
> > which leads to warnings.
> >
> > OpenSSL guarantees that it will not modify the string,
> > so it's safe to cast the pem_str to (void *) to avoid this warning.
> >
> > Signed-off-by: Jack Lau <jacklau1222@qq.com>
> > ---
> > libavformat/tls_openssl.c | 14 ++++++++++++--
> > 1 file changed, 12 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
> > index 86e8935fee..0a6e5680f4 100644
> > --- a/libavformat/tls_openssl.c
> > +++ b/libavformat/tls_openssl.c
> > @@ -415,7 +415,12 @@ error:
> > */
> > static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
> > {
> > - BIO *mem = BIO_new_mem_buf(pem_str, -1);
> > + BIO *mem = NULL;
> > +#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
> > + mem = BIO_new_mem_buf((void *)pem_str, -1);
> > +#else
> > + mem = BIO_new_mem_buf(pem_str, -1);
> > +#endif
> > if (!mem) {
> > av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
> > return NULL;
> > @@ -445,7 +450,12 @@ static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
> > */
> > static X509 *cert_from_pem_string(const char *pem_str)
> > {
> > - BIO *mem = BIO_new_mem_buf(pem_str, -1);
> > + BIO *mem = NULL;
> > +#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
> > + mem = BIO_new_mem_buf((void *)pem_str, -1);
> > +#else
> > + mem = BIO_new_mem_buf(pem_str, -1);
> > +#endif
> > if (!mem) {
> > av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
> > return NULL;
> > --
> > 2.49.0
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe”.
> PING.
This modified by Andreas suggestion, lgtm
>
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2] avformat/tls_openssl: fix warnings when openssl is lower version
2025-06-08 0:25 [FFmpeg-devel] [PATCH v2] avformat/tls_openssl: fix warnings when openssl is lower version Jack Lau via ffmpeg-devel
2025-06-13 5:06 ` Jack Lau
@ 2025-06-15 3:38 ` Andreas Rheinhardt
2025-06-15 15:18 ` Jack Lau
1 sibling, 1 reply; 5+ messages in thread
From: Andreas Rheinhardt @ 2025-06-15 3:38 UTC (permalink / raw)
To: ffmpeg-devel
Jack Lau via ffmpeg-devel:
> api doc: https://docs.openssl.org/1.0.2/man3/BIO_s_mem
>
> In higher versions (openssl 1.0.2 and higher),
> the function signature is BIO *BIO_new_mem_buf(const void *buf, int len),
> so passing a const string doesn't cause an warnings.
> However, in lower versions of OpenSSL,
> the function signature becomes BIO *BIO_new_mem_buf(void *buf, int len),
> which leads to warnings.
>
> OpenSSL guarantees that it will not modify the string,
> so it's safe to cast the pem_str to (void *) to avoid this warning.
>
> Signed-off-by: Jack Lau <jacklau1222@qq.com>
> ---
> libavformat/tls_openssl.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
> index 86e8935fee..0a6e5680f4 100644
> --- a/libavformat/tls_openssl.c
> +++ b/libavformat/tls_openssl.c
> @@ -415,7 +415,12 @@ error:
> */
> static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
> {
> - BIO *mem = BIO_new_mem_buf(pem_str, -1);
> + BIO *mem = NULL;
> +#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
> + mem = BIO_new_mem_buf((void *)pem_str, -1);
> +#else
> + mem = BIO_new_mem_buf(pem_str, -1);
> +#endif
> if (!mem) {
> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
> return NULL;
> @@ -445,7 +450,12 @@ static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
> */
> static X509 *cert_from_pem_string(const char *pem_str)
> {
> - BIO *mem = BIO_new_mem_buf(pem_str, -1);
> + BIO *mem = NULL;
> +#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
> + mem = BIO_new_mem_buf((void *)pem_str, -1);
> +#else
> + mem = BIO_new_mem_buf(pem_str, -1);
> +#endif
#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
#else
BIO *mem = BIO_new_mem_buf(pem_str, -1);
#endif
would have the advantage that it avoids the useless initialization and
that the old code can be cleanly removed when we drop support for old
versions of openssl. Same for above.
> if (!mem) {
> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
> return NULL;
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2] avformat/tls_openssl: fix warnings when openssl is lower version
2025-06-15 3:38 ` Andreas Rheinhardt
@ 2025-06-15 15:18 ` Jack Lau
0 siblings, 0 replies; 5+ messages in thread
From: Jack Lau @ 2025-06-15 15:18 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Andreas Rheinhardt
> On Jun 15, 2025, at 11:38, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote:
>
> Jack Lau via ffmpeg-devel:
>> api doc: https://docs.openssl.org/1.0.2/man3/BIO_s_mem
>>
>> In higher versions (openssl 1.0.2 and higher),
>> the function signature is BIO *BIO_new_mem_buf(const void *buf, int len),
>> so passing a const string doesn't cause an warnings.
>> However, in lower versions of OpenSSL,
>> the function signature becomes BIO *BIO_new_mem_buf(void *buf, int len),
>> which leads to warnings.
>>
>> OpenSSL guarantees that it will not modify the string,
>> so it's safe to cast the pem_str to (void *) to avoid this warning.
>>
>> Signed-off-by: Jack Lau <jacklau1222@qq.com>
>> ---
>> libavformat/tls_openssl.c | 14 ++++++++++++--
>> 1 file changed, 12 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
>> index 86e8935fee..0a6e5680f4 100644
>> --- a/libavformat/tls_openssl.c
>> +++ b/libavformat/tls_openssl.c
>> @@ -415,7 +415,12 @@ error:
>> */
>> static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
>> {
>> - BIO *mem = BIO_new_mem_buf(pem_str, -1);
>> + BIO *mem = NULL;
>> +#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
>> + mem = BIO_new_mem_buf((void *)pem_str, -1);
>> +#else
>> + mem = BIO_new_mem_buf(pem_str, -1);
>> +#endif
>> if (!mem) {
>> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
>> return NULL;
>> @@ -445,7 +450,12 @@ static EVP_PKEY *pkey_from_pem_string(const char *pem_str, int is_priv)
>> */
>> static X509 *cert_from_pem_string(const char *pem_str)
>> {
>> - BIO *mem = BIO_new_mem_buf(pem_str, -1);
>> + BIO *mem = NULL;
>> +#if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
>> + mem = BIO_new_mem_buf((void *)pem_str, -1);
>> +#else
>> + mem = BIO_new_mem_buf(pem_str, -1);
>> +#endif
>
> #if OPENSSL_VERSION_NUMBER < 0x10002000L /* OpenSSL 1.0.2 */
> BIO *mem = BIO_new_mem_buf((void *)pem_str, -1);
> #else
> BIO *mem = BIO_new_mem_buf(pem_str, -1);
> #endif
>
> would have the advantage that it avoids the useless initialization and
> that the old code can be cleanly removed when we drop support for old
> versions of openssl. Same for above.
Thanks for your reply, I’ve sent the latest v3 patch refer to your reviews.
>
>> if (!mem) {
>> av_log(NULL, AV_LOG_ERROR, "BIO_new_mem_buf failed\n");
>> return NULL;
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org <mailto:ffmpeg-devel-request@ffmpeg.org> with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-06-15 15:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-08 0:25 [FFmpeg-devel] [PATCH v2] avformat/tls_openssl: fix warnings when openssl is lower version Jack Lau via ffmpeg-devel
2025-06-13 5:06 ` Jack Lau
2025-06-13 8:23 ` Steven Liu
2025-06-15 3:38 ` Andreas Rheinhardt
2025-06-15 15:18 ` Jack Lau
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git