* [FFmpeg-devel] [PATCH 3/3] tests: Add fate-hevc-color-reserved
[not found] <20250521130546.4003-1-quinkblack@foxmail.com>
@ 2025-05-21 13:06 ` Zhao Zhili
2025-05-21 13:11 ` Andreas Rheinhardt
0 siblings, 1 reply; 8+ messages in thread
From: Zhao Zhili @ 2025-05-21 13:06 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Zhao Zhili
From: Zhao Zhili <zhilizhao@tencent.com>
---
tests/fate/hevc.mak | 3 +++
tests/ref/fate/hevc-color-reserved | 6 ++++++
2 files changed, 9 insertions(+)
create mode 100644 tests/ref/fate/hevc-color-reserved
diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak
index 390ccf46e2..5e721526d0 100644
--- a/tests/fate/hevc.mak
+++ b/tests/fate/hevc.mak
@@ -294,6 +294,9 @@ FATE_HEVC-$(call FRAMECRC, MOV, HEVC) += fate-hevc-mv-position
fate-hevc-alpha: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/alpha.mp4
FATE_HEVC-$(call FRAMECRC, MOV, HEVC) += fate-hevc-alpha
+fate-hevc-color-reserved: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/color_prim_reserved0.hevc -fps_mode passthrough -sws_flags +accurate_rnd+bitexact -vf scale,format=nv12
+FATE_HEVC-$(call FRAMECRC, HEVC, HEVC, SCALE_FILTER) += fate-hevc-color-reserved
+
FATE_SAMPLES_AVCONV += $(FATE_HEVC-yes)
FATE_SAMPLES_FFPROBE += $(FATE_HEVC_FFPROBE-yes)
diff --git a/tests/ref/fate/hevc-color-reserved b/tests/ref/fate/hevc-color-reserved
new file mode 100644
index 0000000000..3351628209
--- /dev/null
+++ b/tests/ref/fate/hevc-color-reserved
@@ -0,0 +1,6 @@
+#tb 0: 1/60
+#media_type 0: video
+#codec_id 0: rawvideo
+#dimensions 0: 1920x900
+#sar 0: 1/1
+0, 0, 0, 1, 2592000, 0xfa6fce1e
--
2.46.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [FFmpeg-devel] [PATCH 3/3] tests: Add fate-hevc-color-reserved
2025-05-21 13:06 ` [FFmpeg-devel] [PATCH 3/3] tests: Add fate-hevc-color-reserved Zhao Zhili
@ 2025-05-21 13:11 ` Andreas Rheinhardt
2025-05-21 13:26 ` [FFmpeg-devel] [PATCH v2 " Zhao Zhili
2025-05-21 13:28 ` [FFmpeg-devel] [PATCH " Zhao Zhili
0 siblings, 2 replies; 8+ messages in thread
From: Andreas Rheinhardt @ 2025-05-21 13:11 UTC (permalink / raw)
To: ffmpeg-devel
Zhao Zhili:
> From: Zhao Zhili <zhilizhao@tencent.com>
>
> ---
> tests/fate/hevc.mak | 3 +++
> tests/ref/fate/hevc-color-reserved | 6 ++++++
> 2 files changed, 9 insertions(+)
> create mode 100644 tests/ref/fate/hevc-color-reserved
>
> diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak
> index 390ccf46e2..5e721526d0 100644
> --- a/tests/fate/hevc.mak
> +++ b/tests/fate/hevc.mak
> @@ -294,6 +294,9 @@ FATE_HEVC-$(call FRAMECRC, MOV, HEVC) += fate-hevc-mv-position
> fate-hevc-alpha: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/alpha.mp4
> FATE_HEVC-$(call FRAMECRC, MOV, HEVC) += fate-hevc-alpha
>
> +fate-hevc-color-reserved: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/color_prim_reserved0.hevc -fps_mode passthrough -sws_flags +accurate_rnd+bitexact -vf scale,format=nv12
> +FATE_HEVC-$(call FRAMECRC, HEVC, HEVC, SCALE_FILTER) += fate-hevc-color-reserved
A new sample for this? Why don't you just create one with hevc_metadata?
> +
> FATE_SAMPLES_AVCONV += $(FATE_HEVC-yes)
> FATE_SAMPLES_FFPROBE += $(FATE_HEVC_FFPROBE-yes)
>
> diff --git a/tests/ref/fate/hevc-color-reserved b/tests/ref/fate/hevc-color-reserved
> new file mode 100644
> index 0000000000..3351628209
> --- /dev/null
> +++ b/tests/ref/fate/hevc-color-reserved
> @@ -0,0 +1,6 @@
> +#tb 0: 1/60
> +#media_type 0: video
> +#codec_id 0: rawvideo
> +#dimensions 0: 1920x900
> +#sar 0: 1/1
> +0, 0, 0, 1, 2592000, 0xfa6fce1e
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 8+ messages in thread
* [FFmpeg-devel] [PATCH v2 3/3] tests: Add fate-hevc-color-reserved
2025-05-21 13:11 ` Andreas Rheinhardt
@ 2025-05-21 13:26 ` Zhao Zhili
2025-05-21 13:52 ` Andreas Rheinhardt
2025-05-21 13:28 ` [FFmpeg-devel] [PATCH " Zhao Zhili
1 sibling, 1 reply; 8+ messages in thread
From: Zhao Zhili @ 2025-05-21 13:26 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Zhao Zhili
From: Zhao Zhili <zhilizhao@tencent.com>
---
tests/fate/hevc.mak | 3 +++
tests/ref/fate/hevc-color-reserved | 6 ++++++
2 files changed, 9 insertions(+)
create mode 100644 tests/ref/fate/hevc-color-reserved
diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak
index 390ccf46e2..8113c04300 100644
--- a/tests/fate/hevc.mak
+++ b/tests/fate/hevc.mak
@@ -294,6 +294,9 @@ FATE_HEVC-$(call FRAMECRC, MOV, HEVC) += fate-hevc-mv-position
fate-hevc-alpha: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/alpha.mp4
FATE_HEVC-$(call FRAMECRC, MOV, HEVC) += fate-hevc-alpha
+fate-hevc-color-reserved: CMD = framecrc -bsf:v hevc_metadata=colour_primaries=0:transfer_characteristics=0:matrix_coefficients=3 -i $(TARGET_SAMPLES)/hevc-conformance/AMP_A_Samsung_4.bit -vf scale,format=nv12 -frames:v 1
+FATE_HEVC-$(call FRAMECRC, HEVC, HEVC, HEVC_METADATA_BSF SCALE_FILTER) += fate-hevc-color-reserved
+
FATE_SAMPLES_AVCONV += $(FATE_HEVC-yes)
FATE_SAMPLES_FFPROBE += $(FATE_HEVC_FFPROBE-yes)
diff --git a/tests/ref/fate/hevc-color-reserved b/tests/ref/fate/hevc-color-reserved
new file mode 100644
index 0000000000..cba6397aa8
--- /dev/null
+++ b/tests/ref/fate/hevc-color-reserved
@@ -0,0 +1,6 @@
+#tb 0: 1/25
+#media_type 0: video
+#codec_id 0: rawvideo
+#dimensions 0: 2560x1600
+#sar 0: 0/1
+0, 0, 0, 1, 6144000, 0x427b9a00
--
2.46.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [FFmpeg-devel] [PATCH 3/3] tests: Add fate-hevc-color-reserved
2025-05-21 13:11 ` Andreas Rheinhardt
2025-05-21 13:26 ` [FFmpeg-devel] [PATCH v2 " Zhao Zhili
@ 2025-05-21 13:28 ` Zhao Zhili
2025-05-21 13:37 ` Zhao Zhili
1 sibling, 1 reply; 8+ messages in thread
From: Zhao Zhili @ 2025-05-21 13:28 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On May 21, 2025, at 21:11, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote:
>
> Zhao Zhili:
>> From: Zhao Zhili <zhilizhao@tencent.com>
>>
>> ---
>> tests/fate/hevc.mak | 3 +++
>> tests/ref/fate/hevc-color-reserved | 6 ++++++
>> 2 files changed, 9 insertions(+)
>> create mode 100644 tests/ref/fate/hevc-color-reserved
>>
>> diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak
>> index 390ccf46e2..5e721526d0 100644
>> --- a/tests/fate/hevc.mak
>> +++ b/tests/fate/hevc.mak
>> @@ -294,6 +294,9 @@ FATE_HEVC-$(call FRAMECRC, MOV, HEVC) += fate-hevc-mv-position
>> fate-hevc-alpha: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/alpha.mp4
>> FATE_HEVC-$(call FRAMECRC, MOV, HEVC) += fate-hevc-alpha
>>
>> +fate-hevc-color-reserved: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/color_prim_reserved0.hevc -fps_mode passthrough -sws_flags +accurate_rnd+bitexact -vf scale,format=nv12
>> +FATE_HEVC-$(call FRAMECRC, HEVC, HEVC, SCALE_FILTER) += fate-hevc-color-reserved
>
> A new sample for this? Why don't you just create one with hevc_metadata?
Great idea. See patch v2 3/3.
https://ffmpeg.org/pipermail/ffmpeg-devel/2025-May/343884.html
>
>> +
>> FATE_SAMPLES_AVCONV += $(FATE_HEVC-yes)
>> FATE_SAMPLES_FFPROBE += $(FATE_HEVC_FFPROBE-yes)
>>
>> diff --git a/tests/ref/fate/hevc-color-reserved b/tests/ref/fate/hevc-color-reserved
>> new file mode 100644
>> index 0000000000..3351628209
>> --- /dev/null
>> +++ b/tests/ref/fate/hevc-color-reserved
>> @@ -0,0 +1,6 @@
>> +#tb 0: 1/60
>> +#media_type 0: video
>> +#codec_id 0: rawvideo
>> +#dimensions 0: 1920x900
>> +#sar 0: 1/1
>> +0, 0, 0, 1, 2592000, 0xfa6fce1e
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [FFmpeg-devel] [PATCH 3/3] tests: Add fate-hevc-color-reserved
2025-05-21 13:28 ` [FFmpeg-devel] [PATCH " Zhao Zhili
@ 2025-05-21 13:37 ` Zhao Zhili
2025-05-21 13:50 ` Andreas Rheinhardt
0 siblings, 1 reply; 8+ messages in thread
From: Zhao Zhili @ 2025-05-21 13:37 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On May 21, 2025, at 21:28, Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org> wrote:
>
>> On May 21, 2025, at 21:11, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote:
>>
>> Zhao Zhili:
>>> From: Zhao Zhili <zhilizhao@tencent.com>
>>>
>>> ---
>>> tests/fate/hevc.mak | 3 +++
>>> tests/ref/fate/hevc-color-reserved | 6 ++++++
>>> 2 files changed, 9 insertions(+)
>>> create mode 100644 tests/ref/fate/hevc-color-reserved
>>>
>>> diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak
>>> index 390ccf46e2..5e721526d0 100644
>>> --- a/tests/fate/hevc.mak
>>> +++ b/tests/fate/hevc.mak
>>> @@ -294,6 +294,9 @@ FATE_HEVC-$(call FRAMECRC, MOV, HEVC) += fate-hevc-mv-position
>>> fate-hevc-alpha: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/alpha.mp4
>>> FATE_HEVC-$(call FRAMECRC, MOV, HEVC) += fate-hevc-alpha
>>>
>>> +fate-hevc-color-reserved: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/color_prim_reserved0.hevc -fps_mode passthrough -sws_flags +accurate_rnd+bitexact -vf scale,format=nv12
>>> +FATE_HEVC-$(call FRAMECRC, HEVC, HEVC, SCALE_FILTER) += fate-hevc-color-reserved
>>
>> A new sample for this? Why don't you just create one with hevc_metadata?
On the other hand, we can create invalid sample with hevc_metadata for now.
Does it make sense to check primaries/trc/matrix in hevc_metadata?
>
> Great idea. See patch v2 3/3.
>
> https://ffmpeg.org/pipermail/ffmpeg-devel/2025-May/343884.html
>
>>
>>> +
>>> FATE_SAMPLES_AVCONV += $(FATE_HEVC-yes)
>>> FATE_SAMPLES_FFPROBE += $(FATE_HEVC_FFPROBE-yes)
>>>
>>> diff --git a/tests/ref/fate/hevc-color-reserved b/tests/ref/fate/hevc-color-reserved
>>> new file mode 100644
>>> index 0000000000..3351628209
>>> --- /dev/null
>>> +++ b/tests/ref/fate/hevc-color-reserved
>>> @@ -0,0 +1,6 @@
>>> +#tb 0: 1/60
>>> +#media_type 0: video
>>> +#codec_id 0: rawvideo
>>> +#dimensions 0: 1920x900
>>> +#sar 0: 1/1
>>> +0, 0, 0, 1, 2592000, 0xfa6fce1e
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [FFmpeg-devel] [PATCH 3/3] tests: Add fate-hevc-color-reserved
2025-05-21 13:37 ` Zhao Zhili
@ 2025-05-21 13:50 ` Andreas Rheinhardt
0 siblings, 0 replies; 8+ messages in thread
From: Andreas Rheinhardt @ 2025-05-21 13:50 UTC (permalink / raw)
To: ffmpeg-devel
Zhao Zhili:
>
>
>> On May 21, 2025, at 21:28, Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org> wrote:
>>
>>> On May 21, 2025, at 21:11, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote:
>>>
>>> Zhao Zhili:
>>>> From: Zhao Zhili <zhilizhao@tencent.com>
>>>>
>>>> ---
>>>> tests/fate/hevc.mak | 3 +++
>>>> tests/ref/fate/hevc-color-reserved | 6 ++++++
>>>> 2 files changed, 9 insertions(+)
>>>> create mode 100644 tests/ref/fate/hevc-color-reserved
>>>>
>>>> diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak
>>>> index 390ccf46e2..5e721526d0 100644
>>>> --- a/tests/fate/hevc.mak
>>>> +++ b/tests/fate/hevc.mak
>>>> @@ -294,6 +294,9 @@ FATE_HEVC-$(call FRAMECRC, MOV, HEVC) += fate-hevc-mv-position
>>>> fate-hevc-alpha: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/alpha.mp4
>>>> FATE_HEVC-$(call FRAMECRC, MOV, HEVC) += fate-hevc-alpha
>>>>
>>>> +fate-hevc-color-reserved: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/color_prim_reserved0.hevc -fps_mode passthrough -sws_flags +accurate_rnd+bitexact -vf scale,format=nv12
>>>> +FATE_HEVC-$(call FRAMECRC, HEVC, HEVC, SCALE_FILTER) += fate-hevc-color-reserved
>>>
>>> A new sample for this? Why don't you just create one with hevc_metadata?
>
> On the other hand, we can create invalid sample with hevc_metadata for now.
>
> Does it make sense to check primaries/trc/matrix in hevc_metadata?
>
IMO reserved != invalid
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2 3/3] tests: Add fate-hevc-color-reserved
2025-05-21 13:26 ` [FFmpeg-devel] [PATCH v2 " Zhao Zhili
@ 2025-05-21 13:52 ` Andreas Rheinhardt
2025-05-22 5:10 ` Zhao Zhili
0 siblings, 1 reply; 8+ messages in thread
From: Andreas Rheinhardt @ 2025-05-21 13:52 UTC (permalink / raw)
To: ffmpeg-devel
Zhao Zhili:
> From: Zhao Zhili <zhilizhao@tencent.com>
>
> ---
> tests/fate/hevc.mak | 3 +++
> tests/ref/fate/hevc-color-reserved | 6 ++++++
> 2 files changed, 9 insertions(+)
> create mode 100644 tests/ref/fate/hevc-color-reserved
>
> diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak
> index 390ccf46e2..8113c04300 100644
> --- a/tests/fate/hevc.mak
> +++ b/tests/fate/hevc.mak
> @@ -294,6 +294,9 @@ FATE_HEVC-$(call FRAMECRC, MOV, HEVC) += fate-hevc-mv-position
> fate-hevc-alpha: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/alpha.mp4
> FATE_HEVC-$(call FRAMECRC, MOV, HEVC) += fate-hevc-alpha
>
> +fate-hevc-color-reserved: CMD = framecrc -bsf:v hevc_metadata=colour_primaries=0:transfer_characteristics=0:matrix_coefficients=3 -i $(TARGET_SAMPLES)/hevc-conformance/AMP_A_Samsung_4.bit -vf scale,format=nv12 -frames:v 1
> +FATE_HEVC-$(call FRAMECRC, HEVC, HEVC, HEVC_METADATA_BSF SCALE_FILTER) += fate-hevc-color-reserved
> +
> FATE_SAMPLES_AVCONV += $(FATE_HEVC-yes)
> FATE_SAMPLES_FFPROBE += $(FATE_HEVC_FFPROBE-yes)
>
> diff --git a/tests/ref/fate/hevc-color-reserved b/tests/ref/fate/hevc-color-reserved
> new file mode 100644
> index 0000000000..cba6397aa8
> --- /dev/null
> +++ b/tests/ref/fate/hevc-color-reserved
> @@ -0,0 +1,6 @@
> +#tb 0: 1/25
> +#media_type 0: video
> +#codec_id 0: rawvideo
> +#dimensions 0: 2560x1600
> +#sar 0: 0/1
> +0, 0, 0, 1, 6144000, 0x427b9a00
This seems to simply presume that hevc_metadata does what it is supposed
to do, but this is not really tested. If hevc_metadata were a no-op for
this, it would pass the test. Why don't you use something with a hash of
the output of hevc_metadata?
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2 3/3] tests: Add fate-hevc-color-reserved
2025-05-21 13:52 ` Andreas Rheinhardt
@ 2025-05-22 5:10 ` Zhao Zhili
0 siblings, 0 replies; 8+ messages in thread
From: Zhao Zhili @ 2025-05-22 5:10 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On May 21, 2025, at 21:52, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote:
>
> Zhao Zhili:
>> From: Zhao Zhili <zhilizhao@tencent.com>
>>
>> ---
>> tests/fate/hevc.mak | 3 +++
>> tests/ref/fate/hevc-color-reserved | 6 ++++++
>> 2 files changed, 9 insertions(+)
>> create mode 100644 tests/ref/fate/hevc-color-reserved
>>
>> diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak
>> index 390ccf46e2..8113c04300 100644
>> --- a/tests/fate/hevc.mak
>> +++ b/tests/fate/hevc.mak
>> @@ -294,6 +294,9 @@ FATE_HEVC-$(call FRAMECRC, MOV, HEVC) += fate-hevc-mv-position
>> fate-hevc-alpha: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/alpha.mp4
>> FATE_HEVC-$(call FRAMECRC, MOV, HEVC) += fate-hevc-alpha
>>
>> +fate-hevc-color-reserved: CMD = framecrc -bsf:v hevc_metadata=colour_primaries=0:transfer_characteristics=0:matrix_coefficients=3 -i $(TARGET_SAMPLES)/hevc-conformance/AMP_A_Samsung_4.bit -vf scale,format=nv12 -frames:v 1
>> +FATE_HEVC-$(call FRAMECRC, HEVC, HEVC, HEVC_METADATA_BSF SCALE_FILTER) += fate-hevc-color-reserved
>> +
>> FATE_SAMPLES_AVCONV += $(FATE_HEVC-yes)
>> FATE_SAMPLES_FFPROBE += $(FATE_HEVC_FFPROBE-yes)
>>
>> diff --git a/tests/ref/fate/hevc-color-reserved b/tests/ref/fate/hevc-color-reserved
>> new file mode 100644
>> index 0000000000..cba6397aa8
>> --- /dev/null
>> +++ b/tests/ref/fate/hevc-color-reserved
>> @@ -0,0 +1,6 @@
>> +#tb 0: 1/25
>> +#media_type 0: video
>> +#codec_id 0: rawvideo
>> +#dimensions 0: 2560x1600
>> +#sar 0: 0/1
>> +0, 0, 0, 1, 6144000, 0x427b9a00
>
> This seems to simply presume that hevc_metadata does what it is supposed
> to do, but this is not really tested. If hevc_metadata were a no-op for
> this, it would pass the test. Why don't you use something with a hash of
> the output of hevc_metadata?
Added another test. Forgive me for "PATCH v2” which should be "PATCH v3”.
https://ffmpeg.org/pipermail/ffmpeg-devel/2025-May/343927.html
>
> - Andreas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-05-22 5:10 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20250521130546.4003-1-quinkblack@foxmail.com>
2025-05-21 13:06 ` [FFmpeg-devel] [PATCH 3/3] tests: Add fate-hevc-color-reserved Zhao Zhili
2025-05-21 13:11 ` Andreas Rheinhardt
2025-05-21 13:26 ` [FFmpeg-devel] [PATCH v2 " Zhao Zhili
2025-05-21 13:52 ` Andreas Rheinhardt
2025-05-22 5:10 ` Zhao Zhili
2025-05-21 13:28 ` [FFmpeg-devel] [PATCH " Zhao Zhili
2025-05-21 13:37 ` Zhao Zhili
2025-05-21 13:50 ` Andreas Rheinhardt
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git