Re: [FFmpeg-devel] [PATCH 3/3] tests: Add fate-hevc-color-reserved

[Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org>]

> On May 21, 2025, at 21:28, Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org> wrote:
> 
>> On May 21, 2025, at 21:11, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote:
>> 
>> Zhao Zhili:
>>> From: Zhao Zhili <zhilizhao@tencent.com>
>>> 
>>> ---
>>> tests/fate/hevc.mak                | 3 +++
>>> tests/ref/fate/hevc-color-reserved | 6 ++++++
>>> 2 files changed, 9 insertions(+)
>>> create mode 100644 tests/ref/fate/hevc-color-reserved
>>> 
>>> diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak
>>> index 390ccf46e2..5e721526d0 100644
>>> --- a/tests/fate/hevc.mak
>>> +++ b/tests/fate/hevc.mak
>>> @@ -294,6 +294,9 @@ FATE_HEVC-$(call FRAMECRC, MOV, HEVC) += fate-hevc-mv-position
>>> fate-hevc-alpha: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/alpha.mp4
>>> FATE_HEVC-$(call FRAMECRC, MOV, HEVC) += fate-hevc-alpha
>>> 
>>> +fate-hevc-color-reserved: CMD = framecrc -i $(TARGET_SAMPLES)/hevc/color_prim_reserved0.hevc -fps_mode passthrough -sws_flags +accurate_rnd+bitexact -vf scale,format=nv12
>>> +FATE_HEVC-$(call FRAMECRC, HEVC, HEVC, SCALE_FILTER) += fate-hevc-color-reserved
>> 
>> A new sample for this? Why don't you just create one with hevc_metadata?

On the other hand, we can create invalid sample with hevc_metadata for now.

Does it make sense to check primaries/trc/matrix in hevc_metadata?

> 
> Great idea. See patch v2 3/3.
> 
> https://ffmpeg.org/pipermail/ffmpeg-devel/2025-May/343884.html
> 
>> 
>>> +
>>> FATE_SAMPLES_AVCONV += $(FATE_HEVC-yes)
>>> FATE_SAMPLES_FFPROBE += $(FATE_HEVC_FFPROBE-yes)
>>> 
>>> diff --git a/tests/ref/fate/hevc-color-reserved b/tests/ref/fate/hevc-color-reserved
>>> new file mode 100644
>>> index 0000000000..3351628209
>>> --- /dev/null
>>> +++ b/tests/ref/fate/hevc-color-reserved
>>> @@ -0,0 +1,6 @@
>>> +#tb 0: 1/60
>>> +#media_type 0: video
>>> +#codec_id 0: rawvideo
>>> +#dimensions 0: 1920x900
>>> +#sar 0: 1/1
>>> +0,          0,          0,        1,  2592000, 0xfa6fce1e
>> 
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> 
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".