From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AFEA34876D for ; Wed, 17 Jan 2024 11:22:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B286468CEE7; Wed, 17 Jan 2024 13:22:33 +0200 (EET) Received: from out203-205-221-149.mail.qq.com (unknown [203.205.221.149]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1227068CEE5 for ; Wed, 17 Jan 2024 13:22:25 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1705490541; bh=ObSVDUgkDmRGHTk6rYOJC3bp8FHTY3H7nPf8FuGt+bI=; h=From:Subject:Date:References:To:In-Reply-To; b=R/uvi2gskqEhb2IVtvTc7BSwXKckdy1ki41PnWmBsXQjLyC0R3MSdD07UIwZhhW6J oKWSxtshfAbhyNlNj3Sg5THtD+tm2ouHCLCxNVWMlrTMf33lwRJyqUj52kxaK5e2l8 OUPe02VgHdaIAkcnC2wxViifgPgdwc9RVv9wKghU= Received: from smtpclient.apple ([119.147.10.194]) by newxmesmtplogicsvrsza7-0.qq.com (NewEsmtp) with SMTP id 5940B4F2; Wed, 17 Jan 2024 19:22:20 +0800 X-QQ-mid: xmsmtpt1705490540tzr193i71 Message-ID: X-QQ-XMAILINFO: MAcVqULX7QQ1rM2pV9xZU6K2VWYU9EKWIYyqlzkjErAeWzyvXZpKtWRL3+Tmrx fxgedIOm1bQVNZAgZn8HppaGNgaxMJLhaAYXfACFtJ+aK/SKhkWKf2SXHsuBeN1wThVHXIYpac+3 6Sr9jfQ5Xi7Nk8Wwjr8LdQwg37QnZUUD6787zPhSOPk5SjMKfopfAcvvmCsKD8NV867XRaizAW4I J7J1FYv7JCzMR5DhTWTWbNfpzINsdvQGEgBd4c7RnrxqZybgUEpb+4qln+qMEa0vT6316o3I3uYR /nIh9kEHjDBR9AtjkLoxFFKk3ZyyBP8M/hA7AhO/PwHdtGAyiv2WRC+nQxGrohryQgeWiF7ddxiw nO4mjHTBU+WB+8F9TjHDO/PbKXurMrcm9oYZVyNNUpCCxSlXJD8MaS5zANCZcMUgxCbcmUSR6CG8 kP/Bv9aqXtwAlMtFEGYefMcL1mlI9veYHG68PfT2tG24CN4hylttK9FgCCJi/RghoYo4Bm46yb4o zHgHVqceVvbt56fjheXcOJLP1Znq/Goxf89mVQiOXitArJjnP9ISp+LHt3OogFNtVg43LcI6b2F4 yHTpbBZCzeSOKPsa7dHLCjwAgZAj8lP/A/dbsH0EDVySJ2OJYByT8HxhB25zTbi2S+bHFbP9Sw0K YQ12plLkwBsZue9Kv1KzXYnMlnJWMXLdXkOuCgf4Gzt/M9xQthcv9q0yMoro1eoTxBxnaiU7Qhz2 wGUxPOUn8yJz8hIDVCaCqwbKsNDTCcORsl4Yb24EywB/Bc4fHlgzvDVUQdJs1U4GzZhcLhDSqDLu o3ao83zFFO9qBLUTlsSFCyHH4uWZXl3RgZa/ce3KUGTOKOEwTxmCp0OsFJoRjvTqwwirBCPDsjBI lI21Qqe1xAyaMRbfERxsh9XhZvFGX3YzvjV22eWWW7NtBo3AicK1qhbb7cCKvBQ7ZMf3TQyST9hB huptoylcDE/gBCfEdWWnZLOjI7q0AqEALBaKhTZv2qPBa7aA/pmw== X-QQ-XMRINFO: NyFYKkN4Ny6FSmKK/uo/jdU= From: Zhao Zhili Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\)) Date: Wed, 17 Jan 2024 19:22:10 +0800 References: <20240117092233.8503-1-anton@khirnov.net> To: FFmpeg development discussions and patches In-Reply-To: <20240117092233.8503-1-anton@khirnov.net> X-OQ-MSGID: <9C7765CD-3770-4759-B8EB-976EB7554DA4@foxmail.com> X-Mailer: Apple Mail (2.3774.200.91.1.1) Subject: Re: [FFmpeg-devel] [PATCH 1/6] fftools/ffprobe: make option strings dynamically allocated X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Jan 17, 2024, at 17:22, Anton Khirnov wrote: > > Do not store the supplied arg pointer directly. While that is valid for > now, arg will become ephemeral in the future commits. > --- > fftools/ffprobe.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c > index f00ba48620..3a7aae3572 100644 > --- a/fftools/ffprobe.c > +++ b/fftools/ffprobe.c > @@ -3827,8 +3827,10 @@ static int opt_input_file(void *optctx, const char *arg) > return AVERROR(EINVAL); > } > if (!strcmp(arg, "-")) > - arg = "fd:"; > - input_filename = arg; > + arg = "pipe:"; Does the change of protocol on purpose, and why? > + input_filename = av_strdup(arg); > + if (!input_filename) > + return AVERROR(ENOMEM); > > return 0; > } > @@ -3849,15 +3851,18 @@ static int opt_output_file_o(void *optctx, const char *opt, const char *arg) > } > if (!strcmp(arg, "-")) > arg = "fd:"; > - output_filename = arg; > + output_filename = av_strdup(arg); > + if (!output_filename) > + return AVERROR(ENOMEM); > > return 0; > } > > static int opt_print_filename(void *optctx, const char *opt, const char *arg) > { > - print_input_filename = arg; > - return 0; > + av_freep(&print_input_filename); > + print_input_filename = av_strdup(arg); > + return print_input_filename ? 0 : AVERROR(ENOMEM); > } > > void show_help_default(const char *opt, const char *arg) > @@ -4287,6 +4292,9 @@ int main(int argc, char **argv) > > end: > av_freep(&output_format); > + av_freep(&output_filename); > + av_freep(&input_filename); > + av_freep(&print_input_filename); > av_freep(&read_intervals); > av_hash_freep(&hash); > > -- > 2.42.0 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".