From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5E6C745C51 for ; Mon, 29 May 2023 12:33:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 87EA468C1BD; Mon, 29 May 2023 15:33:02 +0300 (EEST) Received: from out162-62-57-64.mail.qq.com (out162-62-57-64.mail.qq.com [162.62.57.64]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6DA6F6807A1 for ; Mon, 29 May 2023 15:32:55 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1685363573; bh=62FROxQTctCg2Lk9AgR5SETGy2yOIM+mSyqEJCcylqw=; h=From:Subject:Date:References:To:In-Reply-To; b=NsKcR256tvoofm56B8xADBSYMkEIO9e4RubPo6V33xyJAKMW+lAAWcFtqnzrpuCQj NnSWzNh0+WsSmWRNxGRCAU285eOHLD/Dm4NNWZ26G6Ns8jRnBvjWV57fNodCO2atK/ 4cUSirLW7m6412o5SCF4WY4huHB1CsKoi8dFZBYk= Received: from smtpclient.apple ([119.147.10.188]) by newxmesmtplogicsvrszc5-0.qq.com (NewEsmtp) with SMTP id 83436ADD; Mon, 29 May 2023 20:32:52 +0800 X-QQ-mid: xmsmtpt1685363572t2kgjyq3v Message-ID: X-QQ-XMAILINFO: NNoVXaH09J172kFEK5pf1FybcgE1ndAFoL2IvXQeCuiN6TGyfjONniw5shhXvz bZRDWTn/oOKbWbOGRfa066C0cQSfSfeFH6Ge4mAlPlF7peBv2DE0PvSoZ7usZ5XtR+wBkJaMKQOi NEKzBKE4TE+pNeytls83bu0Z1Aixx4toHZFuzLAGon3rwxJ7tPSGF5q2yVyxPpvkielpY4PILjp6 +rt7C0VlFhoYs5uMqE9jZXaMDm3nNQI4fOhTtmyCafxOe75lYIVkViW6R37a4uwl1erXAvDsPvTD QF9VSkG2WKstRcL+iw5U9N0HsSCYYGYk4cUT+ZX3O5bSc4mvpAQMXZdwNUs0Y6YKyKV667lNzwWS sQNz9QRd99kmG/2tuSTWfux5u1mb9kRfjExmIcUacqtaCGCvdL63BoSIMsJvz9nyV6yNAuI1+HNb +jYrMSn8gfKW33mSjOr0jd1w/lWN7TlZXvuewGURONui+TlQQN9ROnTQjhg3sxnNhiGJfxDhiS6E h3OExsAR4ZkYRaEWjMngH5gO0bW3Wkny38Ey2FwMd4EU7NUXNwsBdqgA38oo1D26pDNB8jjIVARV xnn07aPhZ+UvJ+mtT0vTJeLpkMp6TgfegfmKiB0+iZM5Jz2nEMnINBY6zT8nbx8t1MixPCtspmUr BxFInpwUEA1oQ/jz3WUx/YmrxkFXPelocxlZmC0irdNo30LEX9RtUfG+i9mTEYJefa1pQ+UpRi9k V/YR0lYVVPpKs4ZAKsoWDdKs2LryKQXa9zmZFtsKe7lCI71ckM1O2yltwL7ihOFS3QucYiBQPaWP UaBNBBte+/idFPAwyWTkiAI0sO0G7JGgR3n04vz9dQJFVgEPdH0SKH3XtNktWOq5QhrXBIcAP1t3 W4zfh5VUrwnp7NbwlvKOGZakM4CExX9r3hNWEkVFFGEVoh3zkGudb5iPCVashtLY2ZV9SDxI38Ko nj2OROZb3PHmNe+6fEwc2S0iAkj7JA2UF+G5Lfiei1wvB3r/iihSoJIj3mw+f9 From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Date: Mon, 29 May 2023 20:32:52 +0800 References: <20dcc5d8-b920-426b-8f10-f534bebf6cf7@EX-SZ059.tencent.com> To: FFmpeg development discussions and patches In-Reply-To: <20dcc5d8-b920-426b-8f10-f534bebf6cf7@EX-SZ059.tencent.com> X-OQ-MSGID: <98209C56-40D9-4CD7-AF6E-C7068E52450F@foxmail.com> X-Mailer: Apple Mail (2.3696.120.41.1.1) Subject: Re: [FFmpeg-devel] [Internet][PATCH 1/6] avcodec/cbs: add API to discard units by AVDiscard X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Ping. Any comments on the idea? > On May 18, 2023, at 05:23, Zhao Zhili wrote: > > From: Zhao Zhili > > --- > libavcodec/cbs.c | 21 +++++++++++++++++++++ > libavcodec/cbs.h | 17 +++++++++++++++++ > libavcodec/cbs_internal.h | 6 ++++++ > 3 files changed, 44 insertions(+) > > diff --git a/libavcodec/cbs.c b/libavcodec/cbs.c > index 504197e06d..cf5211249b 100644 > --- a/libavcodec/cbs.c > +++ b/libavcodec/cbs.c > @@ -1026,3 +1026,24 @@ int ff_cbs_make_unit_writable(CodedBitstreamContext *ctx, > av_buffer_unref(&ref); > return 0; > } > + > +void ff_cbs_discard_units(CodedBitstreamContext *ctx, > + CodedBitstreamFragment *frag, > + enum AVDiscard skip, > + int flags) > +{ > + if (!ctx->codec->discarded_unit) > + return; > + > + for (int i = frag->nb_units - 1; i >= 0; i--) { > + if (ctx->codec->discarded_unit(ctx, &frag->units[i], skip)) { > + // discard all units > + if (!(flags & DISCARD_FLAG_KEEP_NON_VCL)) { > + ff_cbs_fragment_free(frag); > + return; > + } > + > + ff_cbs_delete_unit(frag, i); > + } > + } > +} > diff --git a/libavcodec/cbs.h b/libavcodec/cbs.h > index ee21623dac..b4131db5fe 100644 > --- a/libavcodec/cbs.h > +++ b/libavcodec/cbs.h > @@ -26,6 +26,7 @@ > > #include "codec_id.h" > #include "codec_par.h" > +#include "defs.h" > #include "packet.h" > > > @@ -432,5 +433,21 @@ int ff_cbs_make_unit_refcounted(CodedBitstreamContext *ctx, > int ff_cbs_make_unit_writable(CodedBitstreamContext *ctx, > CodedBitstreamUnit *unit); > > +enum CbsDiscardFlags { > + DISCARD_FLAG_NONE = 0, > + > + /** > + * keep non-vcl units even if the picture has been dropped. > + */ > + DISCARD_FLAG_KEEP_NON_VCL = 0x01, > +}; > + > +/** > + * Discard units accroding to 'skip'. > + */ > +void ff_cbs_discard_units(CodedBitstreamContext *ctx, > + CodedBitstreamFragment *frag, > + enum AVDiscard skip, > + int flags); > > #endif /* AVCODEC_CBS_H */ > diff --git a/libavcodec/cbs_internal.h b/libavcodec/cbs_internal.h > index e585c77934..077954eee5 100644 > --- a/libavcodec/cbs_internal.h > +++ b/libavcodec/cbs_internal.h > @@ -133,6 +133,12 @@ typedef struct CodedBitstreamType { > CodedBitstreamUnit *unit, > PutBitContext *pbc); > > + // Return 1 when the unit should be dropped according to 'skip', > + // 0 otherwise. > + int (*discarded_unit)(CodedBitstreamContext *ctx, > + const CodedBitstreamUnit *unit, > + enum AVDiscard skip); > + > // Read the data from all of frag->units and assemble it into > // a bitstream for the whole fragment. > int (*assemble_fragment)(CodedBitstreamContext *ctx, > -- > 2.25.1 > > > > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".