* [FFmpeg-devel] [PATCH 2/2] avcodec/vvc: Remove write-only assignments in alf_filter_chroma [not found] <20240716024957.41421-1-quinkblack@foxmail.com> @ 2024-07-16 2:49 ` Zhao Zhili 2024-07-17 13:30 ` Nuo Mi 0 siblings, 1 reply; 2+ messages in thread From: Zhao Zhili @ 2024-07-16 2:49 UTC (permalink / raw) To: ffmpeg-devel; +Cc: Zhao Zhili From: Zhao Zhili <zhilizhao@tencent.com> --- libavcodec/vvc/filter_template.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/libavcodec/vvc/filter_template.c b/libavcodec/vvc/filter_template.c index 32777452b7..6dd7310089 100644 --- a/libavcodec/vvc/filter_template.c +++ b/libavcodec/vvc/filter_template.c @@ -153,8 +153,6 @@ static void FUNC(alf_filter_chroma)(uint8_t* _dst, ptrdiff_t dst_stride, const u const pixel *s2 = s0 - src_stride; const pixel *s3 = s1 + src_stride; const pixel *s4 = s2 - src_stride; - const pixel *s5 = s3 + src_stride; - const pixel *s6 = s4 - src_stride; for (int i = 0; i < ALF_BLOCK_SIZE; i++) { pixel *dst = (pixel *)_dst + (y + i) * dst_stride + x; @@ -164,8 +162,6 @@ static void FUNC(alf_filter_chroma)(uint8_t* _dst, ptrdiff_t dst_stride, const u const pixel *p2 = s2 + i * src_stride; const pixel *p3 = s3 + i * src_stride; const pixel *p4 = s4 + i * src_stride; - const pixel *p5 = s5 + i * src_stride; - const pixel *p6 = s6 + i * src_stride; const int is_near_vb_above = (y + i < vb_pos) && (y + i >= vb_pos - 1); const int is_near_vb_below = (y + i >= vb_pos) && (y + i <= vb_pos); @@ -174,19 +170,15 @@ static void FUNC(alf_filter_chroma)(uint8_t* _dst, ptrdiff_t dst_stride, const u if ((y + i < vb_pos) && ((y + i) >= vb_above)) { p1 = (y + i == vb_pos - 1) ? p0 : p1; p3 = (y + i >= vb_pos - 2) ? p1 : p3; - p5 = (y + i >= vb_pos - 3) ? p3 : p5; p2 = (y + i == vb_pos - 1) ? p0 : p2; p4 = (y + i >= vb_pos - 2) ? p2 : p4; - p6 = (y + i >= vb_pos - 3) ? p4 : p6; } else if ((y + i >= vb_pos) && ((y + i) <= vb_below)) { p2 = (y + i == vb_pos ) ? p0 : p2; p4 = (y + i <= vb_pos + 1) ? p2 : p4; - p6 = (y + i <= vb_pos + 2) ? p4 : p6; p1 = (y + i == vb_pos ) ? p0 : p1; p3 = (y + i <= vb_pos + 1) ? p1 : p3; - p5 = (y + i <= vb_pos + 2) ? p3 : p5; } for (int j = 0; j < ALF_BLOCK_SIZE; j++) { @@ -212,8 +204,6 @@ static void FUNC(alf_filter_chroma)(uint8_t* _dst, ptrdiff_t dst_stride, const u p2++; p3++; p4++; - p5++; - p6++; } } } -- 2.42.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vvc: Remove write-only assignments in alf_filter_chroma 2024-07-16 2:49 ` [FFmpeg-devel] [PATCH 2/2] avcodec/vvc: Remove write-only assignments in alf_filter_chroma Zhao Zhili @ 2024-07-17 13:30 ` Nuo Mi 0 siblings, 0 replies; 2+ messages in thread From: Nuo Mi @ 2024-07-17 13:30 UTC (permalink / raw) To: FFmpeg development discussions and patches; +Cc: Zhao Zhili On Tue, Jul 16, 2024 at 10:50 AM Zhao Zhili <quinkblack@foxmail.com> wrote: > From: Zhao Zhili <zhilizhao@tencent.com> > merged. Thank you > > --- > libavcodec/vvc/filter_template.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/libavcodec/vvc/filter_template.c > b/libavcodec/vvc/filter_template.c > index 32777452b7..6dd7310089 100644 > --- a/libavcodec/vvc/filter_template.c > +++ b/libavcodec/vvc/filter_template.c > @@ -153,8 +153,6 @@ static void FUNC(alf_filter_chroma)(uint8_t* _dst, > ptrdiff_t dst_stride, const u > const pixel *s2 = s0 - src_stride; > const pixel *s3 = s1 + src_stride; > const pixel *s4 = s2 - src_stride; > - const pixel *s5 = s3 + src_stride; > - const pixel *s6 = s4 - src_stride; > > for (int i = 0; i < ALF_BLOCK_SIZE; i++) { > pixel *dst = (pixel *)_dst + (y + i) * dst_stride + x; > @@ -164,8 +162,6 @@ static void FUNC(alf_filter_chroma)(uint8_t* _dst, > ptrdiff_t dst_stride, const u > const pixel *p2 = s2 + i * src_stride; > const pixel *p3 = s3 + i * src_stride; > const pixel *p4 = s4 + i * src_stride; > - const pixel *p5 = s5 + i * src_stride; > - const pixel *p6 = s6 + i * src_stride; > > const int is_near_vb_above = (y + i < vb_pos) && (y + i > >= vb_pos - 1); > const int is_near_vb_below = (y + i >= vb_pos) && (y + i > <= vb_pos); > @@ -174,19 +170,15 @@ static void FUNC(alf_filter_chroma)(uint8_t* _dst, > ptrdiff_t dst_stride, const u > if ((y + i < vb_pos) && ((y + i) >= vb_above)) { > p1 = (y + i == vb_pos - 1) ? p0 : p1; > p3 = (y + i >= vb_pos - 2) ? p1 : p3; > - p5 = (y + i >= vb_pos - 3) ? p3 : p5; > > p2 = (y + i == vb_pos - 1) ? p0 : p2; > p4 = (y + i >= vb_pos - 2) ? p2 : p4; > - p6 = (y + i >= vb_pos - 3) ? p4 : p6; > } else if ((y + i >= vb_pos) && ((y + i) <= vb_below)) { > p2 = (y + i == vb_pos ) ? p0 : p2; > p4 = (y + i <= vb_pos + 1) ? p2 : p4; > - p6 = (y + i <= vb_pos + 2) ? p4 : p6; > > p1 = (y + i == vb_pos ) ? p0 : p1; > p3 = (y + i <= vb_pos + 1) ? p1 : p3; > - p5 = (y + i <= vb_pos + 2) ? p3 : p5; > } > > for (int j = 0; j < ALF_BLOCK_SIZE; j++) { > @@ -212,8 +204,6 @@ static void FUNC(alf_filter_chroma)(uint8_t* _dst, > ptrdiff_t dst_stride, const u > p2++; > p3++; > p4++; > - p5++; > - p6++; > } > } > } > -- > 2.42.0 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-17 13:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20240716024957.41421-1-quinkblack@foxmail.com>
2024-07-16 2:49 ` [FFmpeg-devel] [PATCH 2/2] avcodec/vvc: Remove write-only assignments in alf_filter_chroma Zhao Zhili
2024-07-17 13:30 ` Nuo Mi
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git