Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Zhao Zhili <quinkblack@foxmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Zhao Zhili <zhilizhao@tencent.com>
Subject: [FFmpeg-devel] [PATCH 2/2] avcodec/vvc: Remove write-only assignments in alf_filter_chroma
Date: Tue, 16 Jul 2024 10:49:57 +0800
Message-ID: <tencent_A04DA24FC0D538A716B8941645CD1CA02A07@qq.com> (raw)
In-Reply-To: <20240716024957.41421-1-quinkblack@foxmail.com>

From: Zhao Zhili <zhilizhao@tencent.com>

---
 libavcodec/vvc/filter_template.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/libavcodec/vvc/filter_template.c b/libavcodec/vvc/filter_template.c
index 32777452b7..6dd7310089 100644
--- a/libavcodec/vvc/filter_template.c
+++ b/libavcodec/vvc/filter_template.c
@@ -153,8 +153,6 @@ static void FUNC(alf_filter_chroma)(uint8_t* _dst, ptrdiff_t dst_stride, const u
             const pixel *s2 = s0 - src_stride;
             const pixel *s3 = s1 + src_stride;
             const pixel *s4 = s2 - src_stride;
-            const pixel *s5 = s3 + src_stride;
-            const pixel *s6 = s4 - src_stride;
 
             for (int i = 0; i < ALF_BLOCK_SIZE; i++) {
                 pixel *dst = (pixel *)_dst + (y + i) * dst_stride + x;
@@ -164,8 +162,6 @@ static void FUNC(alf_filter_chroma)(uint8_t* _dst, ptrdiff_t dst_stride, const u
                 const pixel *p2 = s2 + i * src_stride;
                 const pixel *p3 = s3 + i * src_stride;
                 const pixel *p4 = s4 + i * src_stride;
-                const pixel *p5 = s5 + i * src_stride;
-                const pixel *p6 = s6 + i * src_stride;
 
                 const int is_near_vb_above = (y + i <  vb_pos) && (y + i >= vb_pos - 1);
                 const int is_near_vb_below = (y + i >= vb_pos) && (y + i <= vb_pos);
@@ -174,19 +170,15 @@ static void FUNC(alf_filter_chroma)(uint8_t* _dst, ptrdiff_t dst_stride, const u
                 if ((y + i < vb_pos) && ((y + i) >= vb_above)) {
                     p1 = (y + i == vb_pos - 1) ? p0 : p1;
                     p3 = (y + i >= vb_pos - 2) ? p1 : p3;
-                    p5 = (y + i >= vb_pos - 3) ? p3 : p5;
 
                     p2 = (y + i == vb_pos - 1) ? p0 : p2;
                     p4 = (y + i >= vb_pos - 2) ? p2 : p4;
-                    p6 = (y + i >= vb_pos - 3) ? p4 : p6;
                 } else if ((y + i >= vb_pos) && ((y + i) <= vb_below)) {
                     p2 = (y + i == vb_pos    ) ? p0 : p2;
                     p4 = (y + i <= vb_pos + 1) ? p2 : p4;
-                    p6 = (y + i <= vb_pos + 2) ? p4 : p6;
 
                     p1 = (y + i == vb_pos    ) ? p0 : p1;
                     p3 = (y + i <= vb_pos + 1) ? p1 : p3;
-                    p5 = (y + i <= vb_pos + 2) ? p3 : p5;
                 }
 
                 for (int j = 0; j < ALF_BLOCK_SIZE; j++) {
@@ -212,8 +204,6 @@ static void FUNC(alf_filter_chroma)(uint8_t* _dst, ptrdiff_t dst_stride, const u
                     p2++;
                     p3++;
                     p4++;
-                    p5++;
-                    p6++;
                 }
             }
         }
-- 
2.42.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

       reply	other threads:[~2024-07-16  2:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240716024957.41421-1-quinkblack@foxmail.com>
2024-07-16  2:49 ` Zhao Zhili [this message]
2024-07-17 13:30   ` Nuo Mi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_A04DA24FC0D538A716B8941645CD1CA02A07@qq.com \
    --to=quinkblack@foxmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=zhilizhao@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git