From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5D1874490A for ; Tue, 3 Jan 2023 10:18:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2FACA68BD12; Tue, 3 Jan 2023 12:18:47 +0200 (EET) Received: from out162-62-58-211.mail.qq.com (out162-62-58-211.mail.qq.com [162.62.58.211]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E3A4F68B73D for ; Tue, 3 Jan 2023 12:18:40 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1672741115; bh=NzKbvnDM6tiGvJhj8I0wZ2VcPKzfry3R+vjYMs0S/Xk=; h=From:To:Cc:Subject:Date; b=pLUAiaXNxNwiv+HzlvcmS4sQSGiUxLylU9P7uJLe2+U/Hr8zDT+slywin6Xc7JGe0 pGIJ3hBeLO5D780Gye1ycD/QlyLOamiXoCgOOKRll5rMvGyIfPbJ3FAI9tYTshGs01 E4mJnt7TqIkTll7HUuquVJLMAzdon0czPU2KhKFo= Received: from ZHILIZHAO-MB2.tencent.com ([113.108.77.64]) by newxmesmtplogicsvrsza10-0.qq.com (NewEsmtp) with SMTP id 4A2A8682; Tue, 03 Jan 2023 18:18:34 +0800 X-QQ-mid: xmsmtpt1672741114tpxrws4j2 Message-ID: X-QQ-XMAILINFO: NryjvM7YTpGPlHjzdw1P3r0V873owiBliGSTu4dOWK8tQIQrKSlsC+iVroY/V2 pTS9v8f1naYNU+Iana4cpPp6GaL1Uwztkk1K8vRia/i+1pkGWATXHesJOM9+UUfYEHSs38Hn07YG Kk9rA39wB0zmqOQiB9VpyWl7R29AAWRVS6300OlSE/6kw1JPpoUG3owIOyrIztuG5U4wIYftyXXP 5JsEThKBUTejQZSFmDRLUmTosfWYL2MHnizAxsvwLU5zqCH3PtUq34V/7a0vxgvcFH30cbU18WZ+ Upddb53iEAnDMwkeMImITWIvtNMypsVPjENMlxc0q8RfE9hRBUQwM27UgHhmVjD49/32/rLsCzq8 rsDQX5dwrAeH3d4Neq2DHQ0P9GtGS/Az2IZvhsDq2/sqyoDMcjadT9MlrLXQEeZoSanwzn+GjHIB NGooOCrswOMFLWxhVFEObyC21BKugzND5AMzFdzudE6PLdn0K805sBy2QN0F/cMDMRMTMwVfr+/e B+wUGp9JfHG9CxFqm//aetuE1tbhN8maIOquBJQWRN1evDhRaKSnndHp7kMj2FQcrpTeLka1aNXh nKctDFaFNIDbUjQFA8C4EgclGCk1d2VwJ8eVWmoNn6bWRmJyeMu9Am76kQRsrihbWH1TTLoPbzB9 imQmMu6L2uKqjEwvNWOwFZQtsmXgLvNqzwpdvUhSD/UjvU3NX+SUDGaLTeJzbCErtUnQ1YtXUiYf ef6bnXjelAGM1heL4Anp4icjBT6Ywo5EtzzwCwfNm5dh1Gj9FGwa+czXQsRTgIrbQ2+HGH5V9H5Q bHqzk7QGuKlhVHlfHpahJTmo/NTGTUQ3SfNZ3/sXUp+b86m3iwyn0OMWMGwMKt4cGj77uwajSwi1 DJ6fjUUVjXng7vwwliyx2zGnX5Xf2rsXAfDtauD6L/S+nwpLfhUHnsozCDuhpiKdn4qbqJVZL0s2 s/UA7AZNw5JIpy7EfqsggPN3UfjxfT2trjDgTyvL0= From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Tue, 3 Jan 2023 18:18:30 +0800 X-OQ-MSGID: <20230103101832.98747-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/3] avcodec/videotoolboxenc: log when get_cv_pixel_format failed X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavcodec/videotoolboxenc.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index aec98ade4f..27db4e0d5e 100644 --- a/libavcodec/videotoolboxenc.c +++ b/libavcodec/videotoolboxenc.c @@ -847,13 +847,22 @@ static int get_cv_pixel_format(AVCodecContext* avctx, int* av_pixel_format, int* range_guessed) { + const char *range_name; if (range_guessed) *range_guessed = range != AVCOL_RANGE_MPEG && range != AVCOL_RANGE_JPEG; //MPEG range is used when no range is set *av_pixel_format = av_map_videotoolbox_format_from_pixfmt2(fmt, range == AVCOL_RANGE_JPEG); + if (*av_pixel_format) + return 0; + + range_name = av_color_range_name(range); + av_log(avctx, AV_LOG_ERROR, + "Could not get pixel format for color format '%s' range '%s'.\n", + av_get_pix_fmt_name(fmt), + range_name ? range_name : "Unknown"); - return *av_pixel_format ? 0 : AVERROR(EINVAL); + return AVERROR(EINVAL); } static void add_color_attr(AVCodecContext *avctx, CFMutableDictionaryRef dict) { @@ -2146,18 +2155,8 @@ static int get_cv_pixel_info( return AVERROR(EINVAL); status = get_cv_pixel_format(avctx, av_format, av_color_range, color, &range_guessed); - if (status) { - av_log(avctx, - AV_LOG_ERROR, - "Could not get pixel format for color format '%s' range '%s'.\n", - av_get_pix_fmt_name(av_format), - av_color_range > AVCOL_RANGE_UNSPECIFIED && - av_color_range < AVCOL_RANGE_NB ? - av_color_range_name(av_color_range) : - "Unknown"); - + if (status) return AVERROR(EINVAL); - } if (range_guessed) { if (!vtctx->warned_color_range) { -- 2.35.3 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".