From: xufuji456 <839789740@qq.com>
To: ffmpeg-devel@ffmpeg.org
Cc: xufuji456 <839789740@qq.com>
Subject: [FFmpeg-devel] [PATCH] avutil/imgutils: optimize image copying
Date: Fri, 5 May 2023 16:31:41 +0800
Message-ID: <tencent_9CC187B353F352961985D8B31162C2189309@qq.com> (raw)
It makes sense when copying 4K/8K video frame, got 2.7% speed up.
When the condition is no padding and src_linesize equals to dst,
we could copy plane instead of line by line.
before after rate
4K video:
9145 8998 1.6%
9804 9465 3.4%
9645 9394 2.6%
8K video:
28411 27718 2.4%
31288 30056 3.9%
32336 31571 2.4%
Signed-off-by: xufuji456 <839789740@qq.com>
---
libavutil/imgutils.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/libavutil/imgutils.c b/libavutil/imgutils.c
index 9ab5757cf6..f5898756ba 100644
--- a/libavutil/imgutils.c
+++ b/libavutil/imgutils.c
@@ -525,10 +525,18 @@ int av_image_copy_to_buffer(uint8_t *dst, int dst_size,
const uint8_t *src = src_data[i];
h = (height + (1 << shift) - 1) >> shift;
- for (j = 0; j < h; j++) {
- memcpy(dst, src, linesize[i]);
- dst += FFALIGN(linesize[i], align);
- src += src_linesize[i];
+ // When src's linesize equals to dst, we could copy plane directly
+ if (src_linesize[i] == linesize[i] && FFALIGN(linesize[i], align) == linesize[i]) {
+ int len = linesize[i] * h;
+ memcpy(dst, src, len);
+ dst += len;
+ src += len;
+ } else {
+ for (j = 0; j < h; j++) {
+ memcpy(dst, src, linesize[i]);
+ dst += FFALIGN(linesize[i], align);
+ src += src_linesize[i];
+ }
}
}
--
2.32.0 (Apple Git-132)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2023-05-05 8:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 8:31 xufuji456 [this message]
2023-05-09 9:59 ` Tomas Härdin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_9CC187B353F352961985D8B31162C2189309@qq.com \
--to=839789740@qq.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git