From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B6B30445BF for ; Sat, 19 Nov 2022 14:56:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 181E868B7D4; Sat, 19 Nov 2022 16:56:47 +0200 (EET) Received: from out203-205-251-53.mail.qq.com (out203-205-251-53.mail.qq.com [203.205.251.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9E84968B3A7 for ; Sat, 19 Nov 2022 16:56:39 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1668869794; bh=XKQ8Bob6Ow+AbVY3xeXhDeYqUBNyrtlEFBz6d1qH7uM=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=bqVWwy73xDsii6YiCeG8/J8TT6K+RqRDzs9GSnSmt+22ds2R8NLsNeT2Q+klhdJ8k iAMZji8Vs6CgJeM/pU4gQk60l0dj/ivAuS084yfoO+yZUcawxsrEDjQdfNm5gZ4Vr4 3nsR1cky1mJOqtvOwO94xaM+laLPlhuGDmmW6N70= Received: from zhilizhao-LC4 ([14.153.77.200]) by newxmesmtplogicsvrszc5-0.qq.com (NewEsmtp) with SMTP id E21B567E; Sat, 19 Nov 2022 22:56:33 +0800 X-QQ-mid: xmsmtpt1668869793tjjfhelx1 Message-ID: X-QQ-XMAILINFO: No84gL0ijbqco1BTP9MHPJj54qSJd6ZXCDlM9zoYgs5potZ1BozX/+hU6wf+wD yzmzIg2RfAUYw1X0IPPF2Rh3hh4PdCJgwAgRZs0XAnDUegW0YZJhrqQuBujnMceMv62Cw5cw9Sr/ 9TC0twR66vfb/YYfHurh9lpcjZNu1RUhE7TuRkA4+g9KeyORjx6ZYAmd5sW/qIFooFmVho6c1PeT VYSHuqlOmMN8829sBQkYZAXR7gwmWHJSpNLiA3H4ZyPR2jXFI8gR3pG2b4Rql6VKX+EabVdB1Nq6 iP51KM97cbM2NhGdvRNf+aqLzlqVlQSP9+7WX690HRYdyDtEf6aUbY7W01vY+GFg96NOAn63PIrO zFzYxT16gkMjFKSA4W0Usy6+TKXV4Kr4ZiHF2QJZ2ksPnJbgpp9RRfLZJb/+tg/UT8yRQgkmP2Ha 13Jkgwa4FZuVE7fqBe3FYH+HElCfjCPQC29Gmm7snB1hslB3KZ7r4sGPYVkQBqyLVB8GdK/8Xjlx Q0XZTgA+OhGTZiUy3RLTTLC+k6tqPAU98pk4mUWgs7MbsTVtRsnhNHzogWNftRoK41Tc+AeGZnCc XatuzODkDT4zjKG7JF3dSuC1D88WqWoBbna3zkoUtN99ujNx5WqIgdGTvXyrXuhC3fTlNiPwBfhm mr2d7jS+6sbGuToSrJWBiVUTixEJqysd+5MUUpqDfTQm+hnACyjEDQILZ1f3ces4yBPLM+Qs9OST 7HCHIYX+KiOAJ0qfSx2uF98lSRvuBJ1gjp9HiwxOTGdDs46yP0O1QSzX9czy3YHiTBlvN9mUBw0I fVeSihprU+k8+v+s9d57YD0K80O9lr+YTtKG8IWk5LnvDEUNKiq8nTIphR2dYAcTxTyV8dkQ1jj4 RSl6iosaxyRfWjnI3Todz2cxafD9p69vKuJ0QCnvy9XGW0JZO+3X9lVc7BUVgsOZEQnZfR58Wrim jJ7exntOPsFW/QLltkoDC/22Jq8UD3fdSJP9U9MTF75w/v8eLakS+Z2jRk+98D X-OQ-MSGID: From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Sat, 19 Nov 2022 22:56:33 +0800 In-Reply-To: References: <20221024031658.1026118-1-quinkblack@foxmail.com> User-Agent: Evolution 3.36.5-0ubuntu1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 01/12] avcodec/mediacodec: fix incorrect crop info X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Aman Karmani Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, 2022-11-19 at 00:20 -0800, Aman Karmani wrote: > Thank you for your work on this patchset! > > On Sun, Oct 23, 2022 at 8:17 PM Zhao Zhili > wrote: > > From: Zhao Zhili > > > > The crop info is optional, but used unconditionally. > > > > Signed-off-by: Zhao Zhili > > --- > > libavcodec/mediacodecdec_common.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/libavcodec/mediacodecdec_common.c > > b/libavcodec/mediacodecdec_common.c > > index 2a605e7f5b..c1cbb28488 100644 > > --- a/libavcodec/mediacodecdec_common.c > > +++ b/libavcodec/mediacodecdec_common.c > > @@ -487,6 +487,11 @@ static int > > mediacodec_dec_parse_format(AVCodecContext *avctx, > > MediaCodecDecConte > > AMEDIAFORMAT_GET_INT32(s->crop_left, "crop-left", 0); > > AMEDIAFORMAT_GET_INT32(s->crop_right, "crop-right", 0); > > > > + if (s->crop_bottom == 0 || s->crop_right == 0) { > > + s->crop_top = s->crop_left = 0; > > + s->crop_right = s->width - 1; > > + s->crop_bottom = s->height - 1; > > + } > > width = s->crop_right + 1 - s->crop_left; > > height = s->crop_bottom + 1 - s->crop_top; > > I had another approach I have been using for some time. WDYT? > > http://github.com/tmm1/ffmpeg/commit/ebc0ef75d25e712278c34427ef2f7d42f3dcf883 I found the issue when testing NDK mediacodec. There is no 'crop-left', 'crop-right' and so on. However, there is a 'crop' field in AMediaForma t, for example: android._video-scaling: int32(1), crop: Rect(0, 0, 1919, 1079), color- standard: int32(1), ... Unfortunately, it's available only since API level 28: ------------------------------------------------ extern const char* AMEDIAFORMAT_KEY_DISPLAY_CROP __INTRODUCED_IN(28); /** * Available since API level 28. */ bool AMediaFormat_getRect(AMediaFormat*, const char *name, int32_t *left, int32_t *top, int32_t *right, int32_t *bottom) __INTRODUCED_IN(28); ------------------------------------------------- So we need to add a new API in mediacodec_wrapper first, then extract crop info. It's on my TODO list. For your patch, + AMEDIAFORMAT_GET_INT32(width, "crop-width", 0); + AMEDIAFORMAT_GET_INT32(height, "crop-height", 0); I can't find documention about these fields, and they didn't show on Google Pixel 3. What's the device model? We can use it as a fallback, after crop-left/crop-right and crop rect failed. > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".