From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 4582644ACF
for <ffmpegdev@gitmailbox.com>; Sat, 21 Jun 2025 05:00:23 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id BED1A68C1C5;
Sat, 21 Jun 2025 08:00:20 +0300 (EEST)
Received: from out203-205-221-192.mail.qq.com (out203-205-221-192.mail.qq.com
[203.205.221.192])
by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 09D96687CB9
for <ffmpeg-devel@ffmpeg.org>; Sat, 21 Jun 2025 08:00:12 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com;
s=s201512; t=1750482007;
bh=aC1ApW5YpNBPMi4zje1CW3BNL2xF8zSEDTybiCJOU/4=;
h=From:Subject:Date:References:To:In-Reply-To;
b=Fhd/5Oaaa94Y+jYymPe//Y1sAAVCd4Css1j78mZjjyNQrWQtLLfmbAGFAda9A5nn6
N1LI9WeFQF5XqLuvXK6EU72mxlMp2ZmabMfM6JVFf9JOUcO51SmdGNIFu1+QBLIvdf
6L/H/jECl75CbqY0eCWwzPQKHQls8EwJB60VxPA0=
Received: from smtpclient.apple ([240e:3b7:3272:f5d0:4d1c:7788:d372:6e17])
by newxmesmtplogicsvrszb20-0.qq.com (NewEsmtp) with SMTP
id 682A2C; Sat, 21 Jun 2025 13:00:06 +0800
X-QQ-mid: xmsmtpt1750482006t5fhfo8jp
Message-ID: <tencent_9C353B816C34413E5956219DF4E0085AD209@qq.com>
X-QQ-XMAILINFO: MqswyhUqVe0CYKl+MzK9oI2uwf+vFe5qDMG6Tpy7MHejIUE9Q/bHAbIKMW+HnU
+c3e9HbmtLxUhi9WOyts7gYWEsUgdvr2nmQ77AcG9rpzZyR0QjmJsuqBlJW03ba3nlbgLY7yZMDg
iB8A3He7NzYXW2NQGIdqa90ABq8QHzAcIQ99GQLdPba85xZ/AZ+y+lGq2YqbBe/1zU+Q0Vt03Uzc
Ee7CiiwfCSOd0OdnyiP5+Q+18FRRn9CFgvoAI2lfMj2MYvsrLeFufVg3tlurCR4bUJgwNu7mTMIT
tFQqYwirMIKzcK2/P6GVzG6UtlD6NVFcg+Rytdt7KVgLZdg4ILO/O6PjoiUHQU3Hkc3ZlsX/JSkJ
9fZYGJCKOzos5rn0XSCOabEgBjy5WFT5z5qtO10yO+Orc6Qy9QTHJKV4PhoobYwz1JUMOQulsiFh
rLlgIyLvpXzkm8tPn36xBZmTFF0vzkaOhFvyIVOXUAGcvSFyUTEiRkXno4V7Y7GmVoCxzzeqRzAw
bwwgg8g8QY0VhUHFqEYtRyUhwbA3cKnvwqY/YHumUhclaIOiws/M8GBhRN/ZX4RhaX/T2g3EmIt2
uKJMO/+VEdlhcirwamzXwUM/KLftlth1R57y8n3Ns2NZkupI4Nw9CQpZYk4lZ7nhZQEyL+885UXD
FUMWhXWWJTZsLEd+SL0CCgdsgEL42Hw6cU6BpxcxcP71r3g7/QgcaAmhS5fMYXckYZsjUTNtwH8R
NGPGrfYmgLGg0W1fLb0jx676zKg+0pJ24Q+IQSkyacYo7Di+mVHvBkn5x3391fr4GrsOm9wi5Fyr
+ef/hZ2S1ldNuI0F/eKHsI6jYHBla5nbDWHzpOrykIVtSQwJdBNXQ/rcx1kPkrCcOlyU2xNGKMeX
12OO/fAu6Xem0j0Suv8auIHJlyxBGxz4OyIUkx9wdi9t1wz/tUh1TZW8ZJLyC3jHatVB9s9/C302
6+1cUA5sqWDbd1JZLFgKFb1cvvA3CIToQobjbYnzRXC334cLQXChuwlPBt8nCx1GJsxqJwpln3/0
s5e6omrjOrZVZ8Mc7YwO0Hw/zRqyE8Q+ApXczS+A==
X-QQ-XMRINFO: Nq+8W0+stu50PRdwbJxPCL0=
From: Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org>
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\))
Date: Sat, 21 Jun 2025 12:59:56 +0800
References: <mailman.2705.1749547589.1384.ffmpeg-devel@ffmpeg.org>
<718DE16C-E953-49F3-B7CB-6E5949B83D2C@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <718DE16C-E953-49F3-B7CB-6E5949B83D2C@gmail.com>
X-OQ-MSGID: <AA5D86AA-F5B6-407D-98D1-25F0301B63A0@foxmail.com>
X-Mailer: Apple Mail (2.3818.100.11.1.3)
Subject: Re: [FFmpeg-devel] [PATCH] avformat/whip: mark as experimental
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/tencent_9C353B816C34413E5956219DF4E0085AD209@qq.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
> On Jun 21, 2025, at 10:14, Jack Lau <jacklau1222gm-at-gmail.com@ffmpeg.org> wrote:
>
>> On Jun 10, 2025, at 17:26, Jack Lau via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
>>
>>
>> From: Jack Lau <jacklau1222@qq.com>
>> Subject: [PATCH] avformat/whip: mark as experimental
>> Date: June 10, 2025 at 17:26:13 GMT+8
>> To: ffmpeg-devel@ffmpeg.org
>> Cc: Jack Lau <jacklau1222@qq.com>
>>
>>
>> This muxer has been marked AVFMT_EXPERIMENTAL.
>>
>> Add a note in muxers.texi that WHIP is an experimental feature
>>
>> This patch doesn't effect WHIP usage command, as WHIP always
>> needs to be explicitly specified
>>
>> The details as follows:
>> https://ffmpeg.org/pipermail/ffmpeg-devel/2025-June/344705.html
>>
>> Signed-off-by: Jack Lau <jacklau1222@qq.com>
>> ---
>> doc/muxers.texi | 2 ++
>> libavformat/whip.c | 2 +-
>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/doc/muxers.texi b/doc/muxers.texi
>> index 30c95c3d34..d2ee90bf33 100644
>> --- a/doc/muxers.texi
>> +++ b/doc/muxers.texi
>> @@ -3885,6 +3885,8 @@ ffmpeg -f webm_dash_manifest -i video1.webm \
>> WebRTC (Real-Time Communication) muxer that supports sub-second latency streaming according to
>> the WHIP (WebRTC-HTTP ingestion protocol) specification.
>>
>> +This is an experimental feature.
>> +
>> It uses HTTP as a signaling protocol to exchange SDP capabilities and ICE lite candidates. Then,
>> it uses STUN binding requests and responses to establish a session over UDP. Subsequently, it
>> initiates a DTLS handshake to exchange the SRTP encryption keys. Lastly, it splits video and
>> diff --git a/libavformat/whip.c b/libavformat/whip.c
>> index 710f24fc5a..bb7b8657dc 100644
>> --- a/libavformat/whip.c
>> +++ b/libavformat/whip.c
>> @@ -1907,7 +1907,7 @@ const FFOutputFormat ff_whip_muxer = {
>> .p.long_name = NULL_IF_CONFIG_SMALL("WHIP(WebRTC-HTTP ingestion protocol) muxer"),
>> .p.audio_codec = AV_CODEC_ID_OPUS,
>> .p.video_codec = AV_CODEC_ID_H264,
>> - .p.flags = AVFMT_GLOBALHEADER | AVFMT_NOFILE,
>> + .p.flags = AVFMT_GLOBALHEADER | AVFMT_NOFILE | AVFMT_EXPERIMENTAL,
>> .p.priv_class = &whip_muxer_class,
>> .priv_data_size = sizeof(WHIPContext),
>> .init = whip_init,
>> --
>> 2.49.0
> Forgot to tag v4
> PING.
Applied with some modification to commit message, thanks.
>>
>>
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".