Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "\"zhilizhao(赵志立)\"" <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 0/4] Add hevc alpha layer decoding basic support
Date: Thu, 2 Mar 2023 18:41:30 +0800
Message-ID: <tencent_98B8819614CD36206B4DB04FF45560271E07@qq.com> (raw)
In-Reply-To: <167775188986.10789.9007045872540309909@lain.khirnov.net>



> On Mar 2, 2023, at 18:11, Anton Khirnov <anton@khirnov.net> wrote:
> 
> Quoting zhilizhao(赵志立) (2023-02-28 10:00:15)
>> 
>>> On Jan 6, 2023, at 23:52, Zhao Zhili <quinkblack@foxmail.com> wrote:
>>> 
>>> From: Zhao Zhili <zhilizhao@tencent.com>
>>> 
>>> v2:
>>> 1. Check vps_max_layers and vps_max_layer_id inside hevc decoder
>>> 2. Add hevc_extract_layer bsf to do the job rather than modifing hevc_metadata,
>>> 3. Check vps_max_layers_minus1 and vps_max_layer_id inside bsf
>>> 4. Update vps_max_layers_minus1 and vps_max_layer_id when rewrite as base layer
>>> 5. vps_extension should be updated rather than drop entirely, add a TODO
>> 
>> Will push soon if there's no objections.
> 
> Can't we do this without weird bitstream filtes and obscure options
> leaking to the user? It's all signalled in the bitstream in a rather
> straightforward way. Just extend hevcdec to decode it.

Yes we could.

1. Add support to our software decoder is possible, with a big refactor.
2. Add support to hwaccel decoders like videotoolbox requires a refactor of
hevcdec too.

I have asked in the RFC:

"Is there any plan/interesting to add fullly support inside our hevc
decoder? If the answer is yes, then the patchset is less useful."

http://ffmpeg.org/pipermail/ffmpeg-devel/2023-January/305342.html

I indeed tried to refactor hevcdec first. But the mixing of long term
states and temporary states inside HEVCContext makes it not easy to do.
I’m glad to work on it (together) if someone has a clear idea.

By the way, other decoders which doesn’t support layered decoding could
still benefit from the 'weird bitstream filter'.

> 
> -- 
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-03-02 10:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-06 15:52 Zhao Zhili
2023-02-28  9:00 ` "zhilizhao(赵志立)"
2023-03-02 10:11   ` Anton Khirnov
2023-03-02 10:41     ` "zhilizhao(赵志立)" [this message]
2023-03-14 13:30       ` Anton Khirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_98B8819614CD36206B4DB04FF45560271E07@qq.com \
    --to=quinkblack@foxmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git