Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Zhao Zhili <quinkblack@foxmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: admin@shaoxia.xyz
Subject: Re: [FFmpeg-devel] [PATCH] libavformat\file:Fix duplicate JNI symbols
Date: Sun, 24 Mar 2024 12:09:39 +0800
Message-ID: <tencent_988EA225515305684E73E7137F35CC290205@qq.com> (raw)
In-Reply-To: <tencent_12CFD0D534277338B31649CD01A00BCDBB07@qq.com>

On 2024/3/24 10:16, Zhao Zhili wrote:
>
>> diff --git a/libavformat/file.c b/libavformat/file.c
>> index dd5819c..fa13ae9 100644
>> --- a/libavformat/file.c
>> +++ b/libavformat/file.c
>> @@ -43,7 +43,7 @@
>>   #if CONFIG_ANDROID_CONTENT_PROTOCOL
>>   #include <jni.h>
>>   #include "libavcodec/jni.h"
>> -#include "libavcodec/ffjni.c"
>> +#include "libavcodec/ffjni.h"
>>   #endif
> This just break --enable-shared, so NACK.

The following patch should work for static and shared both.

https://ffmpeg.org/pipermail/ffmpeg-devel/2024-March/324138.html


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-03-24  4:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-23 19:05 admin
2024-03-24  2:16 ` Zhao Zhili
2024-03-24  4:09   ` Zhao Zhili [this message]
2024-03-24  5:17 ` [FFmpeg-devel] [PATCH] avcodec, avformat/ffjni: fix " Leo Izen
2024-03-24 13:19   ` Matthieu Bouron
2024-03-24 13:23 ` [FFmpeg-devel] [PATCH] libavformat\file:Fix " Andreas Rheinhardt
2024-03-24 14:59   ` Zhao Zhili

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_988EA225515305684E73E7137F35CC290205@qq.com \
    --to=quinkblack@foxmail.com \
    --cc=admin@shaoxia.xyz \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git