From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E099E47553 for ; Fri, 10 May 2024 08:56:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B8F1E68D4A6; Fri, 10 May 2024 11:56:38 +0300 (EEST) Received: from out162-62-57-49.mail.qq.com (out162-62-57-49.mail.qq.com [162.62.57.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A175A68D3F8 for ; Fri, 10 May 2024 11:56:31 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1715331382; bh=ejMrkHCbDGC5cn573syO6wrYavR5QkRGMggycUqWRs8=; h=From:To:Cc:Subject:Date; b=cfC8OTiBlEvrTngY1FPkJpE2UWJvspy4lnIjNkSqPk8yyef8V6KIh5wLQUavPLCTU pTM5yB7gda6ExmxdGyyFopGaB6LOFomvC61vMML+PKT/yUZrOntPBPNESgVC9gP7ur QgnrojGKsEL9SLdKd2/5DRx0rrWy9D0i3+aFmsYU= Received: from ZHILIZHAO-MB1.tencent.com ([119.147.10.200]) by newxmesmtplogicsvrsza15-1.qq.com (NewEsmtp) with SMTP id E14B9494; Fri, 10 May 2024 16:56:20 +0800 X-QQ-mid: xmsmtpt1715331380t28o3roma Message-ID: X-QQ-XMAILINFO: NMGzQWUSIfvTqcQ1m2OkQzQjyMcfYgIiKwnEXQz+E+dRhfJJt/LJp6EfuKKgvC r4oirjfWG0Op/l5dxx9rqxNgJEn8tg7NBJk0hIWr8CMXDxumph2fBAnjt3r2VHUmAqtRFpu6GOz0 YuM5UsASLHu00C3xMUZsiHsugLc/80iGEOAPJlJGcd4FSRaufIpzgbjmwBcND20Q87DIY6kOBBgR pXFlMTnV2sPZBttVxKg67vKQQUEc5OFMbgEu0vXmo45V3sGZgI1+UsM2tQWXETogKkuqda+eN9TP nY3QahkTRu7n1pl5KEN5bzBcy3K9n4D+M+01YFSJdDa3psXRdk7BFyE4wC0lKqIvj1x0KFVj4JrZ fkvWnAbVlLvNA/DDfJFzRYVbdRhJT3RH8yEf6eywOR+I1APEzhXsthdl1WT/u+8tegSglWPjyjSt Pom1e2y1OItx6BUdNAoZRwbL7fRQGXstVSZN4sC7VBZxejOeW2E/aBUyaJWTyT0X2d7vgkfyWdl4 r9T6CY8hVy8Qi62vk/N/fe5oioZWcH4xUChbbdEdepNZFnn0UPm8bKOUtU8AMQfHFlYurKOGeCE3 PRfPSs52XgGeH1ntkdn1hXUa3e/zKk98Zv1zAvR7/hO5AKsGcL8iCZ+sBScPtMTla9FV3Lruf7UG IoGHTG6XZzEfkoqgbyhGwwZh5L3iOk3smS0HYyDjpU2t93//meZvq+Bdd0IdLWQLRkXyTQphm4zB p8AYnDh4q75nyQpg7H9P/TylgCCmFcluESi3jsaqUKB0wyBpbfJWlLzHMZsWWXP/ppM2gWyLf9WL GQ6JAnQKkI+qCBFrE7Y8oj7rQ1XJiAIIswjGGtkHahUoet//1Shgh4YcSyuNs3RcpXvc4YMlGPaR xru/jIl9LpNKwGBYYjYdqMWKiXTTb/WCq9D2084TxYjl56yZe7HJ+m70iWj7dWDq09n4cXtfS7ds HHZsTwWRUxiMzSj1+ise/sqPNEm4SygpsT9UVmJ1v5KXW3dlx0XuMsk37bn+Au X-QQ-XMRINFO: M/715EihBoGSf6IYSX1iLFg= From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Fri, 10 May 2024 16:56:16 +0800 X-OQ-MSGID: <20240510085616.76622-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avfilter/src_movie: Remove align dimension to fix crash X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Zhao Zhili The alignment is handled by ff_default_get_video_buffer2. We shouldn't use the aligned width/height as FFFramePool width/height. It cause recreate FFFramePool inside ff_default_get_video_buffer2. The recreate of FFFramePool together with multi-threads decoding leading to data race and crash, for example, ./ffplay -f lavfi -i movie=foo.mp4,drawtext=text=bar --- libavfilter/src_movie.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/src_movie.c b/libavfilter/src_movie.c index e2cdcf17db..5099012100 100644 --- a/libavfilter/src_movie.c +++ b/libavfilter/src_movie.c @@ -187,7 +187,6 @@ static int get_buffer(AVCodecContext *avctx, AVFrame *frame, int flags) switch (avctx->codec_type) { case AVMEDIA_TYPE_VIDEO: - avcodec_align_dimensions2(avctx, &w, &h, linesize_align); new = ff_default_get_video_buffer(outlink, w, h); break; case AVMEDIA_TYPE_AUDIO: -- 2.42.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".