From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 200C94F314 for ; Mon, 16 Jun 2025 10:51:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id D4CA268DBD4; Mon, 16 Jun 2025 13:51:39 +0300 (EEST) Received: from out203-205-221-202.mail.qq.com (out203-205-221-202.mail.qq.com [203.205.221.202]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 039E968D867 for ; Mon, 16 Jun 2025 13:51:32 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1750071089; bh=ftnVTsLgIyNvF7HzAFRRpyhvnbWW+f1V1IQGJGrpco8=; h=From:To:Cc:Subject:Date; b=bgEWcHVDFNYUK2KU3hmB4R3GJD+OX1O4hyCw/8RPo7VLzXOKRXWoFmS9oLd6+vN5p 1inlLzxtErJJBSpidSUCcJmQPpBAj56LeAA2N7MO/is8To1Il5y6Yy0Woz+iPm61HY n3hY8nIdDBWxR08XeftnGpKIHqGXLscsCiKLF4iA= Received: from localhost.localdomain ([119.147.10.242]) by newxmesmtplogicsvrszgpuc5-0.qq.com (NewEsmtp) with SMTP id B529C06B; Mon, 16 Jun 2025 18:45:18 +0800 X-QQ-mid: xmsmtpt1750070718tsvcm5dhe Message-ID: X-QQ-XMAILINFO: NX3IH4pixvQAOoEtseQCwJqYCtORkQ5QFl1qWfgTsjYQo7QfzoLNylFZBp0UTl w0d44vzajNbmhRFy4ufUOWc1hx1sLi4P/2+FuHW2XNVECrB5Lvc5wqpxImFJoOJ/AMd7Vs/uwPIo oD8GgbfNyUCZelRZxoP0QbfeC3elt2VBy/Y/KVK1Otb+znodfwGDe8nvzV2SdYmht1oEZ7g7pTuu NH42u608IdiLO7wn4G8/dNPHro+OsmugIDQa63QBtqB5FS5mVdzlBEAaLJPN7/gQnVsqws+aARpI nk2bq5TCA4zlqwRBB8HckYQNL91k2g7zPwRNJtCqLFw3LKDeDtYPwxke06uNIOsPwNGLh80O7fid 8YhX5jvmRp4gZmQMvOGyknAwhrUcSyAhLhS2U0eK8jmTQqzYP8Tw4Nd+9t4/iWIYdHDg6ILu7v/N sCIwNYQ/Lt9IBWT2dRnyqFZuJMGs82x2E63STHQKrci3hSnK9UYfj8yEJ+o4eI1g1nVoZxXAIq4A Rh1OLFYf8Z9aT6h7Q64LduaX+m1F8eQlWAiFfR4SAdEPOHQybj8LT78zBRUoreY+aLFub8X/5Jc5 r/6Zo81MRYGn1vzmn/Df8ydnFMb9ucCr4OTzRhSEfPxwUo4K/WC/SxTZp1wc1mnOTCZZq2goItVq TNPbLm+JIgkulC38UX1sBE4bXS7xqm/AiAtOW9g5f6fmAIs/aB48gybmw1QckfJP8YzuOnvmysNC 1Iq8sv+C5xCaVJZA85F/kQKJMF2moTxipgC/tShIoychOJ926kGoJK299yRDpO7T7GUR97Qk3sro 9jm+hSTJ6ttXFhYYLOzmwVeKbvrfdU3Y47b+URq6K0G4t6JitsIrSIx5t66rD4rCg4fyBqgBALe7 Kj4q2Ebcp+qZ+N7CHkAuXX9DV3jKhzAoLTI8loM8LgHlLjZub9kGST+vJsykZADbJAIlmwbARs54 j8RMwsdGXNVdF1XNHgRGD/EgEFBEFahiF2qUf6oZHbw6Eo8lQ6wpied2MO/nVfSOS0jikP9p15vE wxnnPtsRl12lw+xmtlUAesH/Mx4vhSQWSGVFO5lAHxQPj57Gb2M4fA5kSRZ4GnYqK3KoRiQA== X-QQ-XMRINFO: Mp0Kj//9VHAxr69bL5MkOOs= From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Mon, 16 Jun 2025 18:45:20 +0800 X-OQ-MSGID: <20250616104520.301634-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v5] checkasm/h264dsp: Fix stack overflow in check_idct_dequant X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Zhao Zhili --- tests/checkasm/h264dsp.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/tests/checkasm/h264dsp.c b/tests/checkasm/h264dsp.c index f5f9650224..ecdc347dde 100644 --- a/tests/checkasm/h264dsp.c +++ b/tests/checkasm/h264dsp.c @@ -328,8 +328,9 @@ static void check_idct_multiple(void) static void check_idct_dequant(void) { static const int depths[5] = { 8, 9, 10, 12, 14 }; - LOCAL_ALIGNED_16(int16_t, src, [16]); - /* Ensure dst buffers are large enough to hold dctcoefs of all bit-depths. */ + /* Ensure buffers are large enough to hold dctcoefs of all bit-depths. */ + LOCAL_ALIGNED_16(int16_t, src_buf0, [16]); + LOCAL_ALIGNED_16(int32_t, src_buf1, [16]); LOCAL_ALIGNED_16(uint8_t, dst0, [16 * 16 * sizeof(int32_t)]); LOCAL_ALIGNED_16(uint8_t, dst1, [16 * 16 * sizeof(int32_t)]); int16_t *dst_ref = (int16_t *)dst0; @@ -338,15 +339,23 @@ static void check_idct_dequant(void) int bit_depth, i, qmul; declare_func_emms(AV_CPU_FLAG_MMX | AV_CPU_FLAG_SSE2, void, int16_t *output, int16_t *input, int qmul); - for (int j = 0; j < 16; j++) - src[j] = (rnd() % 512) - 256; - qmul = rnd() % 4096; for (i = 0; i < FF_ARRAY_ELEMS(depths); i++) { + int16_t *src; bit_depth = depths[i]; ff_h264dsp_init(&h, bit_depth, 1); + if (bit_depth == 8) { + src = src_buf0; + for (size_t j = 0; j < 16; j++) + src_buf0[j] = (rnd() % 512) - 256; + } else { + src = (int16_t *)src_buf1; + for (size_t j = 0; j < 16; j++) + src_buf1[j] = (rnd() % (1 << (bit_depth + 1))) - (1 << bit_depth); + } + memset(dst0, 0, 16 * 16 * SIZEOF_COEF); memset(dst1, 0, 16 * 16 * SIZEOF_COEF); -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".