Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/decode: Fix avcodec parameters when bsfs, are enable by decoder"

[Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org>]

> On Jun 15, 2025, at 23:17, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote:
> 
> Zhao Zhili:
>>> Otherwise the extradata used would be ISOBMFF if the input is
>>> even though we use the *_mp4toannexb BSFs to convert it to
>>> annex B to feed it to the actual decoder.
>>> 
>>> (The mediacodec decoders also use said BSFs, yet they process
>>> the extradata in a way that works even when using the ISOBMFF
>>> extradata; in fact, using the converted extradata would break
>>> their check for whether to warn for missing extradata for
>>> the ISOBMFF without-in-band-header profiles.
>>> 
>>> Furthermore, there are several users of the *_mp4toannexb BSFs
>>> that don't ever touch extradata. They have not been touched.)
>> 
>> The solution is fragile and easy to be broken. It doesn’t look like a better
>> solution than avcodec_parameters_to_context.
>> 
> 
> Do you still think this way in light of my reply
> (https://ffmpeg.org/pipermail/ffmpeg-devel/2025-June/344986.html)?
> 

Please apply.

> - Andreas
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".