From: Zhao Zhili <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_blackdetect: Fix header guard
Date: Fri, 18 Jul 2025 19:51:08 +0800
Message-ID: <tencent_8EF60121697A7F62AD8E38D5C0A1B5E4680A@qq.com> (raw)
In-Reply-To: <20250718134543.GC196727@haasn.xyz>
> On Jul 18, 2025, at 19:45, Niklas Haas <ffmpeg@haasn.xyz> wrote:
>
> On Fri, 18 Jul 2025 19:32:42 +0800 Zhao Zhili <quinkblack@foxmail.com> wrote:
>> From: Zhao Zhili <zhilizhao@tencent.com>
>>
>> Fix fate-source failure.
>> ---
>> libavfilter/vf_blackdetect.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavfilter/vf_blackdetect.h b/libavfilter/vf_blackdetect.h
>> index 361da2c5bc..2842084ec3 100644
>> --- a/libavfilter/vf_blackdetect.h
>> +++ b/libavfilter/vf_blackdetect.h
>> @@ -16,8 +16,8 @@
>> * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>> */
>>
>> -#ifndef AVFILTER_VF_BLACKDETECT_H
>> -#define AVFILTER_VF_BLACKDETECT_H
>> +#ifndef AVFILTER_BLACKDETECT_H
>> +#define AVFILTER_BLACKDETECT_H
>>
>> #include <stddef.h>
>> #include <stdint.h>
>
> Should update also the comment on the #endif.
>
> I can do that locally and push the modified commit if you agree.
Yes please.
vf_colordetect has the same issue. It has already been detected by patchwork.
https://patchwork.ffmpeg.org/check/132469/
>
>> --
>> 2.46.0
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-07-18 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 11:32 Zhao Zhili
2025-07-18 11:45 ` Niklas Haas
2025-07-18 11:51 ` Zhao Zhili [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_8EF60121697A7F62AD8E38D5C0A1B5E4680A@qq.com \
--to=quinkblack@foxmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git