From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id E8FB24D31F for ; Mon, 16 Jun 2025 06:37:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 49BF468DA51; Mon, 16 Jun 2025 09:37:27 +0300 (EEST) Received: from out203-205-221-236.mail.qq.com (out203-205-221-236.mail.qq.com [203.205.221.236]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 61A3A68CA6A for ; Mon, 16 Jun 2025 09:37:19 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1750055830; bh=6UoZJ82/Wzt6shHWCRctWadAHySqDTS47CLdyuXEUGU=; h=From:To:Cc:Subject:Date; b=lqVfSbcfzEKbKwEh/UPZHF19DZvyomoYILtLRuxVgtVCkHFfaaoetWhEU8uA/0Atc OIs7UltBFnHS5YE9OpbWkKVHJZyWuK4UIuVn4G0SOmZrcXFkTif7RFDjDLM8oH0TcW G1RY3CQIkNLml32fXcDczj/l67VZlx8OyX4XtbLY= Received: from localhost.localdomain ([119.147.10.242]) by newxmesmtplogicsvrszb16-1.qq.com (NewEsmtp) with SMTP id 94917411; Mon, 16 Jun 2025 14:37:09 +0800 X-QQ-mid: xmsmtpt1750055829tz19dh85s Message-ID: X-QQ-XMAILINFO: NhpLzBn2I3Xw9D3UM+r3BYfycW6skgMn8AvHXpr20ryTdj6xkpMggwlMiJYbiE Xyezkt+7WeQT8JlAMFpIw3FlGoLEUfSjx0JtWHtZni7HW1bzkSxIMjVORoFIHoPzXeEYxx9ygrYP o1SfDPP4cWf9h/NsRgg6tESo5RsNt2lg4/80Mx/lTW07vKLqrbQbmSpbATL42fffZd3aV1/ILFHG jHQas2IqwTyXrAkyclvNqNpMYVWqticA8mFjIo5sd0z6OC1s1feuVyJtFSNxjXC4CK4xP3C0av3N hIwg+qSBJG346+ZsO8z4rCa/FSF71De6rzLnOwP/7myDsKqL/1Jc9Wdhwbj5zbZH2REYkYktFJUw JGBopWUIaeZIDHAv8P+H98U8AcCZWdpTtNX3I3ig6iLVmNKkFo33VAledkpA5qE+mJjcaURCl3oV mmbUTX8RiigdeUQ6f163vsFquXy8Nusf+AtVUU4UzlQ4uunJuHGaC5HX8IXY1gKbdwS5nhBh1ek7 jZgwwDLbTfAJc0eCVhj3yYjM4AFnHsdkJYFXyFQBdUyYmdpBpSNJa8lS3vJozwQfXabn6Z6/Ld8v wO/kxo73j3eZJdkz5iVHPuiM70MVxZ2JmL65WDdkFymekYvshYZTGFCYRamzvTxljaNCQYKXpKCJ uSDdK57JaBvfnTZsk45DlxuC5nzBogLPwNCZJt9/K/HHr/JFbzSRzqx5zBR3Q8FJxgsbyvsaQZMj baCaqti6FUpWj6K+mk/RISrjW1xU/cw0oHNQ0NVUC9HJ+dM9+e2bXcOQYsPJi03KjAGoM/R3FN/F UKMKQlyKAHyBdjN4bmJRqmH8y3BYSH15E7YK+YnmfbiLYmtfNAGK4cVdyll0p32dp+GG+iXYHpaJ XfTBC3r7C4F/xFX+Q/P1iJI+r/DlvW/R0LCanDdXiKOdU6OZrnNuZu6hQVzGNQzUvurmV+UMOuux TTtUK1EmU3xAY0IggcjgIYSboSeht0jtvrWTNrjGfhO9aDJOJS6w== X-QQ-XMRINFO: MSVp+SPm3vtS1Vd6Y4Mggwc= From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Mon, 16 Jun 2025 14:37:10 +0800 X-OQ-MSGID: <20250616063710.290579-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] checkasm/h264dsp: Fix stack overflow in check_idct_dequant X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Zhao Zhili --- tests/checkasm/h264dsp.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/tests/checkasm/h264dsp.c b/tests/checkasm/h264dsp.c index f5f9650224..006532e08b 100644 --- a/tests/checkasm/h264dsp.c +++ b/tests/checkasm/h264dsp.c @@ -328,7 +328,7 @@ static void check_idct_multiple(void) static void check_idct_dequant(void) { static const int depths[5] = { 8, 9, 10, 12, 14 }; - LOCAL_ALIGNED_16(int16_t, src, [16]); + LOCAL_ALIGNED_16(int16_t, src, [16 * 2]); /* Ensure dst buffers are large enough to hold dctcoefs of all bit-depths. */ LOCAL_ALIGNED_16(uint8_t, dst0, [16 * 16 * sizeof(int32_t)]); LOCAL_ALIGNED_16(uint8_t, dst1, [16 * 16 * sizeof(int32_t)]); @@ -338,15 +338,21 @@ static void check_idct_dequant(void) int bit_depth, i, qmul; declare_func_emms(AV_CPU_FLAG_MMX | AV_CPU_FLAG_SSE2, void, int16_t *output, int16_t *input, int qmul); - for (int j = 0; j < 16; j++) - src[j] = (rnd() % 512) - 256; - qmul = rnd() % 4096; for (i = 0; i < FF_ARRAY_ELEMS(depths); i++) { bit_depth = depths[i]; ff_h264dsp_init(&h, bit_depth, 1); + if (bit_depth == 8) { + for (int j = 0; j < 16; j++) + src[j] = (rnd() % 512) - 256; + } else { + int32_t *p = (int32_t *)src; + for (int j = 0; j < 16; j++) + p[j] = (rnd() % (1 << (bit_depth + 1))) - (1 << bit_depth); + } + memset(dst0, 0, 16 * 16 * SIZEOF_COEF); memset(dst1, 0, 16 * 16 * SIZEOF_COEF); -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".