Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "\"zhilizhao(赵志立)\"" <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 01/10] avformat/hls: fix repeated requests for media init section
Date: Tue, 12 Apr 2022 21:29:34 +0800
Message-ID: <tencent_8D262AD08066D767D82A82531C1C5E0B8406@qq.com> (raw)
In-Reply-To: <tencent_F2E7E2AAAD131B9C580BA1A633509CE6EB06@qq.com>



> On Apr 12, 2022, at 9:26 PM, zhilizhao(赵志立) <quinkblack@foxmail.com> wrote:
> 
> 
> 
>> On Apr 12, 2022, at 7:45 PM, mypopy@gmail.com wrote:
>> 
>> On Tue, Apr 12, 2022 at 4:15 PM Zhao Zhili <quinkblack@foxmail.com> wrote:
>>> 
>>> ---
>>> libavformat/hls.c | 59 ++++++++++++++++++++++++++++++++---------------
>>> 1 file changed, 40 insertions(+), 19 deletions(-)
>>> 
>> Can these patches handle multiple instances of the media init sections?
> 
> Before and after the patch, struct playlist do take multiple media
> initialization sections into consideration. However, I think it doesn’t
> work for HLS as a whole. To support multiple media init sections, it
> needs to handle EXT-X-DISCONTINUITY and recreate mp4 demuxer.
> 
> So even if new media init section is show up, it will be downloaded and
> then dropped by mp4 muxer:

I mean mp4 demuxer.

> ```
>    if (c->found_moov) {
>        av_log(c->fc, AV_LOG_WARNING, "Found duplicated MOOV Atom. Skipped it\n");
>        avio_skip(pb, atom.size);
>        return 0;
>    }
> ```
> 
> What the patch does is to avoid downloading the same init sections again
> and again, and then dropped by mp4 muxer. It’s common to have init section
> repeat in live mode.

Ditto.

> 
> Just for reference, hls.js had the same issue, and have been fixed by
> 
> https://github.com/video-dev/hls.js/pull/4452
> 
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> 
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2022-04-12 13:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12  8:15 Zhao Zhili
2022-04-12 11:45 ` mypopy
2022-04-12 13:26   ` "zhilizhao(赵志立)"
2022-04-12 13:29     ` "zhilizhao(赵志立)" [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_8D262AD08066D767D82A82531C1C5E0B8406@qq.com \
    --to=quinkblack@foxmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git