From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id E97DC4BA74 for ; Tue, 22 Jul 2025 17:24:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id C5B5468D20D; Tue, 22 Jul 2025 20:24:31 +0300 (EEST) Received: from xmbghk7.mail.qq.com (xmbghk7.mail.qq.com [43.163.128.54]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 5B22468CFAD for ; Tue, 22 Jul 2025 20:24:23 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1753205061; bh=aGCeWDsK6xYo79tHwLwrMlxzrHtu+P7LT5Ozj9WSCoY=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=PXKtXTxWk0TDNT5oNlQlaRWGOn6SHxoW71q/+97AmGL28V8dJJkswxfXaG4SldzCx XqLIwSi4IMR/NkL5bi1ci6OL6WQTuUTT5TfG6vBA5T1f5mSExrnnJs+NRFwR6/Wm4L RJxhFe0dLx6pfpET4FSamP5vV5xt/3vy6obyH9yo= Received: from smtpclient.apple ([240e:3b7:3270:9130:5c8e:9e35:a305:fa8c]) by newxmesmtplogicsvrszb16-1.qq.com (NewEsmtp) with SMTP id 48D920F9; Wed, 23 Jul 2025 01:18:13 +0800 X-QQ-mid: xmsmtpt1753204693tbl81pmmw Message-ID: X-QQ-XMAILINFO: OVFdYp27KdlJ2/TMKuBAcBoPz+8eW5Hh7onKfIIyrqC4G1h2LFJII36NKiJ8YM +SR8qp69pcA5zMYwLl7a7Yaw0cSzjS8t8h0nTA+RPU15k5QGVrBWaxhRUOw1sH0SyJZqsehAL+TF cIILLOeUS2O+7xtxqdXy5GhLClkcFOfu4dC4syybk0LAc8OOAl//7e3S5bqE+NRCNt0px9eYomGH WQktlZv9/lfDD3d1ezt7ozChXHDoLaXeUXuxtGqrx/cDUkPv4SQTkPNr+SE7tPrKUffr2DSW9iGA A+aXbpb5LlN+BXo2A7PLY7+RHYW7RVDGGpx7NSbwXIVtn2c9pwQAmVuQRaEl6gi7Jgfgiw9O/UD6 qT7WMi+RQDITNBMBzHQRfyGgrSqfuXD+EH7RSnLQ8aAl4fzeIS7i3DfRwa5bYKQdPBNkngJUrHHp 4sYHYds5yWTHGdediywiEF7oyQGkAJOH5YhkIXACAx9H6jca9Vbl6e5qJLALZXy7fGadGScHWQwL 2O3R81HpT5FrTYpq4ZGwbQsvmbyfyj5I29oVsFPw0fXfZmF/iP4LLhRWkoClg+QFIo69y5kvRwqA vulYKUAqTlckhhfoQYASZdtwvL4JXAduwpIt+5EH6NoCPDtQFFmTgg8fOV8LNSdXRaiJy1yFU+Ai AbGpN0s7pW9p1E9NwdI+U4dt0XUA4tez9C8MECvVMKY4/nfOJOvSY1QCDa9EWTk0Ya+twS8DEce7 NtNkEXDJfVMiaIb+StfRJplgv0fN/eREqlNNv6a07mwtZ5pJA5q/2vIcF9JWFU/0lKT2nVoylrjc EtbtjSMsVLscAMakurMPgEvKjMkzh9ItpqSiVROmXxMFuKBAjXIgDy/IPZqoEetPTEmv9oQII/LK qqkeZRK0SGfkTnqSBMgmyafIbNW0tgj/vzyv0rsBc1I1WjEXGdY2ZSGKNQKFUIn5PCQ9GwPAnkwx kw07E0gCKAv/euHLIUGIVbM+9yXHHUd68amYIqDBJRq0KAWVAaVIuoDwzcV49rn8k4D/xFb9VAaK b4I8aPmXGBOvZ8h8Kp+vPYxrf9Y7tVu+0VCt4R0ay4GyH4zWp7 X-QQ-XMRINFO: MSVp+SPm3vtS1Vd6Y4Mggwc= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\)) From: Zhao Zhili In-Reply-To: <20250722124552.885-1-15083277223@163.com> Date: Wed, 23 Jul 2025 01:17:56 +0800 X-OQ-MSGID: References: <20250722124552.885-1-15083277223@163.com> To: FFmpeg development discussions and patches X-Mailer: Apple Mail (2.3818.100.11.1.3) Subject: Re: [FFmpeg-devel] [PATCH 1/1] libavformat/mov.c : rm 'statement will never be executed' warning X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: zhaozhenghang <15083277223@163.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Jul 22, 2025, at 20:45, zhaozhenghang <15083277223@163.com> wrote: > > In my development scenario, CONFIG_H261_DECODER, CONFIG_H263_DECODER, and CONFIG_MPEG4_DECODER are set to 0 by default, resulting in a "statement will never be executed" warning during compilation. To enhance code robustness, this patch fixes the warning. > > Signed-off-by: zhaozhenghang <15083277223@163.com> > --- > libavformat/mov.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index ccaa988e4b..4a4641d51b 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -5222,6 +5222,7 @@ static int mov_read_trak(MOVContext *c, AVIOContext *pb, MOVAtom atom) > return ret; > } > > +#if CONFIG_H261_DECODER || CONFIG_H263_DECODER || CONFIG_MPEG4_DECODER > switch (st->codecpar->codec_id) { > #if CONFIG_H261_DECODER > case AV_CODEC_ID_H261: > @@ -5236,7 +5237,7 @@ static int mov_read_trak(MOVContext *c, AVIOContext *pb, MOVAtom atom) > st->codecpar->height= 0; > break; > } > - > +#endif I prefer remove the conditional compile inside the switch. > // If the duration of the mp3 packets is not constant, then they could need a parser > if (st->codecpar->codec_id == AV_CODEC_ID_MP3 > && sc->time_scale == st->codecpar->sample_rate) { > -- > 2.50.1.windows.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".