From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DAD7142104 for ; Thu, 28 Apr 2022 11:21:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B3D3F68B39E; Thu, 28 Apr 2022 14:21:50 +0300 (EEST) Received: from out162-62-57-252.mail.qq.com (out162-62-57-252.mail.qq.com [162.62.57.252]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3D30D68B0F6 for ; Thu, 28 Apr 2022 14:21:43 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1651144898; bh=MbwmBoinJpGIWd0dUapboNi3/K+q/dCk1WVO44j96do=; h=From:Subject:Date:References:To:In-Reply-To; b=xeKEe5hlidWgAhSzQ5eBjYafPEK7k7bBdjzrEvflVIELuzdiLOtmXFiJgDuJojAdp c0OhTMZvRbZ9VELA34hWcWht3VcF/vrHAlS0eXI94C4BWFfHo7ZxBabGy2PuFayDqB l9AO1Q+rwebHL5vCLUGcif9i752YSiC2Eny051BI= Received: from [192.168.255.10] ([113.108.77.72]) by newxmesmtplogicsvrszb7.qq.com (NewEsmtp) with SMTP id 5659600A; Thu, 28 Apr 2022 19:21:37 +0800 X-QQ-mid: xmsmtpt1651144897tizq4rg8j Message-ID: X-QQ-XMAILINFO: OOPJ7pYMv25tiRK63E7hwxsAmALoED+Lx6vvED/MgdYZUwoPrHlhVz3gjU/ET7 NJT2SOIcq4kKj3AUYdvdlpys+XGCxwvbzYY48L3lq6K2A3/wWP2hAU3L5XmJwFzCO+qa9v7Ztt7j lVRfpkHVMrRDizC4iR1BQcHpAx86bfKgx4Vzw/ujYtCLZVeNqiU7XQwCKWFLHNN5YvPIpNzP2578 Km+pZk9lxe3/Zthey5ex9SpKsMyezJkRj3xYcQt/2VbuCIW9yWt9rfxiaNgqKYvpl0XtDKjA6+Jr kDPsEA3LGnvbcxFLIiKI/YbqZ9ngltPs424/HGMlPZkw8SSfHS/lRfkTgxbgCQ0cj5KlVJEX1Znv b+t6mviobfKcIQ0z2arDdZBEccrEBbhD17AKeNV+U2lUn1TIsNWvVmzKYObII39WOGJJThRe6TnA LnwH+YQGwKdu9769uTTFGp09CChWU0UUpO1v56RukZqKhPTBKEJGUzqnVLSvEEPUhdB9LuFXTDFk FRNM93CVcyX67Pgv6uQdsRyjR9iJLeoZlifi3MsTjEQ39rC4kE6FMQ3NeNX4k6/dSZ3DBx6gt8Ns VeIdIIxr82icfIzE0V8CHAhtgCgqGiJVqlPt4XXemTIRLXwBGSjX1V5aQEIQFUzoHgHrN/VIFF6u 812kKWkfwqxl89RIdpRTIt6HdP5e3c4pDqTtI8tElHDiEe2tk52fKA8GX40OmoIwcYZgsT795VFx LpnU1AtY+3xcMr+2juFFVB/4+KLuZcLx8Rlf1p3Cr6jCACmKXoGBzVKaHHbCYkNf5QO1FVtftemj iJaNxtdNA6dzhb0rvUNYL75Tv7c81z1GQ6BZJRen/lflWmI6MwJT3I7qWQ0FJ8Yr+Yi+sbNKD59T 9MWOSqyycNfABCOkKwDOMKILScZkn2dlq3nFm95DyP/guu4rp26wRjNzotb+zr7w== From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Thu, 28 Apr 2022 19:21:37 +0800 References: <20220329045053.35358-1-quinkblack@foxmail.com> To: FFmpeg development discussions and patches In-Reply-To: X-OQ-MSGID: <13C32CE5-2D49-4797-AE82-01715F8FE070@foxmail.com> X-Mailer: Apple Mail (2.3654.60.0.2.21) Subject: Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/movenc: sidx earliest_presentation_time is applied after editlist X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Mar 29, 2022, at 12:50 PM, Zhao Zhili wrote: > > Fix #8334 > --- > libavformat/movenc.c | 6 +++++- > tests/ref/fate/movenc | 10 +++++----- > 2 files changed, 10 insertions(+), 6 deletions(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index 46d66c29c2..079fc70d4a 100644 > --- a/libavformat/movenc.c > +++ b/libavformat/movenc.c > @@ -4753,7 +4753,8 @@ static int mov_write_sidx_tag(AVIOContext *pb, > > if (track->entry) { > entries = 1; > - presentation_time = track->cluster[0].dts + track->cluster[0].cts; > + presentation_time = track->cluster[0].dts + track->cluster[0].cts - > + track->start_dts - track->start_cts; > duration = track->end_pts - > (track->cluster[0].dts + track->cluster[0].cts); > starts_with_SAP = track->cluster[0].flags & MOV_SYNC_SAMPLE; > @@ -4768,6 +4769,9 @@ static int mov_write_sidx_tag(AVIOContext *pb, > if (entries <= 0) > return 0; > presentation_time = track->frag_info[0].time; > + /* presentation_time <= 0 is handled by mov_add_tfra_entries() */ > + if (presentation_time > 0) > + presentation_time -= track->start_dts + track->start_cts; > } > > avio_wb32(pb, 0); /* size */ Will apply tomorrow. The issue in ticket 8334 has been hidden by the use_tfdt flag, which ignored sidx timestamp. The real issue is in mp4 muxer. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".