[FFmpeg-devel] [PATCH v2 3/8] avformat/mov: base the endianness on just the LSB

From: Zhao Zhili <quinkblack@foxmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: "Jan Ekström" <jeebjp@gmail.com>
Subject: [FFmpeg-devel] [PATCH v2 3/8] avformat/mov: base the endianness on just the LSB
Date: Sat, 25 Feb 2023 02:28:44 +0800
Message-ID: <tencent_8B4545130C684773FD936F95D1890F0EBB05@qq.com> (raw)
In-Reply-To: <20230224182849.426345-1-quinkblack@foxmail.com>

From: Jan Ekström <jeebjp@gmail.com>

As per 23003-5:2020, the rest of the bits are reserved, and thus
in the future they may be utilized for something else.

Quote:
format_flags is a field of flags that modify the default PCM sample format.
Undefined flags are reserved and shall be zero. The following flag is defined:
  0x01 indicates little-endian format. If not present, big-endian format is used.
---
 libavformat/mov.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/mov.c b/libavformat/mov.c
index cdd44a9e44..a9911c0f79 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -1608,7 +1608,7 @@ static int mov_read_pcmc(MOVContext *c, AVIOContext *pb, MOVAtom atom)
     }
 
     format_flags = avio_r8(pb);
-    if (format_flags == 1) // indicates little-endian format. If not present, big-endian format is used
+    if (format_flags & 1) // indicates little-endian format. If not present, big-endian format is used
         set_last_stream_little_endian(c->fc);
 
     return 0;
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
