From: "\"zhilizhao(赵志立)\"" <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: 徐福隆 <839789740@qq.com>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: add low-latency encoding
Date: Fri, 19 May 2023 11:34:34 +0800
Message-ID: <tencent_89E0705B0E34F9812834933F61560B9DBC09@qq.com> (raw)
In-Reply-To: <tencent_B0D12DCB0981661FC678313A81AF67A7E60A@qq.com>
> On May 19, 2023, at 11:17, xufuji456 <839789740@qq.com> wrote:
>
> When using low-latency mode, it eliminates frame reordering
> and follows a one-in-one-out encoding mode
>
> Signed-off-by: xufuji456 <839789740@qq.com>
> ---
> libavcodec/videotoolboxenc.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
> index c6f22723d6..ae1ef32b2d 100644
> --- a/libavcodec/videotoolboxenc.c
> +++ b/libavcodec/videotoolboxenc.c
> @@ -1441,6 +1441,17 @@ static int vtenc_create_encoder(AVCodecContext *avctx,
> }
> }
>
> + // low-latency mode: eliminate frame reordering, follow a one-in-one-out encoding mode
> + if ((avctx->flags & AV_CODEC_FLAG_LOW_DELAY) && avctx->codec_id == AV_CODEC_ID_H264) {
> + status = VTSessionSetProperty(vtctx->session,
> + kVTVideoEncoderSpecification_EnableLowLatencyRateControl,
> + kCFBooleanTrue);
Please use compat_keys in case of kVTVideoEncoderSpecification_EnableLowLatencyRateControl
isn’t available.
> +
> + if (status) {
> + av_log(avctx, AV_LOG_ERROR, "Error setting low latency property: %d\n", status);
> + }
> + }
> +
> status = VTCompressionSessionPrepareToEncodeFrames(vtctx->session);
> if (status) {
> av_log(avctx, AV_LOG_ERROR, "Error: cannot prepare encoder: %d\n", status);
> --
> 2.32.0 (Apple Git-132)
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-05-19 3:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 3:17 xufuji456
2023-05-19 3:34 ` "zhilizhao(赵志立)" [this message]
2023-05-19 5:55 ` [FFmpeg-devel] =?gb18030?b?u9i4tKO6ICBbUEFUQ0hdIGF2Y29kZWMvdmlk?= =?gb18030?q?eotoolboxenc=3A_add_low-latency_encoding?= =?gb18030?B?0Oy4o8Kh?=
2023-05-19 13:36 ` [FFmpeg-devel] 回复: [PATCH] avcodec/videotoolboxenc: add low-latency encoding Rick Kern
2023-05-19 18:05 ` Zhao Zhili
2023-05-20 15:00 ` Rick Kern
2023-05-20 16:54 ` Zhao Zhili
-- strict thread matches above, loose matches on Subject: below --
2023-05-19 6:05 [FFmpeg-devel] " xufuji456
2023-05-18 10:15 xufuji456
2023-05-18 11:36 ` James Almer
2023-05-19 1:57 ` =?gb18030?B?0Oy4o8Kh?=
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_89E0705B0E34F9812834933F61560B9DBC09@qq.com \
--to=quinkblack@foxmail.com \
--cc=839789740@qq.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git