From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 68B634CCE0 for ; Tue, 25 Feb 2025 02:38:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0EB4768C6B5; Tue, 25 Feb 2025 04:38:48 +0200 (EET) Received: from out203-205-221-205.mail.qq.com (out203-205-221-205.mail.qq.com [203.205.221.205]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E31EF68BE7A for ; Tue, 25 Feb 2025 04:38:39 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1740451114; bh=DVq8BV1KaAB5OSEMINfTqIDCfxXOmm0NkievsqMs8Xw=; h=From:Subject:Date:References:To:In-Reply-To; b=Z6ZHlnpOWPLnN9EzrIA9Rcb0Ff+A+teQyon0/D5YmLfc+f1y3pIoRARXdFsOLPkUp L53/bPw4GoGTvG87GFxpeHAubg0fUM9rFVugrr6lyBeYRxSHSwe7BnaK31qn/MSeQd 07bBWs+7E93yJ8MH5nA6T4mp2p2XvZBT6lYwe4tc= Received: from smtpclient.apple ([119.147.10.242]) by newxmesmtplogicsvrszc13-0.qq.com (NewEsmtp) with SMTP id 9A129AB0; Tue, 25 Feb 2025 10:38:33 +0800 X-QQ-mid: xmsmtpt1740451113t8h2z612k Message-ID: X-QQ-XMAILINFO: MBhxx2BUoWsxcTQPYrPaQB+fSPvomIpBChAr3IpFMnpeYU3ztdC8eTEP0U1btr YqCSlUb7ZHKQn6N80ocNXwXTORybusnyPZjXqikDLCc65FHX4livJiQgnS2bNwzhbx1X9p3XIOs9 a4OeR+FrrJPvlzl+xFQsZZsHrCf8OyC1VDS+2MskvO4+/07NzlniErOw34pjTqE5lpuw0w/2wz26 LqeIKOEPoHFpQy52i0YYbSeiiKJ1yj//ugguNawe2avUXkJMdExpHleUNPpJ3fia1FNnscOXdCW2 D7QtxHUmxM5rNUKyuMKskgXQh/ugXWGfJYpWi1JPIEyflNgB9oyWlxquJnNcdXMY/M0E6l66lcCW 4HgUO1uLC3aaZvxpIFk51iEQb682YVn1SL/CTnFGLFXAqb/3omUb7DM1Lyx/nRdPr6eLvt573Q+3 zKx8b10Tre98Pdo3j/aaJRO3VWftpFa2jyqg8CeK83YZ8QAE0nyzeZ47Ak8d2nuq1kcduOGgYneF +Fgwp5hGgbSmFoi3FfwgTZwBDBl71E0Nw/2EhW8ZjNBP2kaz1csRigVVMn6kBaZ5CnuoDqaQ90oT uAVSScqgfGiJG2vbfzaJKbLE8/OuCANTdVAeyK8NQawY4Q+j9pDaIPiAS2CH3kmMkrYkiTDzXz/k c5aeCt6KyNeI8tZRmVBOdIXOwr9DUzfWmf+vyhI/OV3EDz1OJF4Onuto+JYl9TDadt7XWYBBgWB5 ILXBuE4ayvYVJaB+eHPDCM3rimdJAqSdl+mdJCgK1Sm9tAT1Lx76MYVLZ2UpayzxA3zoQNq7PTEr G4bZIUpbwN8HXghE8IxaIJ3e+XEWMZeXG3IjpXnWrBqE0nHH5xG2YVH9x46/nc8aaZz4QCk3l86m iEpbnVqHp6HnH/EeduvAngFfg3QZY+89OhOkILgmiuMhY9G4wyoYXD7pld2uM6yxV05+iNaOQR+Z fraeit291sMHH9xqqjiHfxoYjnkb7YM6t9U6sPiJI= X-QQ-XMRINFO: Mp0Kj//9VHAxr69bL5MkOOs= From: Zhao Zhili Content-Type: multipart/mixed; boundary="Apple-Mail=_28AB7533-1ED3-4AA6-8177-40DFF44E89CA" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\)) Date: Tue, 25 Feb 2025 10:38:23 +0800 References: <20250224175244.GY4991@pb2> To: FFmpeg development discussions and patches In-Reply-To: <20250224175244.GY4991@pb2> X-OQ-MSGID: <52701CFD-EC4D-42F8-962E-1E92553A2396@foxmail.com> X-Mailer: Apple Mail (2.3818.100.11.1.3) Subject: Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/movenc: Add AVS3 support X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --Apple-Mail=_28AB7533-1ED3-4AA6-8177-40DFF44E89CA Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Feb 25, 2025, at 01:52, Michael Niedermayer = wrote: >=20 > On Mon, Feb 24, 2025 at 09:51:32PM +0800, Zhao Zhili wrote: >> From: Zhao Zhili >>=20 >> 'avs3' is registered at mp4ra.org. The Avs3ConfigurationBox 'av3c' >> inside 'avs3' hasn't been registered yet, but is specified by the >> AVS3 spec. >> --- >> libavformat/movenc.c | 35 +++++++++++++++++++++++++++++++++++ >> 1 file changed, 35 insertions(+) >=20 > theres something wierd with this mails character set, i cant apply = this patch: > "error: cannot convert from y to UTF-8" Download from patchwork and git am has no problem. Maybe it=E2=80=99s = the character in the comments which is copied from the spec. I have updated the = comments in the attachment. +/* AVS3 Intelligent Media Coding + * Information Technology - Intelligent Media Coding + * Part 6: Intelligent Media Format + */ --Apple-Mail=_28AB7533-1ED3-4AA6-8177-40DFF44E89CA Content-Disposition: attachment; filename=0001-avformat-movenc-Add-AVS3-support.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-avformat-movenc-Add-AVS3-support.patch" Content-Transfer-Encoding: quoted-printable =46rom=20997e86a4a533c87b6e5dfa20a84d08a742a27fd2=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Zhao=20Zhili=20=0ADate:=20= Tue,=2018=20Feb=202025=2019:24:48=20+0800=0ASubject:=20[PATCH=20v3=20= 1/3]=20avformat/movenc:=20Add=20AVS3=20support=0A=0A'avs3'=20is=20= registered=20at=20mp4ra.org.=20The=20Avs3ConfigurationBox=20'av3c'=0A= inside=20'avs3'=20hasn't=20been=20registered=20yet,=20but=20is=20= specified=20by=20the=0AAVS3=20spec.=0A---=0A=20libavformat/movenc.c=20|=20= 36=20++++++++++++++++++++++++++++++++++++=0A=201=20file=20changed,=2036=20= insertions(+)=0A=0Adiff=20--git=20a/libavformat/movenc.c=20= b/libavformat/movenc.c=0Aindex=2076dce9e6e5..af013e1fc6=20100644=0A---=20= a/libavformat/movenc.c=0A+++=20b/libavformat/movenc.c=0A@@=20-1540,6=20= +1540,38=20@@=20static=20int=20mov_write_avcc_tag(AVIOContext=20*pb,=20= MOVTrack=20*track)=0A=20=20=20=20=20return=20update_size(pb,=20pos);=0A=20= }=0A=20=0A+/*=20AVS3=20Intelligent=20Media=20Coding=0A+=20*=20= Information=20Technology=20-=20Intelligent=20Media=20Coding=0A+=20*=20= Part=206:=20Intelligent=20Media=20Format=0A+=20*/=0A+static=20int=20= mov_write_av3c(AVIOContext=20*pb,=20const=20uint8_t=20*data,=20int=20= len)=0A+{=0A+=20=20=20=20if=20(len=20<=204)=0A+=20=20=20=20=20=20=20=20= return=20AVERROR_INVALIDDATA;=0A+=0A+=20=20=20=20if=20(data[0]=20=3D=3D=20= 1)=20{=0A+=20=20=20=20=20=20=20=20//=20In=20= Avs3DecoderConfigurationRecord=20format=0A+=20=20=20=20=20=20=20=20= avio_write(pb,=20data,=20len);=0A+=20=20=20=20=20=20=20=20return=200;=0A= +=20=20=20=20}=0A+=0A+=20=20=20=20avio_w8(pb,=201);=20=20=20=20=20=20=20=20= =20=20=20=20=20//=20version=0A+=20=20=20=20avio_wb16(pb,=20len);=20=20=20= =20=20=20=20=20=20//=20sequence_header_length=0A+=20=20=20=20= avio_write(pb,=20data,=20len);=20=20//=20sequence_header=0A+=20=20=20=20= avio_w8(pb,=200xFC);=20=20=20=20=20=20=20=20=20=20//=20Only=20support=20= library_dependency_idc=20=3D=200=0A+=0A+=20=20=20=20return=200;=0A+}=0A+=0A= +static=20int=20mov_write_av3c_tag(AVIOContext=20*pb,=20MOVTrack=20= *track)=0A+{=0A+=20=20=20=20int64_t=20pos=20=3D=20avio_tell(pb);=0A+=20=20= =20=20avio_wb32(pb,=200);=0A+=20=20=20=20ffio_wfourcc(pb,=20"av3c");=0A+=20= =20=20=20mov_write_av3c(pb,=20track->vos_data,=20track->vos_len);=0A+=20=20= =20=20return=20update_size(pb,=20pos);=0A+}=0A+=0A=20static=20int=20= mov_write_vpcc_tag(AVFormatContext=20*s,=20AVIOContext=20*pb,=20MOVTrack=20= *track)=0A=20{=0A=20=20=20=20=20int64_t=20pos=20=3D=20avio_tell(pb);=0A= @@=20-2738,6=20+2770,8=20@@=20static=20int=20= mov_write_video_tag(AVFormatContext=20*s,=20AVIOContext=20*pb,=20= MOVMuxContex=0A=20=20=20=20=20}=20else=20if=20(track->par->codec_id=20=3D=3D= =20AV_CODEC_ID_R10K)=20{=0A=20=20=20=20=20=20=20=20=20if=20= (track->par->codec_tag=20=3D=3D=20MKTAG('R','1','0','k'))=0A=20=20=20=20=20= =20=20=20=20=20=20=20=20mov_write_dpxe_tag(pb,=20track);=0A+=20=20=20=20= }=20else=20if=20(track->par->codec_id=20=3D=3D=20AV_CODEC_ID_AVS3)=20{=0A= +=20=20=20=20=20=20=20=20mov_write_av3c_tag(pb,=20track);=0A=20=20=20=20=20= }=20else=20if=20(track->vos_len=20>=200)=0A=20=20=20=20=20=20=20=20=20= mov_write_glbl_tag(pb,=20track);=0A=20=0A@@=20-8646,6=20+8680,8=20@@=20= static=20const=20AVCodecTag=20codec_mp4_tags[]=20=3D=20{=0A=20=20=20=20=20= {=20AV_CODEC_ID_PCM_F64BE,=20=20=20=20=20=20=20MOV_MP4_FPCM_TAG=20=20=20=20= =20=20=20=20=20=20},=0A=20=20=20=20=20{=20AV_CODEC_ID_PCM_F64LE,=20=20=20= =20=20=20=20MOV_MP4_FPCM_TAG=20=20=20=20=20=20=20=20=20=20},=0A=20=0A+=20= =20=20=20{=20AV_CODEC_ID_AVS3,=20=20=20=20=20=20=20=20=20=20=20=20= MKTAG('a',=20'v',=20's',=20'3')=20},=0A+=0A=20=20=20=20=20{=20= AV_CODEC_ID_NONE,=20=20=20=20=20=20=20=20=20=20=20=20=20=20=200=20},=0A=20= };=0A=20#if=20CONFIG_MP4_MUXER=20||=20CONFIG_PSP_MUXER=0A--=20=0A2.46.0=0A= =0A= --Apple-Mail=_28AB7533-1ED3-4AA6-8177-40DFF44E89CA Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > If a bugfix only changes things apparently unrelated to the bug with no > further explanation, that is a good sign that the bugfix is wrong. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --Apple-Mail=_28AB7533-1ED3-4AA6-8177-40DFF44E89CA Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --Apple-Mail=_28AB7533-1ED3-4AA6-8177-40DFF44E89CA--