Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* Re: [FFmpeg-devel] [PATCH v3 0/8] add fd protocol
       [not found] <34df4f8e-0c8b-4199-8a4b-5669078b4a25@EX-SZ069.tencent.com>
@ 2023-01-09  3:17 ` "zhilizhao(赵志立)"
  2023-01-11  3:18   ` "zhilizhao(赵志立)"
  0 siblings, 1 reply; 13+ messages in thread
From: "zhilizhao(赵志立)" @ 2023-01-09  3:17 UTC (permalink / raw)
  To: FFmpeg development discussions and patches


> On Dec 15, 2022, at 01:10, Zhao Zhili <quinkblack@foxmail.com> wrote:
> 
> From: Zhao Zhili <zhilizhao@tencent.com>
> 
> v2:
> 1. Forbid pass file descriptor via fd:{num}, instead of -fd option
> 2. Set CLOEXEC
> 3. Prefer fd over pipe for fftools
> 
> v1: dup file descriptor
> 
> Zhao Zhili (8):
>  avformat/file: add fd option for pipe
>  avformat/file: reindent after the previous commit
>  avformat/file: dup file descriptor for pipe
>  avformat/file: add fd protocol
>  fftools/ffmpeg_demux: disable stdin interaction for fd protocol
>  fftools/ffplay: prefer fd over pipe for seek support
>  fftools/ffprobe: prefer fd over pipe for seek support
>  fftools/ffmpeg_demux: prefer fd over pipe for seek support
> 
> doc/protocols.texi      |  31 +++++++-
> fftools/ffmpeg_demux.c  |   3 +-
> fftools/ffplay.c        |   2 +-
> fftools/ffprobe.c       |   4 +-
> libavformat/Makefile    |   1 +
> libavformat/file.c      | 152 +++++++++++++++++++++++++++++++---------
> libavformat/protocols.c |   1 +
> libavformat/version.h   |   4 +-
> 8 files changed, 156 insertions(+), 42 deletions(-)

Will apply soon unless there are objections.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [FFmpeg-devel] [PATCH v3 0/8] add fd protocol
  2023-01-09  3:17 ` [FFmpeg-devel] [PATCH v3 0/8] add fd protocol "zhilizhao(赵志立)"
@ 2023-01-11  3:18   ` "zhilizhao(赵志立)"
  2023-01-11  7:53     ` Xiang, Haihao
  0 siblings, 1 reply; 13+ messages in thread
From: "zhilizhao(赵志立)" @ 2023-01-11  3:18 UTC (permalink / raw)
  To: FFmpeg development discussions and patches


> On Jan 9, 2023, at 11:17, zhilizhao(赵志立) <quinkblack@foxmail.com> wrote:
> 
>> On Dec 15, 2022, at 01:10, Zhao Zhili <quinkblack@foxmail.com> wrote:
>> 
>> From: Zhao Zhili <zhilizhao@tencent.com>
>> 
>> v2:
>> 1. Forbid pass file descriptor via fd:{num}, instead of -fd option
>> 2. Set CLOEXEC
>> 3. Prefer fd over pipe for fftools
>> 
>> v1: dup file descriptor
>> 
>> Zhao Zhili (8):
>> avformat/file: add fd option for pipe
>> avformat/file: reindent after the previous commit
>> avformat/file: dup file descriptor for pipe
>> avformat/file: add fd protocol
>> fftools/ffmpeg_demux: disable stdin interaction for fd protocol
>> fftools/ffplay: prefer fd over pipe for seek support
>> fftools/ffprobe: prefer fd over pipe for seek support
>> fftools/ffmpeg_demux: prefer fd over pipe for seek support
>> 
>> doc/protocols.texi      |  31 +++++++-
>> fftools/ffmpeg_demux.c  |   3 +-
>> fftools/ffplay.c        |   2 +-
>> fftools/ffprobe.c       |   4 +-
>> libavformat/Makefile    |   1 +
>> libavformat/file.c      | 152 +++++++++++++++++++++++++++++++---------
>> libavformat/protocols.c |   1 +
>> libavformat/version.h   |   4 +-
>> 8 files changed, 156 insertions(+), 42 deletions(-)
> 
> Will apply soon unless there are objections.

Pushed.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [FFmpeg-devel] [PATCH v3 0/8] add fd protocol
  2023-01-11  3:18   ` "zhilizhao(赵志立)"
@ 2023-01-11  7:53     ` Xiang, Haihao
  2023-01-11  8:31       ` "zhilizhao(赵志立)"
  0 siblings, 1 reply; 13+ messages in thread
From: Xiang, Haihao @ 2023-01-11  7:53 UTC (permalink / raw)
  To: ffmpeg-devel

On Wo, 2023-01-11 at 11:18 +0800, zhilizhao(赵志立) wrote:
> > On Jan 9, 2023, at 11:17, zhilizhao(赵志立) <quinkblack@foxmail.com> wrote:
> > 
> > > On Dec 15, 2022, at 01:10, Zhao Zhili <quinkblack@foxmail.com> wrote:
> > > 
> > > From: Zhao Zhili <zhilizhao@tencent.com>
> > > 
> > > v2:
> > > 1. Forbid pass file descriptor via fd:{num}, instead of -fd option
> > > 2. Set CLOEXEC
> > > 3. Prefer fd over pipe for fftools
> > > 
> > > v1: dup file descriptor
> > > 
> > > Zhao Zhili (8):
> > > avformat/file: add fd option for pipe
> > > avformat/file: reindent after the previous commit
> > > avformat/file: dup file descriptor for pipe
> > > avformat/file: add fd protocol
> > > fftools/ffmpeg_demux: disable stdin interaction for fd protocol
> > > fftools/ffplay: prefer fd over pipe for seek support
> > > fftools/ffprobe: prefer fd over pipe for seek support
> > > fftools/ffmpeg_demux: prefer fd over pipe for seek support
> > > 
> > > doc/protocols.texi      |  31 +++++++-
> > > fftools/ffmpeg_demux.c  |   3 +-
> > > fftools/ffplay.c        |   2 +-
> > > fftools/ffprobe.c       |   4 +-
> > > libavformat/Makefile    |   1 +
> > > libavformat/file.c      | 152 +++++++++++++++++++++++++++++++---------
> > > libavformat/protocols.c |   1 +
> > > libavformat/version.h   |   4 +-
> > > 8 files changed, 156 insertions(+), 42 deletions(-)
> > 
> > Will apply soon unless there are objections.
> 
> Pushed.

It caused link error on Windows

INFO  - LD    libavformat/avformat-59.dll
INFO  -    Creating library libavformat/avformat.lib and object
libavformat/avformat.exp
INFO  - file.o : error LNK2019: unresolved external symbol S_ISREG referenced in
function fd_open
INFO  - file.o : error LNK2019: unresolved external symbol S_ISBLK referenced in
function fd_open
INFO  - libavformat\avformat-59.dll : fatal error LNK1120: 2 unresolved
externals

Thanks
Haihao

> 
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > 
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [FFmpeg-devel] [PATCH v3 0/8] add fd protocol
  2023-01-11  7:53     ` Xiang, Haihao
@ 2023-01-11  8:31       ` "zhilizhao(赵志立)"
  2023-01-11  8:52         ` Paul B Mahol
  2023-01-11  9:02         ` "zhilizhao(赵志立)"
  0 siblings, 2 replies; 13+ messages in thread
From: "zhilizhao(赵志立)" @ 2023-01-11  8:31 UTC (permalink / raw)
  To: FFmpeg development discussions and patches



> On Jan 11, 2023, at 15:53, Xiang, Haihao <haihao.xiang-at-intel.com@ffmpeg.org> wrote:
> 
> On Wo, 2023-01-11 at 11:18 +0800, zhilizhao(赵志立) wrote:
>>> On Jan 9, 2023, at 11:17, zhilizhao(赵志立) <quinkblack@foxmail.com> wrote:
>>> 
>>>> On Dec 15, 2022, at 01:10, Zhao Zhili <quinkblack@foxmail.com> wrote:
>>>> 
>>>> From: Zhao Zhili <zhilizhao@tencent.com>
>>>> 
>>>> v2:
>>>> 1. Forbid pass file descriptor via fd:{num}, instead of -fd option
>>>> 2. Set CLOEXEC
>>>> 3. Prefer fd over pipe for fftools
>>>> 
>>>> v1: dup file descriptor
>>>> 
>>>> Zhao Zhili (8):
>>>> avformat/file: add fd option for pipe
>>>> avformat/file: reindent after the previous commit
>>>> avformat/file: dup file descriptor for pipe
>>>> avformat/file: add fd protocol
>>>> fftools/ffmpeg_demux: disable stdin interaction for fd protocol
>>>> fftools/ffplay: prefer fd over pipe for seek support
>>>> fftools/ffprobe: prefer fd over pipe for seek support
>>>> fftools/ffmpeg_demux: prefer fd over pipe for seek support
>>>> 
>>>> doc/protocols.texi      |  31 +++++++-
>>>> fftools/ffmpeg_demux.c  |   3 +-
>>>> fftools/ffplay.c        |   2 +-
>>>> fftools/ffprobe.c       |   4 +-
>>>> libavformat/Makefile    |   1 +
>>>> libavformat/file.c      | 152 +++++++++++++++++++++++++++++++---------
>>>> libavformat/protocols.c |   1 +
>>>> libavformat/version.h   |   4 +-
>>>> 8 files changed, 156 insertions(+), 42 deletions(-)
>>> 
>>> Will apply soon unless there are objections.
>> 
>> Pushed.
> 
> It caused link error on Windows
> 
> INFO  - LD    libavformat/avformat-59.dll
> INFO  -    Creating library libavformat/avformat.lib and object
> libavformat/avformat.exp
> INFO  - file.o : error LNK2019: unresolved external symbol S_ISREG referenced in
> function fd_open
> INFO  - file.o : error LNK2019: unresolved external symbol S_ISBLK referenced in
> function fd_open
> INFO  - libavformat\avformat-59.dll : fatal error LNK1120: 2 unresolved
> externals

Sorry for the break, I’m trying to figure out how to make it compatible
with Windows.

> 
> Thanks
> Haihao
> 
>> 
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel@ffmpeg.org
>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>> 
>>> To unsubscribe, visit link above, or email
>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>> 
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> 
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [FFmpeg-devel] [PATCH v3 0/8] add fd protocol
  2023-01-11  8:31       ` "zhilizhao(赵志立)"
@ 2023-01-11  8:52         ` Paul B Mahol
  2023-01-11  9:10           ` "zhilizhao(赵志立)"
  2023-01-12 19:13           ` Rémi Denis-Courmont
  2023-01-11  9:02         ` "zhilizhao(赵志立)"
  1 sibling, 2 replies; 13+ messages in thread
From: Paul B Mahol @ 2023-01-11  8:52 UTC (permalink / raw)
  To: FFmpeg development discussions and patches

On 1/11/23, "zhilizhao(赵志立)" <quinkblack@foxmail.com> wrote:
>
>
>> On Jan 11, 2023, at 15:53, Xiang, Haihao
>> <haihao.xiang-at-intel.com@ffmpeg.org> wrote:
>>
>> On Wo, 2023-01-11 at 11:18 +0800, zhilizhao(赵志立) wrote:
>>>> On Jan 9, 2023, at 11:17, zhilizhao(赵志立) <quinkblack@foxmail.com> wrote:
>>>>
>>>>> On Dec 15, 2022, at 01:10, Zhao Zhili <quinkblack@foxmail.com> wrote:
>>>>>
>>>>> From: Zhao Zhili <zhilizhao@tencent.com>
>>>>>
>>>>> v2:
>>>>> 1. Forbid pass file descriptor via fd:{num}, instead of -fd option
>>>>> 2. Set CLOEXEC
>>>>> 3. Prefer fd over pipe for fftools
>>>>>
>>>>> v1: dup file descriptor
>>>>>
>>>>> Zhao Zhili (8):
>>>>> avformat/file: add fd option for pipe
>>>>> avformat/file: reindent after the previous commit
>>>>> avformat/file: dup file descriptor for pipe
>>>>> avformat/file: add fd protocol
>>>>> fftools/ffmpeg_demux: disable stdin interaction for fd protocol
>>>>> fftools/ffplay: prefer fd over pipe for seek support
>>>>> fftools/ffprobe: prefer fd over pipe for seek support
>>>>> fftools/ffmpeg_demux: prefer fd over pipe for seek support
>>>>>
>>>>> doc/protocols.texi      |  31 +++++++-
>>>>> fftools/ffmpeg_demux.c  |   3 +-
>>>>> fftools/ffplay.c        |   2 +-
>>>>> fftools/ffprobe.c       |   4 +-
>>>>> libavformat/Makefile    |   1 +
>>>>> libavformat/file.c      | 152 +++++++++++++++++++++++++++++++---------
>>>>> libavformat/protocols.c |   1 +
>>>>> libavformat/version.h   |   4 +-
>>>>> 8 files changed, 156 insertions(+), 42 deletions(-)
>>>>
>>>> Will apply soon unless there are objections.
>>>
>>> Pushed.
>>
>> It caused link error on Windows
>>
>> INFO  - LD    libavformat/avformat-59.dll
>> INFO  -    Creating library libavformat/avformat.lib and object
>> libavformat/avformat.exp
>> INFO  - file.o : error LNK2019: unresolved external symbol S_ISREG
>> referenced in
>> function fd_open
>> INFO  - file.o : error LNK2019: unresolved external symbol S_ISBLK
>> referenced in
>> function fd_open
>> INFO  - libavformat\avformat-59.dll : fatal error LNK1120: 2 unresolved
>> externals
>
> Sorry for the break, I’m trying to figure out how to make it compatible
> with Windows.

Is this even portable?

>
>>
>> Thanks
>> Haihao
>>
>>>
>>>> _______________________________________________
>>>> ffmpeg-devel mailing list
>>>> ffmpeg-devel@ffmpeg.org
>>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>>
>>>> To unsubscribe, visit link above, or email
>>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>>
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel@ffmpeg.org
>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>
>>> To unsubscribe, visit link above, or email
>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [FFmpeg-devel] [PATCH v3 0/8] add fd protocol
  2023-01-11  8:31       ` "zhilizhao(赵志立)"
  2023-01-11  8:52         ` Paul B Mahol
@ 2023-01-11  9:02         ` "zhilizhao(赵志立)"
  1 sibling, 0 replies; 13+ messages in thread
From: "zhilizhao(赵志立)" @ 2023-01-11  9:02 UTC (permalink / raw)
  To: FFmpeg development discussions and patches



> On Jan 11, 2023, at 16:31, zhilizhao(赵志立) <quinkblack@foxmail.com> wrote:
> 
> 
> 
>> On Jan 11, 2023, at 15:53, Xiang, Haihao <haihao.xiang-at-intel.com@ffmpeg.org> wrote:
>> 
>> On Wo, 2023-01-11 at 11:18 +0800, zhilizhao(赵志立) wrote:
>>>> On Jan 9, 2023, at 11:17, zhilizhao(赵志立) <quinkblack@foxmail.com> wrote:
>>>> 
>>>>> On Dec 15, 2022, at 01:10, Zhao Zhili <quinkblack@foxmail.com> wrote:
>>>>> 
>>>>> From: Zhao Zhili <zhilizhao@tencent.com>
>>>>> 
>>>>> v2:
>>>>> 1. Forbid pass file descriptor via fd:{num}, instead of -fd option
>>>>> 2. Set CLOEXEC
>>>>> 3. Prefer fd over pipe for fftools
>>>>> 
>>>>> v1: dup file descriptor
>>>>> 
>>>>> Zhao Zhili (8):
>>>>> avformat/file: add fd option for pipe
>>>>> avformat/file: reindent after the previous commit
>>>>> avformat/file: dup file descriptor for pipe
>>>>> avformat/file: add fd protocol
>>>>> fftools/ffmpeg_demux: disable stdin interaction for fd protocol
>>>>> fftools/ffplay: prefer fd over pipe for seek support
>>>>> fftools/ffprobe: prefer fd over pipe for seek support
>>>>> fftools/ffmpeg_demux: prefer fd over pipe for seek support
>>>>> 
>>>>> doc/protocols.texi      |  31 +++++++-
>>>>> fftools/ffmpeg_demux.c  |   3 +-
>>>>> fftools/ffplay.c        |   2 +-
>>>>> fftools/ffprobe.c       |   4 +-
>>>>> libavformat/Makefile    |   1 +
>>>>> libavformat/file.c      | 152 +++++++++++++++++++++++++++++++---------
>>>>> libavformat/protocols.c |   1 +
>>>>> libavformat/version.h   |   4 +-
>>>>> 8 files changed, 156 insertions(+), 42 deletions(-)
>>>> 
>>>> Will apply soon unless there are objections.
>>> 
>>> Pushed.
>> 
>> It caused link error on Windows
>> 
>> INFO  - LD    libavformat/avformat-59.dll
>> INFO  -    Creating library libavformat/avformat.lib and object
>> libavformat/avformat.exp
>> INFO  - file.o : error LNK2019: unresolved external symbol S_ISREG referenced in
>> function fd_open
>> INFO  - file.o : error LNK2019: unresolved external symbol S_ISBLK referenced in
>> function fd_open
>> INFO  - libavformat\avformat-59.dll : fatal error LNK1120: 2 unresolved
>> externals
> 
> Sorry for the break, I’m trying to figure out how to make it compatible
> with Windows.

Should be fixed by http://ffmpeg.org/pipermail/ffmpeg-devel/2023-January/305545.html

> 
>> 
>> Thanks
>> Haihao
>> 
>>> 
>>>> _______________________________________________
>>>> ffmpeg-devel mailing list
>>>> ffmpeg-devel@ffmpeg.org
>>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>> 
>>>> To unsubscribe, visit link above, or email
>>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>> 
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel@ffmpeg.org
>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>> 
>>> To unsubscribe, visit link above, or email
>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> 
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [FFmpeg-devel] [PATCH v3 0/8] add fd protocol
  2023-01-11  8:52         ` Paul B Mahol
@ 2023-01-11  9:10           ` "zhilizhao(赵志立)"
  2023-01-12  1:26             ` Xiang, Haihao
  2023-01-12 19:13           ` Rémi Denis-Courmont
  1 sibling, 1 reply; 13+ messages in thread
From: "zhilizhao(赵志立)" @ 2023-01-11  9:10 UTC (permalink / raw)
  To: FFmpeg development discussions and patches



> On Jan 11, 2023, at 16:52, Paul B Mahol <onemda@gmail.com> wrote:
> 
> On 1/11/23, "zhilizhao(赵志立)" <quinkblack@foxmail.com> wrote:
>> 
>> 
>>> On Jan 11, 2023, at 15:53, Xiang, Haihao
>>> <haihao.xiang-at-intel.com@ffmpeg.org> wrote:
>>> 
>>> On Wo, 2023-01-11 at 11:18 +0800, zhilizhao(赵志立) wrote:
>>>>> On Jan 9, 2023, at 11:17, zhilizhao(赵志立) <quinkblack@foxmail.com> wrote:
>>>>> 
>>>>>> On Dec 15, 2022, at 01:10, Zhao Zhili <quinkblack@foxmail.com> wrote:
>>>>>> 
>>>>>> From: Zhao Zhili <zhilizhao@tencent.com>
>>>>>> 
>>>>>> v2:
>>>>>> 1. Forbid pass file descriptor via fd:{num}, instead of -fd option
>>>>>> 2. Set CLOEXEC
>>>>>> 3. Prefer fd over pipe for fftools
>>>>>> 
>>>>>> v1: dup file descriptor
>>>>>> 
>>>>>> Zhao Zhili (8):
>>>>>> avformat/file: add fd option for pipe
>>>>>> avformat/file: reindent after the previous commit
>>>>>> avformat/file: dup file descriptor for pipe
>>>>>> avformat/file: add fd protocol
>>>>>> fftools/ffmpeg_demux: disable stdin interaction for fd protocol
>>>>>> fftools/ffplay: prefer fd over pipe for seek support
>>>>>> fftools/ffprobe: prefer fd over pipe for seek support
>>>>>> fftools/ffmpeg_demux: prefer fd over pipe for seek support
>>>>>> 
>>>>>> doc/protocols.texi      |  31 +++++++-
>>>>>> fftools/ffmpeg_demux.c  |   3 +-
>>>>>> fftools/ffplay.c        |   2 +-
>>>>>> fftools/ffprobe.c       |   4 +-
>>>>>> libavformat/Makefile    |   1 +
>>>>>> libavformat/file.c      | 152 +++++++++++++++++++++++++++++++---------
>>>>>> libavformat/protocols.c |   1 +
>>>>>> libavformat/version.h   |   4 +-
>>>>>> 8 files changed, 156 insertions(+), 42 deletions(-)
>>>>> 
>>>>> Will apply soon unless there are objections.
>>>> 
>>>> Pushed.
>>> 
>>> It caused link error on Windows
>>> 
>>> INFO  - LD    libavformat/avformat-59.dll
>>> INFO  -    Creating library libavformat/avformat.lib and object
>>> libavformat/avformat.exp
>>> INFO  - file.o : error LNK2019: unresolved external symbol S_ISREG
>>> referenced in
>>> function fd_open
>>> INFO  - file.o : error LNK2019: unresolved external symbol S_ISBLK
>>> referenced in
>>> function fd_open
>>> INFO  - libavformat\avformat-59.dll : fatal error LNK1120: 2 unresolved
>>> externals
>> 
>> Sorry for the break, I’m trying to figure out how to make it compatible
>> with Windows.
> 
> Is this even portable?

fstat and the macros are defined by POSIX. Windows doesn’t provide S_ISREG
or S_ISBLK, but it does provide S_IFREG. So the compatability macro S_ISREG()
should work. For S_ISBLK(), it’s always false on Windows which shouldn’t be
an issue.

http://ffmpeg.org/pipermail/ffmpeg-devel/2023-January/305545.html

> 
>> 
>>> 
>>> Thanks
>>> Haihao
>>> 
>>>> 
>>>>> _______________________________________________
>>>>> ffmpeg-devel mailing list
>>>>> ffmpeg-devel@ffmpeg.org
>>>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>>> 
>>>>> To unsubscribe, visit link above, or email
>>>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>>> 
>>>> _______________________________________________
>>>> ffmpeg-devel mailing list
>>>> ffmpeg-devel@ffmpeg.org
>>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>> 
>>>> To unsubscribe, visit link above, or email
>>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel@ffmpeg.org
>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>> 
>>> To unsubscribe, visit link above, or email
>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>> 
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> 
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [FFmpeg-devel] [PATCH v3 0/8] add fd protocol
  2023-01-11  9:10           ` "zhilizhao(赵志立)"
@ 2023-01-12  1:26             ` Xiang, Haihao
  2023-01-12  7:29               ` "zhilizhao(赵志立)"
  0 siblings, 1 reply; 13+ messages in thread
From: Xiang, Haihao @ 2023-01-12  1:26 UTC (permalink / raw)
  To: ffmpeg-devel

On Wo, 2023-01-11 at 17:10 +0800, zhilizhao(赵志立) wrote:
> > On Jan 11, 2023, at 16:52, Paul B Mahol <onemda@gmail.com> wrote:
> > 
> > On 1/11/23, "zhilizhao(赵志立)" <quinkblack@foxmail.com> wrote:
> > > 
> > > > On Jan 11, 2023, at 15:53, Xiang, Haihao
> > > > <haihao.xiang-at-intel.com@ffmpeg.org> wrote:
> > > > 
> > > > On Wo, 2023-01-11 at 11:18 +0800, zhilizhao(赵志立) wrote:
> > > > > > On Jan 9, 2023, at 11:17, zhilizhao(赵志立) <quinkblack@foxmail.com>
> > > > > > wrote:
> > > > > > 
> > > > > > > On Dec 15, 2022, at 01:10, Zhao Zhili <quinkblack@foxmail.com>
> > > > > > > wrote:
> > > > > > > 
> > > > > > > From: Zhao Zhili <zhilizhao@tencent.com>
> > > > > > > 
> > > > > > > v2:
> > > > > > > 1. Forbid pass file descriptor via fd:{num}, instead of -fd option
> > > > > > > 2. Set CLOEXEC
> > > > > > > 3. Prefer fd over pipe for fftools
> > > > > > > 
> > > > > > > v1: dup file descriptor
> > > > > > > 
> > > > > > > Zhao Zhili (8):
> > > > > > > avformat/file: add fd option for pipe
> > > > > > > avformat/file: reindent after the previous commit
> > > > > > > avformat/file: dup file descriptor for pipe
> > > > > > > avformat/file: add fd protocol
> > > > > > > fftools/ffmpeg_demux: disable stdin interaction for fd protocol
> > > > > > > fftools/ffplay: prefer fd over pipe for seek support
> > > > > > > fftools/ffprobe: prefer fd over pipe for seek support
> > > > > > > fftools/ffmpeg_demux: prefer fd over pipe for seek support
> > > > > > > 
> > > > > > > doc/protocols.texi      |  31 +++++++-
> > > > > > > fftools/ffmpeg_demux.c  |   3 +-
> > > > > > > fftools/ffplay.c        |   2 +-
> > > > > > > fftools/ffprobe.c       |   4 +-
> > > > > > > libavformat/Makefile    |   1 +
> > > > > > > libavformat/file.c      | 152 +++++++++++++++++++++++++++++++-----
> > > > > > > ----
> > > > > > > libavformat/protocols.c |   1 +
> > > > > > > libavformat/version.h   |   4 +-
> > > > > > > 8 files changed, 156 insertions(+), 42 deletions(-)
> > > > > > 
> > > > > > Will apply soon unless there are objections.
> > > > > 
> > > > > Pushed.
> > > > 
> > > > It caused link error on Windows
> > > > 
> > > > INFO  - LD    libavformat/avformat-59.dll
> > > > INFO  -    Creating library libavformat/avformat.lib and object
> > > > libavformat/avformat.exp
> > > > INFO  - file.o : error LNK2019: unresolved external symbol S_ISREG
> > > > referenced in
> > > > function fd_open
> > > > INFO  - file.o : error LNK2019: unresolved external symbol S_ISBLK
> > > > referenced in
> > > > function fd_open
> > > > INFO  - libavformat\avformat-59.dll : fatal error LNK1120: 2 unresolved
> > > > externals
> > > 
> > > Sorry for the break, I’m trying to figure out how to make it compatible
> > > with Windows.
> > 
> > Is this even portable?
> 
> fstat and the macros are defined by POSIX. Windows doesn’t provide S_ISREG
> or S_ISBLK, but it does provide S_IFREG. So the compatability macro S_ISREG()
> should work. For S_ISBLK(), it’s always false on Windows which shouldn’t be
> an issue.
> 
> http://ffmpeg.org/pipermail/ffmpeg-devel/2023-January/305545.html

Thanks for your quick fix, the error went away after applying this patch.

- Haihao

> 
> > > > Thanks
> > > > Haihao
> > > > 
> > > > > > _______________________________________________
> > > > > > ffmpeg-devel mailing list
> > > > > > ffmpeg-devel@ffmpeg.org
> > > > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > > > > > 
> > > > > > To unsubscribe, visit link above, or email
> > > > > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> > > > > 
> > > > > _______________________________________________
> > > > > ffmpeg-devel mailing list
> > > > > ffmpeg-devel@ffmpeg.org
> > > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > > > > 
> > > > > To unsubscribe, visit link above, or email
> > > > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> > > > _______________________________________________
> > > > ffmpeg-devel mailing list
> > > > ffmpeg-devel@ffmpeg.org
> > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > > > 
> > > > To unsubscribe, visit link above, or email
> > > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> > > 
> > > _______________________________________________
> > > ffmpeg-devel mailing list
> > > ffmpeg-devel@ffmpeg.org
> > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > > 
> > > To unsubscribe, visit link above, or email
> > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> > > 
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > 
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [FFmpeg-devel] [PATCH v3 0/8] add fd protocol
  2023-01-12  1:26             ` Xiang, Haihao
@ 2023-01-12  7:29               ` "zhilizhao(赵志立)"
  0 siblings, 0 replies; 13+ messages in thread
From: "zhilizhao(赵志立)" @ 2023-01-12  7:29 UTC (permalink / raw)
  To: FFmpeg development discussions and patches



> On Jan 12, 2023, at 09:26, Xiang, Haihao <haihao.xiang-at-intel.com@ffmpeg.org> wrote:
> 
> On Wo, 2023-01-11 at 17:10 +0800, zhilizhao(赵志立) wrote:
>>> On Jan 11, 2023, at 16:52, Paul B Mahol <onemda@gmail.com> wrote:
>>> 
>>> On 1/11/23, "zhilizhao(赵志立)" <quinkblack@foxmail.com> wrote:
>>>> 
>>>>> On Jan 11, 2023, at 15:53, Xiang, Haihao
>>>>> <haihao.xiang-at-intel.com@ffmpeg.org> wrote:
>>>>> 
>>>>> On Wo, 2023-01-11 at 11:18 +0800, zhilizhao(赵志立) wrote:
>>>>>>> On Jan 9, 2023, at 11:17, zhilizhao(赵志立) <quinkblack@foxmail.com>
>>>>>>> wrote:
>>>>>>> 
>>>>>>>> On Dec 15, 2022, at 01:10, Zhao Zhili <quinkblack@foxmail.com>
>>>>>>>> wrote:
>>>>>>>> 
>>>>>>>> From: Zhao Zhili <zhilizhao@tencent.com>
>>>>>>>> 
>>>>>>>> v2:
>>>>>>>> 1. Forbid pass file descriptor via fd:{num}, instead of -fd option
>>>>>>>> 2. Set CLOEXEC
>>>>>>>> 3. Prefer fd over pipe for fftools
>>>>>>>> 
>>>>>>>> v1: dup file descriptor
>>>>>>>> 
>>>>>>>> Zhao Zhili (8):
>>>>>>>> avformat/file: add fd option for pipe
>>>>>>>> avformat/file: reindent after the previous commit
>>>>>>>> avformat/file: dup file descriptor for pipe
>>>>>>>> avformat/file: add fd protocol
>>>>>>>> fftools/ffmpeg_demux: disable stdin interaction for fd protocol
>>>>>>>> fftools/ffplay: prefer fd over pipe for seek support
>>>>>>>> fftools/ffprobe: prefer fd over pipe for seek support
>>>>>>>> fftools/ffmpeg_demux: prefer fd over pipe for seek support
>>>>>>>> 
>>>>>>>> doc/protocols.texi      |  31 +++++++-
>>>>>>>> fftools/ffmpeg_demux.c  |   3 +-
>>>>>>>> fftools/ffplay.c        |   2 +-
>>>>>>>> fftools/ffprobe.c       |   4 +-
>>>>>>>> libavformat/Makefile    |   1 +
>>>>>>>> libavformat/file.c      | 152 +++++++++++++++++++++++++++++++-----
>>>>>>>> ----
>>>>>>>> libavformat/protocols.c |   1 +
>>>>>>>> libavformat/version.h   |   4 +-
>>>>>>>> 8 files changed, 156 insertions(+), 42 deletions(-)
>>>>>>> 
>>>>>>> Will apply soon unless there are objections.
>>>>>> 
>>>>>> Pushed.
>>>>> 
>>>>> It caused link error on Windows
>>>>> 
>>>>> INFO  - LD    libavformat/avformat-59.dll
>>>>> INFO  -    Creating library libavformat/avformat.lib and object
>>>>> libavformat/avformat.exp
>>>>> INFO  - file.o : error LNK2019: unresolved external symbol S_ISREG
>>>>> referenced in
>>>>> function fd_open
>>>>> INFO  - file.o : error LNK2019: unresolved external symbol S_ISBLK
>>>>> referenced in
>>>>> function fd_open
>>>>> INFO  - libavformat\avformat-59.dll : fatal error LNK1120: 2 unresolved
>>>>> externals
>>>> 
>>>> Sorry for the break, I’m trying to figure out how to make it compatible
>>>> with Windows.
>>> 
>>> Is this even portable?
>> 
>> fstat and the macros are defined by POSIX. Windows doesn’t provide S_ISREG
>> or S_ISBLK, but it does provide S_IFREG. So the compatability macro S_ISREG()
>> should work. For S_ISBLK(), it’s always false on Windows which shouldn’t be
>> an issue.
>> 
>> http://ffmpeg.org/pipermail/ffmpeg-devel/2023-January/305545.html
> 
> Thanks for your quick fix, the error went away after applying this patch.

Thanks for the report and test, pushed as e30bf5acee1ae07724196c44b6b457cd9f8c94f3

> 
> - Haihao
> 
>> 
>>>>> Thanks
>>>>> Haihao
>>>>> 
>>>>>>> _______________________________________________
>>>>>>> ffmpeg-devel mailing list
>>>>>>> ffmpeg-devel@ffmpeg.org
>>>>>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>>>>> 
>>>>>>> To unsubscribe, visit link above, or email
>>>>>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>>>>> 
>>>>>> _______________________________________________
>>>>>> ffmpeg-devel mailing list
>>>>>> ffmpeg-devel@ffmpeg.org
>>>>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>>>> 
>>>>>> To unsubscribe, visit link above, or email
>>>>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>>>> _______________________________________________
>>>>> ffmpeg-devel mailing list
>>>>> ffmpeg-devel@ffmpeg.org
>>>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>>> 
>>>>> To unsubscribe, visit link above, or email
>>>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>>> 
>>>> _______________________________________________
>>>> ffmpeg-devel mailing list
>>>> ffmpeg-devel@ffmpeg.org
>>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>> 
>>>> To unsubscribe, visit link above, or email
>>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>>> 
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel@ffmpeg.org
>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>> 
>>> To unsubscribe, visit link above, or email
>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>> 
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> 
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [FFmpeg-devel] [PATCH v3 0/8] add fd protocol
  2023-01-11  8:52         ` Paul B Mahol
  2023-01-11  9:10           ` "zhilizhao(赵志立)"
@ 2023-01-12 19:13           ` Rémi Denis-Courmont
  2023-01-13  3:37             ` "zhilizhao(赵志立)"
  1 sibling, 1 reply; 13+ messages in thread
From: Rémi Denis-Courmont @ 2023-01-12 19:13 UTC (permalink / raw)
  To: FFmpeg development discussions and patches

Le keskiviikkona 11. tammikuuta 2023, 10.52.08 EET Paul B Mahol a écrit :
> > Sorry for the break, I’m trying to figure out how to make it compatible
> > with Windows.
> 
> Is this even portable?

If you build FFmpeg correctly, so that all the FFmpeg libraries and the 
application code share the same instance of the same CRT, yes. That is to say, 
you can use POSIX-style file descriptors.

Whether it is of any practical usefulness is more questionable, as those file 
descriptors are not passed from parent to child processes

-- 
Реми Дёни-Курмон
http://www.remlab.net/



_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [FFmpeg-devel] [PATCH v3 0/8] add fd protocol
  2023-01-12 19:13           ` Rémi Denis-Courmont
@ 2023-01-13  3:37             ` "zhilizhao(赵志立)"
  2023-01-13 18:12               ` Rémi Denis-Courmont
  0 siblings, 1 reply; 13+ messages in thread
From: "zhilizhao(赵志立)" @ 2023-01-13  3:37 UTC (permalink / raw)
  To: FFmpeg development discussions and patches


> On Jan 13, 2023, at 03:13, Rémi Denis-Courmont <remi@remlab.net> wrote:
> 
> Le keskiviikkona 11. tammikuuta 2023, 10.52.08 EET Paul B Mahol a écrit :
>>> Sorry for the break, I’m trying to figure out how to make it compatible
>>> with Windows.
>> 
>> Is this even portable?
> 
> If you build FFmpeg correctly, so that all the FFmpeg libraries and the 
> application code share the same instance of the same CRT, yes. That is to say, 
> you can use POSIX-style file descriptors.
> 
> Whether it is of any practical usefulness is more questionable, as those file 
> descriptors are not passed from parent to child processes

When an app requests a media file, Android system provides it as a file descriptor
over IPC for security. Users may find other usecases.

> 
> -- 
> Реми Дёни-Курмон
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [FFmpeg-devel] [PATCH v3 0/8] add fd protocol
  2023-01-13  3:37             ` "zhilizhao(赵志立)"
@ 2023-01-13 18:12               ` Rémi Denis-Courmont
  0 siblings, 0 replies; 13+ messages in thread
From: Rémi Denis-Courmont @ 2023-01-13 18:12 UTC (permalink / raw)
  To: FFmpeg development discussions and patches

Le perjantaina 13. tammikuuta 2023, 5.37.36 EET zhilizhao(赵志立) a écrit :
> > On Jan 13, 2023, at 03:13, Rémi Denis-Courmont <remi@remlab.net> wrote:
> > 
> > Le keskiviikkona 11. tammikuuta 2023, 10.52.08 EET Paul B Mahol a écrit :
> >>> Sorry for the break, I’m trying to figure out how to make it compatible
> >>> with Windows.
> >> 
> >> Is this even portable?
> > 
> > If you build FFmpeg correctly, so that all the FFmpeg libraries and the
> > application code share the same instance of the same CRT, yes. That is to
> > say, you can use POSIX-style file descriptors.
> > 
> > Whether it is of any practical usefulness is more questionable, as those
> > file descriptors are not passed from parent to child processes
> 
> When an app requests a media file, Android system provides it as a file
> descriptor over IPC for security. Users may find other usecases.

I'm not quite clear how that is relevant to Windows, TBH.

-- 
Rémi Denis-Courmont
http://www.remlab.net/



_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [FFmpeg-devel] [PATCH v3 0/8] add fd protocol
@ 2022-12-14 17:10 Zhao Zhili
  0 siblings, 0 replies; 13+ messages in thread
From: Zhao Zhili @ 2022-12-14 17:10 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Zhao Zhili

From: Zhao Zhili <zhilizhao@tencent.com>

v2:
1. Forbid pass file descriptor via fd:{num}, instead of -fd option
2. Set CLOEXEC
3. Prefer fd over pipe for fftools

v1: dup file descriptor

Zhao Zhili (8):
  avformat/file: add fd option for pipe
  avformat/file: reindent after the previous commit
  avformat/file: dup file descriptor for pipe
  avformat/file: add fd protocol
  fftools/ffmpeg_demux: disable stdin interaction for fd protocol
  fftools/ffplay: prefer fd over pipe for seek support
  fftools/ffprobe: prefer fd over pipe for seek support
  fftools/ffmpeg_demux: prefer fd over pipe for seek support

 doc/protocols.texi      |  31 +++++++-
 fftools/ffmpeg_demux.c  |   3 +-
 fftools/ffplay.c        |   2 +-
 fftools/ffprobe.c       |   4 +-
 libavformat/Makefile    |   1 +
 libavformat/file.c      | 152 +++++++++++++++++++++++++++++++---------
 libavformat/protocols.c |   1 +
 libavformat/version.h   |   4 +-
 8 files changed, 156 insertions(+), 42 deletions(-)

-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2023-01-13 18:13 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <34df4f8e-0c8b-4199-8a4b-5669078b4a25@EX-SZ069.tencent.com>
2023-01-09  3:17 ` [FFmpeg-devel] [PATCH v3 0/8] add fd protocol "zhilizhao(赵志立)"
2023-01-11  3:18   ` "zhilizhao(赵志立)"
2023-01-11  7:53     ` Xiang, Haihao
2023-01-11  8:31       ` "zhilizhao(赵志立)"
2023-01-11  8:52         ` Paul B Mahol
2023-01-11  9:10           ` "zhilizhao(赵志立)"
2023-01-12  1:26             ` Xiang, Haihao
2023-01-12  7:29               ` "zhilizhao(赵志立)"
2023-01-12 19:13           ` Rémi Denis-Courmont
2023-01-13  3:37             ` "zhilizhao(赵志立)"
2023-01-13 18:12               ` Rémi Denis-Courmont
2023-01-11  9:02         ` "zhilizhao(赵志立)"
2022-12-14 17:10 Zhao Zhili

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git