From: =?gb18030?B?0Oy4o8Kh?= <839789740@qq.com> To: =?gb18030?B?RkZtcGVnIGRldmVsb3BtZW50IGRpc2N1c3Npb25zIGFuZCBwYXRjaGVz?= <ffmpeg-devel@ffmpeg.org> Cc: =?gb18030?B?TWFydGluJm5ic3A7U3RvcnNqhDGkNw==?= <martin@martin.st> Subject: Re: [FFmpeg-devel] [PATCH] avutil/imgutils: optimize image copy efficiency Date: Thu, 4 May 2023 21:18:17 +0800 Message-ID: <tencent_82D9656721A26C8F180C467870D06C943C07@qq.com> (raw) In-Reply-To: <b3c31c5a-ba2-248e-3c55-668f4ad8f8b6@martin.st> [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset="gb18030", Size: 2955 bytes --] Thank you for your review, Martin. I try add some data, and submit again. ------------------ Original ------------------ From: "FFmpeg development discussions and patches" <martin@martin.st>; Date: Thu, May 4, 2023 04:22 PM To: "FFmpeg development discussions and patches"<ffmpeg-devel@ffmpeg.org>; Cc: "Ð츣¡"<839789740@qq.com>; Subject: Re: [FFmpeg-devel] [PATCH] avutil/imgutils: optimize image copy efficiency On Thu, 4 May 2023, xufuji456 wrote: > It makes sense when copying 4K/8K video, if linesize > equals to aligned linesize. > > Signed-off-by: xufuji456 <839789740@qq.com> > --- > libavutil/imgutils.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/libavutil/imgutils.c b/libavutil/imgutils.c > index 9ab5757cf6..1d432e7a57 100644 > --- a/libavutil/imgutils.c > +++ b/libavutil/imgutils.c > @@ -525,10 +525,17 @@ int av_image_copy_to_buffer(uint8_t *dst, int dst_size, > const uint8_t *src = src_data[i]; > h = (height + (1 << shift) - 1) >> shift; > > - for (j = 0; j < h; j++) { > - memcpy(dst, src, linesize[i]); > - dst += FFALIGN(linesize[i], align); > - src += src_linesize[i]; > + if (FFALIGN(linesize[i], align) == linesize[i] && src_linesize[i] == linesize[i]) { > + int size = linesize[i] * h; For cases like these, I would prefer to use "linesize[i] * (h - 1) + w" instead. For cases if copying e.g. into an offsetted position within a buffer, writing the last trailing padding would end up writing out of bounds. That said, I'm unsure about how much gain you get from this optimization here - some numbers to back it up would be useful. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-05-04 13:18 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-04 7:54 xufuji456 2023-05-04 8:22 ` Martin Storsjö 2023-05-04 13:18 ` =?gb18030?B?0Oy4o8Kh?= [this message] 2023-05-05 9:51 ` =?gb18030?B?0Oy4o8Kh?=
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=tencent_82D9656721A26C8F180C467870D06C943C07@qq.com \ --to=839789740@qq.com \ --cc=ffmpeg-devel@ffmpeg.org \ --cc=martin@martin.st \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git