From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5797A445BF for ; Sat, 17 Sep 2022 04:30:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1883D68BB54; Sat, 17 Sep 2022 07:30:15 +0300 (EEST) Received: from out162-62-58-216.mail.qq.com (out162-62-58-216.mail.qq.com [162.62.58.216]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C8BE768BB1C for ; Sat, 17 Sep 2022 07:30:08 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1663389004; bh=Iri9bEzeHHjbvR6uAEU2ONhRG/YlMG72r3s2H/SzKW0=; h=From:To:Cc:Subject:Date; b=BKjOg3T9XhnY3PjNMJmphSr9GCTK0o4Qi5FJfgEYIdqGRaNBk1tr0BQe4Br1bXjAu ROg00Wa6NHSJieK+lgyPImE6pn5yaWwMPE3O3V9W6jOGpPcNM3zYze3VJYusOBk6vt W9xc1oqXc76Yn4WLC8PgfcJlwNO2VXLjAYkJIpDo= Received: from ZHILIZHAO-MB2.tencent.com ([113.118.100.98]) by newxmesmtplogicsvrszb7.qq.com (NewEsmtp) with SMTP id 78321451; Sat, 17 Sep 2022 12:30:03 +0800 X-QQ-mid: xmsmtpt1663389003tb0jmu1sb Message-ID: X-QQ-XMAILINFO: MBjwNRQMz5zUdwnHAQvGiqyK/AKLLyzCowI2KNPi1aC5XSKDYFJimCvyguQ/aT pGi1NIJAd60lUcFwWYH+pFvdXNquJXX1JIxvVPIZ/oR93i5npjCW9bRzqX/YruXNF+K45qlX2pI4 UCpLDBHgLOFR9ELtB0wJquaL9aOwc4CApIwXMuWkwqIsRC4xEk6poY6SOzqIz1m7ag3WDS0xAjDL BwDWWcXo2diSpX/4E7PL1RzheG5NVyOfs3v7QVuyq6eyDi+QSnY2RPVLbsKCptD9P9rFGEWqAKCZ +cVoiflCX3v3Y8vvjLtWtwzW6UW96cHs8MOW0VOJoxl8TQcA5IiQs4XhpyhDFTrW/tyz7hc0v/LJ yyduCgK2K18e6piMrFME/NGv7BOkFJmaHwYbRYZhprmS/ua+k39/07xVlG4IjqT/9qcqmKTFoeCV touu+YkM0ywdbLY7mvuH6jAMrY6ExfULpWlVETHZhLSklFqFpSX0Q9LzXE7klUIzoOIkHTIBea7G of7aqzSgCTPRtgtBxlGfJ1NpuhYVxhE/E9XeSab0tZ6piUi9TmRD5t+8Sg5uPQT9BIAx6aKxKrYx ZjhbQ+T+kv6XhffrMUj/HTWn3fcj2JCRdTvLTNPRNFFoOeh6qvCfOAm08llzFUps9eh2o0heiVfR JhcAV5bPdfeBc6NHGktZ+RKtBfvbOHq2eZzvXTJIPhCtid7Q3VCKsmJDI/03SkMnC4bSasYgoGWO giMWhlWt8fOVY8CDjGmcy7OfyWesKeu4ObwJLm4YA56wrZh4FmTa9Km8Wm04hUP7fskO1amzpqyl DWA7jcHvC6vM8tvnDYX9XMCvTkT6XAR7AQnV2eUfJ4R+ki+i2BMUaKD9P5h9x57zG0Yx3oVzzei9 rXyFUwaNWu4HVmZyNIQuv2CXm393eoFcMBfZI0/MvX4Dan9VbeZqQSGGFLiINUoU2rRsSjZCXQbv Vmf7OT1yg= From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Sat, 17 Sep 2022 12:30:01 +0800 X-OQ-MSGID: <20220917043001.27933-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: configure min_hard_comp unconditionally X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Zhao Zhili There are two issues here. Firstly, the floating-point comparison is always true. Seconly, the code depends on the default value of min_hard_comp implicitly, which can be dangerous. Partially fixes ticket 9859. --- fftools/ffmpeg_filter.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 7a5308425d..17928cea2c 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -896,8 +896,7 @@ static int configure_input_audio_filter(FilterGraph *fg, InputFilter *ifilter, char args[256] = {0}; av_strlcatf(args, sizeof(args), "async=%d", audio_sync_method); - if (audio_drift_threshold != 0.1) - av_strlcatf(args, sizeof(args), ":min_hard_comp=%f", audio_drift_threshold); + av_strlcatf(args, sizeof(args), ":min_hard_comp=%f", audio_drift_threshold); if (!fg->reconfiguration) av_strlcatf(args, sizeof(args), ":first_pts=0"); AUTO_INSERT_FILTER_INPUT("-async", "aresample", args); -- 2.35.3 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".