* [FFmpeg-devel] [PATCH] fate/screen: workaround test failure on mac M1
@ 2023-10-08 13:17 Zhao Zhili
2023-10-08 13:22 ` Zhao Zhili
2023-10-16 17:40 ` Andreas Rheinhardt
0 siblings, 2 replies; 5+ messages in thread
From: Zhao Zhili @ 2023-10-08 13:17 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Zhao Zhili
From: Zhao Zhili <zhilizhao@tencent.com>
The last frame is corrupted. It has different results on different
platform.
---
tests/fate/screen.mak | 3 ++-
tests/ref/fate/zmbv-8bit | 1 -
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/fate/screen.mak b/tests/fate/screen.mak
index bd6d228544..1c92935d23 100644
--- a/tests/fate/screen.mak
+++ b/tests/fate/screen.mak
@@ -117,7 +117,8 @@ FATE_SCREEN += $(FATE_VMNC-yes)
fate-vmnc: $(FATE_VMNC-yes)
FATE_ZMBV += fate-zmbv-8bit
-fate-zmbv-8bit: CMD = framecrc -i $(TARGET_SAMPLES)/zmbv/wc2_001-partial.avi -an -pix_fmt rgb24 -vf scale
+# The last frame is corrupted.
+fate-zmbv-8bit: CMD = framecrc -i $(TARGET_SAMPLES)/zmbv/wc2_001-partial.avi -an -frames:v 275 -pix_fmt rgb24 -vf scale
FATE_ZMBV += fate-zmbv-15bit
fate-zmbv-15bit: CMD = framecrc -i $(TARGET_SAMPLES)/zmbv/zmbv_15bit.avi -pix_fmt rgb24 -t 25 -vf scale
diff --git a/tests/ref/fate/zmbv-8bit b/tests/ref/fate/zmbv-8bit
index 7c2fab691f..9a7c96cb32 100644
--- a/tests/ref/fate/zmbv-8bit
+++ b/tests/ref/fate/zmbv-8bit
@@ -278,4 +278,3 @@
0, 272, 272, 1, 192000, 0xd08e49d1
0, 273, 273, 1, 192000, 0xd08e49d1
0, 274, 274, 1, 192000, 0xd08e49d1
-0, 275, 275, 1, 192000, 0x1f34135f
--
2.42.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] fate/screen: workaround test failure on mac M1
2023-10-08 13:17 [FFmpeg-devel] [PATCH] fate/screen: workaround test failure on mac M1 Zhao Zhili
@ 2023-10-08 13:22 ` Zhao Zhili
2023-10-16 12:29 ` Zhao Zhili
2023-10-16 17:40 ` Andreas Rheinhardt
1 sibling, 1 reply; 5+ messages in thread
From: Zhao Zhili @ 2023-10-08 13:22 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On Oct 8, 2023, at 21:17, Zhao Zhili <quinkblack@foxmail.com> wrote:
>
> From: Zhao Zhili <zhilizhao@tencent.com>
>
> The last frame is corrupted. It has different results on different
> platform.
> ---
> tests/fate/screen.mak | 3 ++-
> tests/ref/fate/zmbv-8bit | 1 -
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/fate/screen.mak b/tests/fate/screen.mak
> index bd6d228544..1c92935d23 100644
> --- a/tests/fate/screen.mak
> +++ b/tests/fate/screen.mak
> @@ -117,7 +117,8 @@ FATE_SCREEN += $(FATE_VMNC-yes)
> fate-vmnc: $(FATE_VMNC-yes)
>
> FATE_ZMBV += fate-zmbv-8bit
> -fate-zmbv-8bit: CMD = framecrc -i $(TARGET_SAMPLES)/zmbv/wc2_001-partial.avi -an -pix_fmt rgb24 -vf scale
> +# The last frame is corrupted.
> +fate-zmbv-8bit: CMD = framecrc -i $(TARGET_SAMPLES)/zmbv/wc2_001-partial.avi -an -frames:v 275 -pix_fmt rgb24 -vf scale
>
> FATE_ZMBV += fate-zmbv-15bit
> fate-zmbv-15bit: CMD = framecrc -i $(TARGET_SAMPLES)/zmbv/zmbv_15bit.avi -pix_fmt rgb24 -t 25 -vf scale
> diff --git a/tests/ref/fate/zmbv-8bit b/tests/ref/fate/zmbv-8bit
> index 7c2fab691f..9a7c96cb32 100644
> --- a/tests/ref/fate/zmbv-8bit
> +++ b/tests/ref/fate/zmbv-8bit
> @@ -278,4 +278,3 @@
> 0, 272, 272, 1, 192000, 0xd08e49d1
> 0, 273, 273, 1, 192000, 0xd08e49d1
> 0, 274, 274, 1, 192000, 0xd08e49d1
> -0, 275, 275, 1, 192000, 0x1f34135f
> --
> 2.42.0
Another method is drop the corrupted frame by decoder. It sounds better, but I’m afraid it may break some use cases.
https://ffmpeg.org/pipermail/ffmpeg-devel/2023-October/315557.html
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] fate/screen: workaround test failure on mac M1
2023-10-08 13:22 ` Zhao Zhili
@ 2023-10-16 12:29 ` Zhao Zhili
0 siblings, 0 replies; 5+ messages in thread
From: Zhao Zhili @ 2023-10-16 12:29 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> On Oct 8, 2023, at 21:22, Zhao Zhili <quinkblack@foxmail.com> wrote:
>
>>
>> On Oct 8, 2023, at 21:17, Zhao Zhili <quinkblack@foxmail.com> wrote:
>>
>> From: Zhao Zhili <zhilizhao@tencent.com>
>>
>> The last frame is corrupted. It has different results on different
>> platform.
>> ---
>> tests/fate/screen.mak | 3 ++-
>> tests/ref/fate/zmbv-8bit | 1 -
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/fate/screen.mak b/tests/fate/screen.mak
>> index bd6d228544..1c92935d23 100644
>> --- a/tests/fate/screen.mak
>> +++ b/tests/fate/screen.mak
>> @@ -117,7 +117,8 @@ FATE_SCREEN += $(FATE_VMNC-yes)
>> fate-vmnc: $(FATE_VMNC-yes)
>>
>> FATE_ZMBV += fate-zmbv-8bit
>> -fate-zmbv-8bit: CMD = framecrc -i $(TARGET_SAMPLES)/zmbv/wc2_001-partial.avi -an -pix_fmt rgb24 -vf scale
>> +# The last frame is corrupted.
>> +fate-zmbv-8bit: CMD = framecrc -i $(TARGET_SAMPLES)/zmbv/wc2_001-partial.avi -an -frames:v 275 -pix_fmt rgb24 -vf scale
>>
>> FATE_ZMBV += fate-zmbv-15bit
>> fate-zmbv-15bit: CMD = framecrc -i $(TARGET_SAMPLES)/zmbv/zmbv_15bit.avi -pix_fmt rgb24 -t 25 -vf scale
>> diff --git a/tests/ref/fate/zmbv-8bit b/tests/ref/fate/zmbv-8bit
>> index 7c2fab691f..9a7c96cb32 100644
>> --- a/tests/ref/fate/zmbv-8bit
>> +++ b/tests/ref/fate/zmbv-8bit
>> @@ -278,4 +278,3 @@
>> 0, 272, 272, 1, 192000, 0xd08e49d1
>> 0, 273, 273, 1, 192000, 0xd08e49d1
>> 0, 274, 274, 1, 192000, 0xd08e49d1
>> -0, 275, 275, 1, 192000, 0x1f34135f
>> --
>> 2.42.0
>
> Another method is drop the corrupted frame by decoder. It sounds better, but I’m afraid it may break some use cases.
>
> https://ffmpeg.org/pipermail/ffmpeg-devel/2023-October/315557.html
Will apply this version tomorrow.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] fate/screen: workaround test failure on mac M1
2023-10-08 13:17 [FFmpeg-devel] [PATCH] fate/screen: workaround test failure on mac M1 Zhao Zhili
2023-10-08 13:22 ` Zhao Zhili
@ 2023-10-16 17:40 ` Andreas Rheinhardt
2023-10-16 17:52 ` Zhao Zhili
1 sibling, 1 reply; 5+ messages in thread
From: Andreas Rheinhardt @ 2023-10-16 17:40 UTC (permalink / raw)
To: ffmpeg-devel
Zhao Zhili:
> From: Zhao Zhili <zhilizhao@tencent.com>
>
> The last frame is corrupted. It has different results on different
> platform.
> ---
> tests/fate/screen.mak | 3 ++-
> tests/ref/fate/zmbv-8bit | 1 -
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/fate/screen.mak b/tests/fate/screen.mak
> index bd6d228544..1c92935d23 100644
> --- a/tests/fate/screen.mak
> +++ b/tests/fate/screen.mak
> @@ -117,7 +117,8 @@ FATE_SCREEN += $(FATE_VMNC-yes)
> fate-vmnc: $(FATE_VMNC-yes)
>
> FATE_ZMBV += fate-zmbv-8bit
> -fate-zmbv-8bit: CMD = framecrc -i $(TARGET_SAMPLES)/zmbv/wc2_001-partial.avi -an -pix_fmt rgb24 -vf scale
> +# The last frame is corrupted.
> +fate-zmbv-8bit: CMD = framecrc -i $(TARGET_SAMPLES)/zmbv/wc2_001-partial.avi -an -frames:v 275 -pix_fmt rgb24 -vf scale
>
> FATE_ZMBV += fate-zmbv-15bit
> fate-zmbv-15bit: CMD = framecrc -i $(TARGET_SAMPLES)/zmbv/zmbv_15bit.avi -pix_fmt rgb24 -t 25 -vf scale
> diff --git a/tests/ref/fate/zmbv-8bit b/tests/ref/fate/zmbv-8bit
> index 7c2fab691f..9a7c96cb32 100644
> --- a/tests/ref/fate/zmbv-8bit
> +++ b/tests/ref/fate/zmbv-8bit
> @@ -278,4 +278,3 @@
> 0, 272, 272, 1, 192000, 0xd08e49d1
> 0, 273, 273, 1, 192000, 0xd08e49d1
> 0, 274, 274, 1, 192000, 0xd08e49d1
> -0, 275, 275, 1, 192000, 0x1f34135f
What code exactly leads to different outcomes for different systems?
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH] fate/screen: workaround test failure on mac M1
2023-10-16 17:40 ` Andreas Rheinhardt
@ 2023-10-16 17:52 ` Zhao Zhili
0 siblings, 0 replies; 5+ messages in thread
From: Zhao Zhili @ 2023-10-16 17:52 UTC (permalink / raw)
To: 'FFmpeg development discussions and patches'
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Andreas Rheinhardt
> Sent: 2023年10月17日 1:41
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH] fate/screen: workaround test failure on mac M1
>
> Zhao Zhili:
> > From: Zhao Zhili <zhilizhao@tencent.com>
> >
> > The last frame is corrupted. It has different results on different
> > platform.
> > ---
> > tests/fate/screen.mak | 3 ++-
> > tests/ref/fate/zmbv-8bit | 1 -
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/fate/screen.mak b/tests/fate/screen.mak
> > index bd6d228544..1c92935d23 100644
> > --- a/tests/fate/screen.mak
> > +++ b/tests/fate/screen.mak
> > @@ -117,7 +117,8 @@ FATE_SCREEN += $(FATE_VMNC-yes)
> > fate-vmnc: $(FATE_VMNC-yes)
> >
> > FATE_ZMBV += fate-zmbv-8bit
> > -fate-zmbv-8bit: CMD = framecrc -i $(TARGET_SAMPLES)/zmbv/wc2_001-partial.avi -an -pix_fmt rgb24 -vf scale
> > +# The last frame is corrupted.
> > +fate-zmbv-8bit: CMD = framecrc -i $(TARGET_SAMPLES)/zmbv/wc2_001-partial.avi -an -frames:v 275 -pix_fmt rgb24 -vf scale
> >
> > FATE_ZMBV += fate-zmbv-15bit
> > fate-zmbv-15bit: CMD = framecrc -i $(TARGET_SAMPLES)/zmbv/zmbv_15bit.avi -pix_fmt rgb24 -t 25 -vf scale
> > diff --git a/tests/ref/fate/zmbv-8bit b/tests/ref/fate/zmbv-8bit
> > index 7c2fab691f..9a7c96cb32 100644
> > --- a/tests/ref/fate/zmbv-8bit
> > +++ b/tests/ref/fate/zmbv-8bit
> > @@ -278,4 +278,3 @@
> > 0, 272, 272, 1, 192000, 0xd08e49d1
> > 0, 273, 273, 1, 192000, 0xd08e49d1
> > 0, 274, 274, 1, 192000, 0xd08e49d1
> > -0, 275, 275, 1, 192000, 0x1f34135f
>
> What code exactly leads to different outcomes for different systems?
I guess the difference comes from zlib decompress corrupted data.
Another patch for reference:
https://patchwork.ffmpeg.org/project/ffmpeg/patch/tencent_446495D6890EAEB36546930A084FD3FF1305@qq.com/
>
> - Andreas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-10-16 17:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-08 13:17 [FFmpeg-devel] [PATCH] fate/screen: workaround test failure on mac M1 Zhao Zhili
2023-10-08 13:22 ` Zhao Zhili
2023-10-16 12:29 ` Zhao Zhili
2023-10-16 17:40 ` Andreas Rheinhardt
2023-10-16 17:52 ` Zhao Zhili
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git