From: Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] aarch64/h26x: Add put_hevc_pel_bi_w_pixels
Date: Tue, 29 Apr 2025 16:09:34 +0800
Message-ID: <tencent_804DD04FECD54FA71E38B496764D11A03407@qq.com> (raw)
In-Reply-To: <baa3bb48-a390-96b0-d0ea-d9c39e1027a2@martin.st>
> On Apr 25, 2025, at 16:29, Martin Storsjö <martin@martin.st> wrote:
>
> On Wed, 23 Apr 2025, Zhao Zhili wrote:
>
>> From: Zhao Zhili <zhilizhao@tencent.com>
>>
>> On rpi5 (A76):
>>
>> put_hevc_pel_bi_w_pixels4_8_c: 90.0 ( 1.00x)
>> put_hevc_pel_bi_w_pixels4_8_neon: 34.1 ( 2.64x)
>> put_hevc_pel_bi_w_pixels6_8_c: 188.3 ( 1.00x)
>> put_hevc_pel_bi_w_pixels6_8_neon: 73.5 ( 2.56x)
>> put_hevc_pel_bi_w_pixels8_8_c: 327.1 ( 1.00x)
>> put_hevc_pel_bi_w_pixels8_8_neon: 75.8 ( 4.32x)
>> put_hevc_pel_bi_w_pixels12_8_c: 728.8 ( 1.00x)
>> put_hevc_pel_bi_w_pixels12_8_neon: 186.1 ( 3.92x)
>> put_hevc_pel_bi_w_pixels16_8_c: 1288.1 ( 1.00x)
>> put_hevc_pel_bi_w_pixels16_8_neon: 268.5 ( 4.80x)
>> put_hevc_pel_bi_w_pixels24_8_c: 2855.5 ( 1.00x)
>> put_hevc_pel_bi_w_pixels24_8_neon: 723.8 ( 3.95x)
>> put_hevc_pel_bi_w_pixels32_8_c: 5095.3 ( 1.00x)
>> put_hevc_pel_bi_w_pixels32_8_neon: 1165.0 ( 4.37x)
>> put_hevc_pel_bi_w_pixels48_8_c: 11521.5 ( 1.00x)
>> put_hevc_pel_bi_w_pixels48_8_neon: 2856.0 ( 4.03x)
>> put_hevc_pel_bi_w_pixels64_8_c: 21020.5 ( 1.00x)
>> put_hevc_pel_bi_w_pixels64_8_neon: 4699.1 ( 4.47x)
>> ---
>> libavcodec/aarch64/h26x/dsp.h | 5 +
>> libavcodec/aarch64/h26x/epel_neon.S | 373 ++++++++++++++++++++++
>> libavcodec/aarch64/hevcdsp_init_aarch64.c | 13 +
>> 3 files changed, 391 insertions(+)
>
> This looks good overall, thanks!
>
> It's quite regrettable how many duplicates of near-identical functions there are in the h26x qpel/epel code; ideally we should be able to produce most of these function variants with some sort of template instead of having them all duplicated (with minor style differences).
It definitely needs a proper refactoring/cleanup, I will address it as time permits.
>
> // Martin
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org <mailto:ffmpeg-devel-request@ffmpeg.org> with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-04-29 8:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 16:31 Zhao Zhili
2025-04-25 8:29 ` Martin Storsjö
2025-04-29 8:09 ` Zhao Zhili [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_804DD04FECD54FA71E38B496764D11A03407@qq.com \
--to=quinkblack-at-foxmail.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git