* [FFmpeg-devel] [PATCH] avcodec/wasm/hevc: fix typo in butterfly macro
@ 2025-12-04 4:02 Xia Tao via ffmpeg-devel
2025-12-04 4:21 ` [FFmpeg-devel] " Zhao Zhili via ffmpeg-devel
0 siblings, 1 reply; 2+ messages in thread
From: Xia Tao via ffmpeg-devel @ 2025-12-04 4:02 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Xia Tao
>From 3ae4384673a1a2d4482d959ce3a95167bc2da056 Mon Sep 17 00:00:00 2001
From: Xia Tao <xiatao@gmail.com>
Date: Thu, 4 Dec 2025 11:49:50 +0800
Subject: [PATCH] avcodec/wasm/hevc: fix typo in butterfly macro
Signed-off-by: Xia Tao <xiatao@gmail.com>
---
libavcodec/wasm/hevc/idct.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libavcodec/wasm/hevc/idct.c b/libavcodec/wasm/hevc/idct.c
index 828fc26a49..f2b04f307c 100644
--- a/libavcodec/wasm/hevc/idct.c
+++ b/libavcodec/wasm/hevc/idct.c
@@ -279,7 +279,7 @@ void ff_hevc_idct_8x8_10_simd128(int16_t *coeffs,
int col_limit)
x1 += x2; \
x3 += x2; \
-#define bufferfly(e, o, p, m) \
+#define butterfly(e, o, p, m) \
p = wasm_i32x4_add(e, o); \
m = wasm_i32x4_sub(e, o); \
@@ -309,10 +309,10 @@ static void tr16_8x4(v128_t in0, v128_t in1,
v128_t in2, v128_t in3,
v30 = wasm_i32x4_add(v30, wasm_i32x4_extmul_high_i16x8(in3, trans[5]));
v31 = wasm_i32x4_sub(v31, wasm_i32x4_extmul_high_i16x8(in3, trans[4]));
- bufferfly(v24, v28, v16, v23);
- bufferfly(v25, v29, v17, v22);
- bufferfly(v26, v30, v18, v21);
- bufferfly(v27, v31, v19, v20);
+ butterfly(v24, v28, v16, v23);
+ butterfly(v25, v29, v17, v22);
+ butterfly(v26, v30, v18, v21);
+ butterfly(v27, v31, v19, v20);
sp += offset;
wasm_v128_store(sp, v16); sp += 16;
--
2.52.0
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
^ permalink raw reply [flat|nested] 2+ messages in thread* [FFmpeg-devel] Re: [PATCH] avcodec/wasm/hevc: fix typo in butterfly macro
2025-12-04 4:02 [FFmpeg-devel] [PATCH] avcodec/wasm/hevc: fix typo in butterfly macro Xia Tao via ffmpeg-devel
@ 2025-12-04 4:21 ` Zhao Zhili via ffmpeg-devel
0 siblings, 0 replies; 2+ messages in thread
From: Zhao Zhili via ffmpeg-devel @ 2025-12-04 4:21 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Xia Tao, Zhao Zhili
> On Dec 4, 2025, at 12:02, Xia Tao via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
>
>> From 3ae4384673a1a2d4482d959ce3a95167bc2da056 Mon Sep 17 00:00:00 2001
> From: Xia Tao <xiatao@gmail.com>
> Date: Thu, 4 Dec 2025 11:49:50 +0800
> Subject: [PATCH] avcodec/wasm/hevc: fix typo in butterfly macro
Could you send a PR on https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls ? Thanks!
>
> Signed-off-by: Xia Tao <xiatao@gmail.com>
> ---
> libavcodec/wasm/hevc/idct.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/libavcodec/wasm/hevc/idct.c b/libavcodec/wasm/hevc/idct.c
> index 828fc26a49..f2b04f307c 100644
> --- a/libavcodec/wasm/hevc/idct.c
> +++ b/libavcodec/wasm/hevc/idct.c
> @@ -279,7 +279,7 @@ void ff_hevc_idct_8x8_10_simd128(int16_t *coeffs,
> int col_limit)
> x1 += x2; \
> x3 += x2; \
>
> -#define bufferfly(e, o, p, m) \
> +#define butterfly(e, o, p, m) \
> p = wasm_i32x4_add(e, o); \
> m = wasm_i32x4_sub(e, o); \
>
> @@ -309,10 +309,10 @@ static void tr16_8x4(v128_t in0, v128_t in1,
> v128_t in2, v128_t in3,
> v30 = wasm_i32x4_add(v30, wasm_i32x4_extmul_high_i16x8(in3, trans[5]));
> v31 = wasm_i32x4_sub(v31, wasm_i32x4_extmul_high_i16x8(in3, trans[4]));
>
> - bufferfly(v24, v28, v16, v23);
> - bufferfly(v25, v29, v17, v22);
> - bufferfly(v26, v30, v18, v21);
> - bufferfly(v27, v31, v19, v20);
> + butterfly(v24, v28, v16, v23);
> + butterfly(v25, v29, v17, v22);
> + butterfly(v26, v30, v18, v21);
> + butterfly(v27, v31, v19, v20);
>
> sp += offset;
> wasm_v128_store(sp, v16); sp += 16;
> --
> 2.52.0
> _______________________________________________
> ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
> To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-04 4:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-04 4:02 [FFmpeg-devel] [PATCH] avcodec/wasm/hevc: fix typo in butterfly macro Xia Tao via ffmpeg-devel
2025-12-04 4:21 ` [FFmpeg-devel] " Zhao Zhili via ffmpeg-devel
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git