Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Zhao Zhili via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Xia Tao <xiatao@gmail.com>, Zhao Zhili <quinkblack@foxmail.com>
Subject: [FFmpeg-devel] Re: [PATCH] avcodec/wasm/hevc: fix typo in butterfly macro
Date: Thu, 4 Dec 2025 12:21:50 +0800
Message-ID: <tencent_7D32509266CFE7F46A8B531EDC65CB92A606@qq.com> (raw)
In-Reply-To: <CAE=QceOjTY3CaAxrBo8Yj6p8iU3hORhkzf-bJoJ=aMw54s99Pg@mail.gmail.com>



> On Dec 4, 2025, at 12:02, Xia Tao via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
> 
>> From 3ae4384673a1a2d4482d959ce3a95167bc2da056 Mon Sep 17 00:00:00 2001
> From: Xia Tao <xiatao@gmail.com>
> Date: Thu, 4 Dec 2025 11:49:50 +0800
> Subject: [PATCH] avcodec/wasm/hevc: fix typo in butterfly macro

Could you send a PR on https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls ? Thanks!

> 
> Signed-off-by: Xia Tao <xiatao@gmail.com>
> ---
> libavcodec/wasm/hevc/idct.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/libavcodec/wasm/hevc/idct.c b/libavcodec/wasm/hevc/idct.c
> index 828fc26a49..f2b04f307c 100644
> --- a/libavcodec/wasm/hevc/idct.c
> +++ b/libavcodec/wasm/hevc/idct.c
> @@ -279,7 +279,7 @@ void ff_hevc_idct_8x8_10_simd128(int16_t *coeffs,
> int col_limit)
>     x1 += x2;                                   \
>     x3 += x2;                                   \
> 
> -#define bufferfly(e, o, p, m)   \
> +#define butterfly(e, o, p, m)   \
>     p = wasm_i32x4_add(e, o);   \
>     m = wasm_i32x4_sub(e, o);   \
> 
> @@ -309,10 +309,10 @@ static void tr16_8x4(v128_t in0, v128_t in1,
> v128_t in2, v128_t in3,
>     v30 = wasm_i32x4_add(v30, wasm_i32x4_extmul_high_i16x8(in3, trans[5]));
>     v31 = wasm_i32x4_sub(v31, wasm_i32x4_extmul_high_i16x8(in3, trans[4]));
> 
> -    bufferfly(v24, v28, v16, v23);
> -    bufferfly(v25, v29, v17, v22);
> -    bufferfly(v26, v30, v18, v21);
> -    bufferfly(v27, v31, v19, v20);
> +    butterfly(v24, v28, v16, v23);
> +    butterfly(v25, v29, v17, v22);
> +    butterfly(v26, v30, v18, v21);
> +    butterfly(v27, v31, v19, v20);
> 
>     sp += offset;
>     wasm_v128_store(sp, v16); sp += 16;
> -- 
> 2.52.0
> _______________________________________________
> ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
> To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

      reply	other threads:[~2025-12-04  4:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-04  4:02 [FFmpeg-devel] " Xia Tao via ffmpeg-devel
2025-12-04  4:21 ` Zhao Zhili via ffmpeg-devel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_7D32509266CFE7F46A8B531EDC65CB92A606@qq.com \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=quinkblack@foxmail.com \
    --cc=xiatao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git