Re: [FFmpeg-devel] [PATCH 3/3] tests/hevc: Fix concat input when running in MSYS2 shell

[Zhao Zhili <quinkblack-at-foxmail.com@ffmpeg.org>]

> On May 13, 2025, at 01:04, softworkz . <softworkz-at-hotmail.com@ffmpeg.org> wrote:
> 
> 
> 
>> -----Original Message-----
>> From: Zhao Zhili <quinkblack@foxmail.com>
>> Sent: Montag, 12. Mai 2025 18:53
>> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
>> Cc: softworkz <softworkz@hotmail.com>
>> Subject: Re: [FFmpeg-devel] [PATCH 3/3] tests/hevc: Fix concat input when
>> running in MSYS2 shell
>> 
>> 
>> 
>>> On May 12, 2025, at 17:59, softworkz <ffmpegagent@gmail.com> wrote:
>>> 
>>> From: softworkz <softworkz@hotmail.com>
>>> 
>>> MSYS2 considers the colon (:) as path separator (=separating multiple
>>> paths) and thinks it needs to convert it to a Windows
>>> path separator (;).
>>> 
>>> Setting the MSYS2_ARG_CONV_EXCL environment variable
>>> keeps MSYS2 from doing this replacement.
>> 
>> Doesn’t work for me.
>> 
>> The test failed if when set
>> 
>> —samples=/home/quink/ffmpeg-fate-sample
>> 
>> but success when set
>> 
>> —samples=D:/bin/msys/home/quink/ffmpeg-fate-sample

> 
> Another case that this patch fixes is
> 
> —samples=../fate-suite
> 
>> Other test case don’t have this issue.
> 
> Because no other test uses the concat: protocol.
> 
>> With a single input,
>> msys can convert the unix path to Windows path before pass
>> to ffmpeg, but failed for concat.
> 
> The problem is the colon behind concat, which it considers to 
> be a separator and hence changes it to a semicolon.
> When the samples-path starts with a slash, it might behave 
> differently again, no sure.
> 
> I'll add a note to the commit message, explaining which cases 
> it fixes.

OK. Some other test cases don't work with D:/bin/msys/home/quink/ffmpeg-fate-sample.
Only relative path with the patch can make fate success.

It’s a tough work experience on Windows.

> 
> Thanks,
> sw
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".