* [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Correctly set trc
@ 2024-08-01 23:31 gnattu via ffmpeg-devel
2024-08-02 2:27 ` Zhao Zhili
0 siblings, 1 reply; 2+ messages in thread
From: gnattu via ffmpeg-devel @ 2024-08-01 23:31 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: gnattu
The color trc key was assigned a color primaries value which causes
the resulting colorspace is always SDR.
Fixes #10884.
Signed-off-by: Gnattu OC <gnattuoc@me.com>
---
libavutil/hwcontext_videotoolbox.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c
index 1794459943..80eaab64f0 100644
--- a/libavutil/hwcontext_videotoolbox.c
+++ b/libavutil/hwcontext_videotoolbox.c
@@ -597,7 +597,7 @@ static int vt_pixbuf_set_colorspace(void *log_ctx,
colortrc = av_map_videotoolbox_color_trc_from_av(src->color_trc);
if (colortrc)
CVBufferSetAttachment(pixbuf, kCVImageBufferTransferFunctionKey,
- colorpri, kCVAttachmentMode_ShouldPropagate);
+ colortrc, kCVAttachmentMode_ShouldPropagate);
else {
CVBufferRemoveAttachment(pixbuf, kCVImageBufferTransferFunctionKey);
if (src->color_trc != AVCOL_TRC_UNSPECIFIED)
--
2.39.3 (Apple Git-146)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Correctly set trc
2024-08-01 23:31 [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Correctly set trc gnattu via ffmpeg-devel
@ 2024-08-02 2:27 ` Zhao Zhili
0 siblings, 0 replies; 2+ messages in thread
From: Zhao Zhili @ 2024-08-02 2:27 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: gnattu
> On Aug 2, 2024, at 07:31, gnattu via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
>
> The color trc key was assigned a color primaries value which causes
> the resulting colorspace is always SDR.
>
> Fixes #10884.
>
> Signed-off-by: Gnattu OC <gnattuoc@me.com>
> ---
> libavutil/hwcontext_videotoolbox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c
> index 1794459943..80eaab64f0 100644
> --- a/libavutil/hwcontext_videotoolbox.c
> +++ b/libavutil/hwcontext_videotoolbox.c
> @@ -597,7 +597,7 @@ static int vt_pixbuf_set_colorspace(void *log_ctx,
> colortrc = av_map_videotoolbox_color_trc_from_av(src->color_trc);
> if (colortrc)
> CVBufferSetAttachment(pixbuf, kCVImageBufferTransferFunctionKey,
> - colorpri, kCVAttachmentMode_ShouldPropagate);
> + colortrc, kCVAttachmentMode_ShouldPropagate);
> else {
> CVBufferRemoveAttachment(pixbuf, kCVImageBufferTransferFunctionKey);
> if (src->color_trc != AVCOL_TRC_UNSPECIFIED)
> --
> 2.39.3 (Apple Git-146)
>
Thanks for catching the typo, applied.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-02 2:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-01 23:31 [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Correctly set trc gnattu via ffmpeg-devel
2024-08-02 2:27 ` Zhao Zhili
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git