From: Zhao Zhili <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: gnattu <gnattuoc@me.com>
Subject: Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Correctly set trc
Date: Fri, 2 Aug 2024 10:27:55 +0800
Message-ID: <tencent_7C660F109026CBE7CDAABC5301DC4D4B8306@qq.com> (raw)
In-Reply-To: <20240801233103.3451-1-gnattuoc@me.com>
> On Aug 2, 2024, at 07:31, gnattu via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
>
> The color trc key was assigned a color primaries value which causes
> the resulting colorspace is always SDR.
>
> Fixes #10884.
>
> Signed-off-by: Gnattu OC <gnattuoc@me.com>
> ---
> libavutil/hwcontext_videotoolbox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c
> index 1794459943..80eaab64f0 100644
> --- a/libavutil/hwcontext_videotoolbox.c
> +++ b/libavutil/hwcontext_videotoolbox.c
> @@ -597,7 +597,7 @@ static int vt_pixbuf_set_colorspace(void *log_ctx,
> colortrc = av_map_videotoolbox_color_trc_from_av(src->color_trc);
> if (colortrc)
> CVBufferSetAttachment(pixbuf, kCVImageBufferTransferFunctionKey,
> - colorpri, kCVAttachmentMode_ShouldPropagate);
> + colortrc, kCVAttachmentMode_ShouldPropagate);
> else {
> CVBufferRemoveAttachment(pixbuf, kCVImageBufferTransferFunctionKey);
> if (src->color_trc != AVCOL_TRC_UNSPECIFIED)
> --
> 2.39.3 (Apple Git-146)
>
Thanks for catching the typo, applied.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-08-02 2:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 23:31 gnattu via ffmpeg-devel
2024-08-02 2:27 ` Zhao Zhili [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_7C660F109026CBE7CDAABC5301DC4D4B8306@qq.com \
--to=quinkblack@foxmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=gnattuoc@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git