From: "\"zhilizhao(赵志立)\"" <quinkblack@foxmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] Request: consider use codec id "sowt" instead of "ipcm" for LPCM_S16LE in mp4 muxer
Date: Wed, 24 May 2023 10:17:51 +0800
Message-ID: <tencent_7BC09A9C40249A4B9F52AB174E1770172D08@qq.com> (raw)
In-Reply-To: <39118c1b-50b2-7d8b-4df8-ca7619ef3878@josephcz.xyz>
> On May 24, 2023, at 08:45, Joseph Chris <joseph@josephcz.xyz> wrote:
>
> Hello,
>
> I am writing this mail for request consider use codec id "sowt" instead of "ipcm" for AV_CODEC_ID_PCM_S16LE in mp4 muxer, and AV_CODEC_ID_PCM_S16BE accordingly. This only needs a minor change on code:
>
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index a9c8e104f0..2b984789f5 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -7816,6 +7816,9 @@ static const AVCodecTag codec_mp4_tags[] = {
> { AV_CODEC_ID_TTML, MOV_MP4_TTML_TAG },
> { AV_CODEC_ID_TTML, MOV_ISMV_TTML_TAG },
>
> + // To improve compatibility
> + { AV_CODEC_ID_PCM_S16BE, MKTAG('t', 'w', 'o', 's') },
> + { AV_CODEC_ID_PCM_S16LE, MKTAG('s', 'o', 'w', 't') },
> /* ISO/IEC 23003-5 integer formats */
> { AV_CODEC_ID_PCM_S16BE, MOV_MP4_IPCM_TAG },
> { AV_CODEC_ID_PCM_S16LE, MOV_MP4_IPCM_TAG },
>
Nope, they are tags of quicktime format, not ISO base media file format.
>
> Many players like VLC and potplayer, can recognize "sowt", but they can not recognize "ipcm" or "lpcm" (lpcm is defined on mp4ra). Even ffmpeg it self (current git master, d81558) can't recognize it. So this change can improve compatibility and interoperability of ffmpeg.
I can’t find d81558.
>
> This change is related to #9219 and #10185.
They have been fixed. I will update the status.
>
> This change fails fate-mov-mp4-pcm but passes all other tests. fate-mov-mp4-pcm checks the MD5 of output file, as the codec id changes also makes the MD5 change. So we have to rewrite the test while changing the code.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-05-24 2:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 0:45 Joseph Chris
2023-05-24 2:17 ` "zhilizhao(赵志立)" [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_7BC09A9C40249A4B9F52AB174E1770172D08@qq.com \
--to=quinkblack@foxmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git