From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 7F0F14CD04 for ; Tue, 25 Feb 2025 03:40:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 12DC568CA60; Tue, 25 Feb 2025 05:40:09 +0200 (EET) Received: from out203-205-221-209.mail.qq.com (out203-205-221-209.mail.qq.com [203.205.221.209]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6ADD868C462 for ; Tue, 25 Feb 2025 05:40:00 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1740454791; bh=RbsoQzhs6tMoRskZX/psEMHrGIbjT/F2fNEhdmkVclc=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=bm65MS7lJx0nvhTcthpLJAy5L688a8QVwPTLvlmHRp/7Ki8aIENqa1Tmo/qz0G8sk fO07MQUC5+fwAUjupot3VLpDLRSxdRotI1M7QOWzziN9/xf2QtA2VQ7y4hY3kFtKXk tujoU3PH4RmGjXwHGt1Tj4tbaOn73dhMRF7x3A9M= Received: from smtpclient.apple ([119.147.10.242]) by newxmesmtplogicsvrsza29-0.qq.com (NewEsmtp) with SMTP id 9F22047B; Tue, 25 Feb 2025 11:39:50 +0800 X-QQ-mid: xmsmtpt1740454790twxeeeyqk Message-ID: X-QQ-XMAILINFO: MbMMSJ8sGwqsmJFCFdaLMpLqZV93pys11CLLK2MGxvBjP15sQsjax7nDr+dHU4 VQ14Vc+R5CjK48nSgsK2x+qo0wAvMzRA1gSVDZenct9gpbyyDlwrqHCcikbFF/RhxFSV7d/WxIaN 3Xtyb63tz74+s3czGoKLwkQRLiRirdmbu5Vvz5jY7/5PjO8wjEVbgYoT3CheecTCtqisnl1D2yrQ l87JMqwYGYgEVLlPkgALmw6AiVTEZpouVh7IKiRnH1kgjTR1PEZoLZmYI5cc2wVbszWTeP0J0v4A oPAss5TgYAoEE2GEOLnmZApFev+drUXpX/lJ0NYVw1Gf1l0uDXz47Jmwx57N9tTxk8oqCfB32iEi 5FWy/xbr10qcCR2HXbdv5nGARoe3d99sqyCqCHHNWblCeZ2dApots/yYUrbqJ9MsDXu+4r/U93mn p8xYf0IB9V3yUEzSOE2izl8mitQxGChmgoT22IJ4L5muLa0596c4Uk/hi9WFSmxEnWNbpMXIom5T B4glaB5NOOBy5J9aX9dZO7aszisQphikFapkpx2Sya+4AjLjgXobFyC3+gk8HpT59YWVnOUnDrFt fH40GfSLU0IWX2xrySQSFl6dbpS8LaINJjuGrWr9Ax1HpvMNrlzcS215hkpEcRzGom5khlEHUcME COTBWpAgto9UNmuxbjs6HYaccD72nZrOgfz4D1im1axwsYjO0cID0oVLtHhv2ufrAU4Iy55tQOYo TfgcaY/KUtTg73lpv79Fggtkr5mLyB0nZZawRNRSL0oJ8torov0HasFxA8bmfwQhx8dS2BuMvXVk SBT63oXnkP2Q5zpm0+j2wZvsVA3a+g93Sb0nGMPcDtdo94XeFwrEsCVes+5YhrrD4bQEinGXEHnr beI1rwgT5dQPC3NKe7tQFeEZJmTK+k6nd31aHI4iiU9ySy/xgFM2OkJU8BelxJ3Ky2SGaoOvsHGi gDhJ9r5hwc+FphEEyTHcPZzwx01fATu7S1VN+J5ZY= X-QQ-XMRINFO: NI4Ajvh11aEj8Xl/2s1/T8w= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\)) From: Zhao Zhili In-Reply-To: Date: Tue, 25 Feb 2025 11:39:40 +0800 X-OQ-MSGID: References: To: FFmpeg development discussions and patches X-Mailer: Apple Mail (2.3818.100.11.1.3) Subject: Re: [FFmpeg-devel] [PATCH] avcodec/ffv1_parser: Rename close to ffv1_close X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: James Almer Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Ping. > On Feb 19, 2025, at 20:33, Zhao Zhili wrote: > > From: Zhao Zhili > > This fixed wasm checkasm failure > > $ wasm-tools validate tests/checkasm/checkasm > error: wasisdk://v25.0/build/sysroot/wasi-libc-wasm32-wasip1-threads/libc-top-half/musl/src/stdio/__stdio_close.c:24:9 function `__stdio_close` failed to validate > > Caused by: > 0: func 4581 failed to validate > 1: type mismatch: expected i32 but nothing on stack (at offset 0x43b770) > > Since close is declared as static function, it's more like a bug > in wasi sdk, but we can workaround it easily. > --- > libavcodec/ffv1_parser.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/ffv1_parser.c b/libavcodec/ffv1_parser.c > index f36a5dfdbd..bf61e88a2e 100644 > --- a/libavcodec/ffv1_parser.c > +++ b/libavcodec/ffv1_parser.c > @@ -70,7 +70,7 @@ static int parse(AVCodecParserContext *s, > return buf_size; > } > > -static void close(AVCodecParserContext *s) > +static void ffv1_close(AVCodecParserContext *s) > { > FFV1ParseContext *p = s->priv_data; > > @@ -82,5 +82,5 @@ const AVCodecParser ff_ffv1_parser = { > .codec_ids = { AV_CODEC_ID_FFV1 }, > .priv_data_size = sizeof(FFV1ParseContext), > .parser_parse = parse, > - .parser_close = close, > + .parser_close = ffv1_close, > }; > -- > 2.46.0 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".