From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 51E2340B10 for ; Mon, 27 Dec 2021 06:38:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B4E7F68AFE9; Mon, 27 Dec 2021 08:38:42 +0200 (EET) Received: from out162-62-57-137.mail.qq.com (out162-62-57-137.mail.qq.com [162.62.57.137]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9ABED68AE64 for ; Mon, 27 Dec 2021 08:38:34 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1640587110; bh=fDrkgp0dX58dk/Pk/VpdRH0QnqwM3HVoL6F3qUXvUMs=; h=From:Subject:Date:References:To:In-Reply-To; b=Qh7m9lix1nWjz930PdEoDy2s7aOLz0g/2m4mIJSAFB7SwKQIBqXsAw6dBaQuosqzC 9PqpQ/LKZPrFsz433NQqhiF5ibGyjSPfcNPiF2vSVkKBp5rggXDhT0Wb+nKjlH+9cG 4LnO5I8CJYtjh1IonqDIrhy9Qel8jJNkpLI1kMTc= Received: from [192.168.255.10] ([113.108.77.64]) by newxmesmtplogicsvrszc8.qq.com (NewEsmtp) with SMTP id 99CB3CB0; Mon, 27 Dec 2021 14:38:28 +0800 X-QQ-mid: xmsmtpt1640587108t6kjwe3r1 Message-ID: X-QQ-XMAILINFO: Nb6LX7dsrQEk/Ojjv+SUgoydhVYb2ftaoJuUJ/SMIfT/RvHmkLY6rTlKpx9s/V RMCCFiOB+nzGKHZjNKSrHkXoX5NBT4FWSghEYUaJiRrDwRHThDdOcPlU1uf26erxgd6vOcs1lmWQ pMNp+4AtwQxgwKfhIpLsyEHFiBTSIVu0ukMTzLKm+IzC8vVBMVgrjsPCYvQbtLEUg2fpE0+3Vj5I paXqFjgBfJQHKlR3PYNtA0qIsyWCI29+l/1T9HmA2CVfb0RZk+HKqdzPuzTQJBqEP1R3iKPMVlrs bQOATAn/2sJ3nhUjX7iic8bPbGdBZGg1xCNUMySG6RowgdbDauWFfF43d45y5fYtvpCtUJ2r6DKb Ru5uhCXeuIkQEXLVatvMljjcz2v2V/Q+osWgIpDonSrUA/g0YcJunm8yh+I9i0o+Uhq/kIdV3hvA UbLgLrq70vz8VlhXdXYfse6ITi6UF1mmYN3ejUKCt6QEHHw0UzSFz1dCS/bhLAO/ffh2mUpXVaAf sUXkY/Ho1KrplN+wq3iPsJMzljr0iyMn6+vblhjeggEPs/cagacouBsD9FoUQlwmntu4ID2gvRbI Tqts/GoMxJ89sVb/mYbiVui3VY7eU9pET8aOqU8SCYkpVWU6kSXp9zesJHYbSBJjKeHCgfdf4t2m ubOWDcmxyNxso80kxZUysngvwsmahgZLNr+MPjPIJL42JpGfdod3m8TdOyLTdsg3+oYSuOdoDXu6 XFcBDGODn8byanIE4zakQUDKwkYpQXiq89V7VcqCoddgCV4mP7Symu5R9fE7tsZQZ8YnjQ7gt+HZ 49EsCsjeT/FCbsLisT3+fCaxrkXuhoGaAwkIfMFIMhEWZKsgUHreGp From: =?utf-8?B?InpoaWxpemhhbyjotbXlv5fnq4spIg==?= Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Mon, 27 Dec 2021 14:38:28 +0800 References: <20211227055711.63060-1-ffmpeg@gyani.pro> To: FFmpeg development discussions and patches In-Reply-To: <20211227055711.63060-1-ffmpeg@gyani.pro> X-OQ-MSGID: <7776BD9D-AF30-4CCD-8B7F-6E81B4A200D3@foxmail.com> X-Mailer: Apple Mail (2.3654.60.0.2.21) Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: correct 0 valued entries in stts X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Dec 27, 2021, at 1:57 PM, Gyan Doshi wrote: > > As per ISO 14496-12, sample duration of 0 is invalid except for > the last entry. > > In addition, also catch 0 value for sample count. > --- > libavformat/mov.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 2aed6e80ef..fb7406cdd6 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -2968,6 +2968,18 @@ static int mov_read_stts(MOVContext *c, AVIOContext *pb, MOVAtom atom) > av_log(c->fc, AV_LOG_TRACE, "sample_count=%d, sample_duration=%d\n", > sample_count, sample_duration); > > + if (!sample_count) { > + av_log(c->fc, AV_LOG_WARNING, "invalid sample count of 0 in stts for st %d at entry %u; changing to 1.\n", > + c->fc->nb_streams-1, i); No, zero is a valid value, for example, fragmented mp4. > + sc->stts_data[i].count = sample_count = 1; > + } > + > + if (!sample_duration && i != entries-1) { > + av_log(c->fc, AV_LOG_WARNING, "invalid sample delta of 0 in stts for st %d at entry %u; changing to 1.\n", > + c->fc->nb_streams-1, i); > + sc->stts_data[i].duration = sample_duration = 1; > + } > + > duration+=(int64_t)sample_duration*(uint64_t)sample_count; > total_sample_count+=sample_count; > } > -- > 2.33.0 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".