From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9D4B144F0E for ; Mon, 9 Jan 2023 08:46:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E85EC68BC3C; Mon, 9 Jan 2023 10:46:31 +0200 (EET) Received: from out162-62-57-64.mail.qq.com (out162-62-57-64.mail.qq.com [162.62.57.64]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7BF7D68B2C3 for ; Mon, 9 Jan 2023 10:46:23 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1673253981; bh=kJgj0e3KuefvtpVKSTOeIvcGGQI0QuIg1FpSqglS90M=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=rdwaE05v6HKrDGiWje7fA6WcUDNeWuWi3GHJGXJyLdE0FeUekqnWIE8u8UsLtOMgu xxxgQUAhYI3FulLVTFNl7rQfETowH2S4sdN7aFVkzxE5W9z6HYziUORmACd3VawFL9 VbVrqHCbyOHh90aLZQOMD9a5ZM1id3nLCe3mxr64= Received: from zhilizhao-LC3 ([59.37.125.102]) by newxmesmtplogicsvrszb9-0.qq.com (NewEsmtp) with SMTP id B93B5CFE; Mon, 09 Jan 2023 16:46:19 +0800 X-QQ-mid: xmsmtpt1673253979tpj6xfzrq Message-ID: X-QQ-XMAILINFO: NNoVXaH09J17fsW2XFK9tthqJGINv65V0VBXDFfHvv45qeB1eIMkjRenKCyhR6 ETb6teRDLl1NuNTwGS/LBAc6AWWwVVl/RvhrdBUCjfwzdU7tERLi61cep9cnUcX9HX2/eKdKjVLt eYradeIn3myq0K62pbMKWUJchRdXu8IXzGOx7gjh6ARvUZ2bFqhH9BKyltOozkxqQMrO+a7imtzp abO7284MzDNtcf2bbsFLhHjiuVqGCpIvx3RKWOVYTp2TUjtMnxns3nP12LOExAlAVnkU6FFSnBme S1hl4ysaqoKs2jEDHxqp00GjSCYpTKoeNpI/FpBMtjK3WnfsBAwcQXQ3htb9s49DlyBiTe+xXuI9 kpOvCpZ/kwvfiT483VumlGyJIMIBajoMi9DQ72CQXY+r6Lx0suJ+Nam3n1lp43JGVq38C5mY+bLm R3zWZvtTEdCQ72zNeNAjv7HKPtNG9EP49aHe5+yJiKFb/1GjVgl0usJ+OL8P704KBwycqr9Gva9g B/UhAfRC+mSDFBV5e195eiGcIdfsk7NQykyNJbBIU0dTyJeuxS8B/A26lzxPEadzvPOCtvHf15TF Oy5DV/sFw4hG69N11vXHziOZRbYnpAppRP95TnsrEYvW11/Aslm0vzLsEGvRB6cIPy4Awd4kMTeV sv5P8r3T/i8/xj6ljCXxy4Rmzb9lNe5d6B6oKKkq9ajD0tXX3m+jR7E7qYr8SMYscQOdTJpLc+5z QOEGehrAfGvZ1qYqFaX45Zc9k/VbrQWMNT6H7Ao1ZLsk5f0FjZorxMYMERpFSq38Hmf+0wll8bLS r1Glwja/gQ8x/QJvdZJUo8ZIuD7GP6z89Fkh2TESdBCaJB/Ah8FgzdXHjzAFJtKThJPSa1dcA6Wk UjQO3CI8A+xBOQP+4sevFX/ZM2lZxA3IzCBdDwQ5pE61T1uo4kPX5h5Ya8sZOm12fib8eWGv1iBa doXS5/KPt7oBnyOY1uaziXSn07EGfhV8go/qfFGLNSG7R31/9GWxubjzfxuzsj22pQRHgP9ctOyq vM40b6CA== X-OQ-MSGID: From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Tue, 10 Jan 2023 00:46:21 +0800 In-Reply-To: References: User-Agent: Evolution 3.36.5-0ubuntu1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h264_mp4toannexb: fix missing SPS/PPS to IDR frames X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 2022-12-29 at 01:20 +0800, Zhao Zhili wrote: > From: Zhao Zhili > > If there is a single group of SPS/PPS before an IDR frame, but no > SPS/PPS after that, we will miss the chance to reset > idr_sps_seen/idr_pps_seen. The result is missing SPS/PPS for all > IDR frames except the first one. > > Signed-off-by: Zhao Zhili > --- > libavcodec/h264_mp4toannexb_bsf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/h264_mp4toannexb_bsf.c > b/libavcodec/h264_mp4toannexb_bsf.c > index d11be455c2..bbdeca9c44 100644 > --- a/libavcodec/h264_mp4toannexb_bsf.c > +++ b/libavcodec/h264_mp4toannexb_bsf.c > @@ -259,7 +259,7 @@ static int h264_mp4toannexb_filter(AVBSFContext > *ctx, AVPacket *opkt) > > count_or_copy(&out, &out_size, buf, nal_size, > unit_type == H264_NAL_SPS || unit_type == > H264_NAL_PPS, j); > - if (!new_idr && unit_type == H264_NAL_SLICE) { > + if (unit_type == H264_NAL_SLICE) { > new_idr = 1; > sps_seen = 0; > pps_seen = 0; Ping for review. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".